Repository navigation
release, nightly: resume a complete staged release; nightly publishes by id (stacked on #21137) #21140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
release, nightly: resume a complete staged release; nightly publishes by id (stacked on #21137) #21140
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
34290f8
release: publish the staged release by id and refuse duplicate drafts
lawrencecchen fddb778
release: refuse any second release for the tag before upload; retry t…
lawrencecchen 769cf27
release, nightly: resume a complete staged release; nightly publishes…
lawrencecchen dd0cf41
release: resume only a staged draft, exact asset count on resume
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Move release finalization to a reachable publication job.
The
publish-nightlyjob runs only whenneeds.decide.outputs.should_publish != 'true'. The asset publisher and both new finalization steps requireshould_publish == 'true'. As a result, none of these steps can run in this job. Move the release-ID publication steps to the job that handles published builds, or change the job condition and its branch-artifact flow together.🤖 Prompt for AI Agents