Repository navigation
cmux-tui smoke: read the sidebar order after a workspace drag (base red) - #20806
teamleaderleo wants to merge 1 commit into
Conversation
With the sidebar document (sidebar-v2 S6, sidebar-doc-v1) a workspace row drop is a sidebar.move: it changes the sidebar's personal order, not the session order list-workspaces reports. The smoke asserted the session order, so the hosted full Linux run failed at the drag reorder check although the drop worked. It now reads workspace list --order personal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
|
Superseded by 3e2d1f4 on feat-cmux-next (Lawrence): the real cause is that a new workspace now goes to the top of the sidebar document, so the old drag moved workspace-2 back below the original. Reading the personal order alone was not enough (hosted full run 38659909516 still failed). Closing. |
The hosted full Linux cmux-tui run fails at
smoke-tui.py:953, the sidebar workspace drag reorder check. Two branches hit it: runs 38655302576 and 38650424161.Cause
The drop works, but the smoke checks the wrong order.
Since sidebar-v2 S6 (74680c3, 0f54f1a, 4211af2), a daemon that advertises
sidebar-doc-v1handles a workspace row drop as onesidebar.movein the sidebar document. That changes the sidebar's personal order. It doesn't change the session order thatlist-workspacesreports. The smoke still asserted the session order, so after a good drop it saw the old order:Fix
The smoke reads the sidebar order with
workspace list --order personal, by resource id, after the drag and again after the click on the moved row.The rest of the step is unchanged. The click on row 6 still has to switch to the original workspace, and the typed marker has to land in that workspace's surfaces. That checks the drawn order too.
Verification
Hosted full run 38659909516 on this head; the result follows in a comment.
Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the cmux-tui smoke test so its sidebar workspace drag reorder check passes. The drag updates the sidebar's personal order (via
sidebar-doc-v1), not the session order thatlist-workspacesreports, so the test now readsworkspace list --order personalinstead.Written for commit 25c453f. Summary will update on new commits.