Skip to content

cmux-tui smoke: read the sidebar order after a workspace drag (base red) - #20806

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
op-next-icons/smoke-drag-order
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
op-next-icons/smoke-drag-order

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

The hosted full Linux cmux-tui run fails at smoke-tui.py:953, the sidebar workspace drag reorder check. Two branches hit it: runs 38655302576 and 38650424161.

Cause

The drop works, but the smoke checks the wrong order.

Since sidebar-v2 S6 (74680c3, 0f54f1a, 4211af2), a daemon that advertises sidebar-doc-v1 handles a workspace row drop as one sidebar.move in the sidebar document. That changes the sidebar's personal order. It doesn't change the session order that list-workspaces reports. The smoke still asserted the session order, so after a good drop it saw the old order:

[smoke-ws, workspace-2]

Fix

The smoke reads the sidebar order with workspace list --order personal, by resource id, after the drag and again after the click on the moved row.

The rest of the step is unchanged. The click on row 6 still has to switch to the original workspace, and the typed marker has to land in that workspace's surfaces. That checks the drawn order too.

Verification

Hosted full run 38659909516 on this head; the result follows in a comment.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the cmux-tui smoke test so its sidebar workspace drag reorder check passes. The drag updates the sidebar's personal order (via sidebar-doc-v1), not the session order that list-workspaces reports, so the test now reads workspace list --order personal instead.

Written for commit 25c453f. Summary will update on new commits.

View guided diff Turn on auto-fix

With the sidebar document (sidebar-v2 S6, sidebar-doc-v1) a workspace row drop
is a sidebar.move: it changes the sidebar's personal order, not the session
order list-workspaces reports. The smoke asserted the session order, so the
hosted full Linux run failed at the drag reorder check although the drop
worked. It now reads workspace list --order personal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 15, 2026 00:27 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 59bcbe83-7f44-42da-8b8e-35431b1d1000

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-02j5d created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Superseded by 3e2d1f4 on feat-cmux-next (Lawrence): the real cause is that a new workspace now goes to the top of the sidebar document, so the old drag moved workspace-2 back below the original. Reading the personal order alone was not enough (hosted full run 38659909516 still failed). Closing.

@teamleaderleo
teamleaderleo deleted the op-next-icons/smoke-drag-order branch October 15, 2026 04:57

This branch was previously deployed

2 inactive deployments
artifacts — 25c453f1 Deployed Oct 15, 2026 by teamleaderleo via publish tree-addressed cmux-tui #15448
cmux-tui-merge-tree — 25c453f1 Deployed Oct 15, 2026 by teamleaderleo via publish the merge tree #1093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant