[teamleaderleo]

Base red on feat-cmux-next since c52607b (cx-ebm.60.6): the cmux-next checks job fails "No literal state roots" on cmux-tui/crates/cmux-tui-core/src/chief_brains.rs:953, which joins .cmux/chief/default to HOME to keep NIGHTLY's shared Chief home out of the old-acpmux-home cleanup.

The path now comes from the resolver that names it, BuildIdentity::new(Some(NIGHTLY_BUNDLE_ID), None).chief_home(home, "default") (cmux-agent-pane-policy). That is the same path, so the guard doesn't change. cmux-tui-core gains a dependency on cmux-agent-pane-policy, which depends only on serde, serde_json and unicode-normalization, so there's no cycle. The lockfile line is added by hand, in sorted order.

The IdleOwnerRestart concurrency red that was folded in here is now fixed on base by 79ce2f2 (cx-zt04u), so this PR is back to the chief_brains change only (#20772 stays closed).

Verification

• scripts/cmux-next/check-state-roots.sh: ok (was 1 line over baseline).

• scripts/cmux-next/check-concurrency.sh: ok on the merged head.

• scripts/cmux-next/crash_ratchet.py: ok.

• Rust build, tests, clippy and the Windows GNU build: this PR's CI jobs (no local cargo on my machine).

• Full cmux-tui gate on this head (run 38657371692): Windows, MSRV, Chief tests, valgrind and every release build pass. Two reds are base reds, not this change, and the merge goes past them on the coordinator's call:

  • test (linux): smoke-tui.py:953, workspace order after a drag; fixed by cmux-tui smoke: read the sidebar order after a workspace drag (base red) #20806.
  • lint (linux): the god-file cap on chief_brains.rs. Base is already at 1008 lines, over the 1000-line cap; this change adds 3. A split is owned by the lane working on that file (cx-ebm.60.6).

• cmux/reservation on chief_brains.rs lapsed at 00:35Z.

Changelog

none

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes two base reds on feat-cmux-next that fail the cmux-next checks job.

• cmux-tui-core now asks BuildIdentity for NIGHTLY's shared Chief home path instead of joining a literal .cmux/chief/default string, fixing the "No literal state roots" check while keeping the cleanup guard unchanged. The new dependency cmux-agent-pane-policy introduces no cycle (it only relies on serde, serde_json, and unicode-normalization); the lockfile entry was added manually in sorted order.
• IdleOwnerRestart.attempt() adds the reviewed // wakeup-allow: comment the concurrency check requires. Its repeat is event-driven, not a poll: it runs again only when another attempt() arrived during the probe.

Verification

scripts/cmux-next/check-state-roots.sh, check-concurrency.sh, and crash_ratchet.py pass; Rust build/tests/clippy and the Windows GNU build run in this PR's CI.

^{Written for commit 2dfcd90. Summary will update on new commits.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: f54cec93-318a-41d2-9e05-35f05512fcba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Passes: CI passes on 2dfcd90cfd.

CI passes on 2dfcd90cfd (run 38660602502 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.