Repository navigation
CmuxNext: a one-line status keeps a sidebar row one line - #20637
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
cg-design-judge's sidebar Thunderdome (Tact #115): status set --state busy drew no glyph, and a one-line status doubled the row (24 to 40 pt). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b2258f0 to
74ef747
Compare
A one-line status on an otherwise one-line row (one reported entry, or the hooks' status line) now sits dim on the right of the name's line, truncated at 40% of the row, instead of a second line that grew the row from 24 to 40 pt. A richer block (several entries, a log line or a progress label) still draws under the name, as do rows with another second-line element. The hover card lists every entry; VoiceOver reads the text. A status's state already reaches the row's badge on this base: busy draws the grey spinner (the default row shows progress), and failed and waiting draw their colored glyphs (#20492). The tests guard those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
74ef747 to
3b99e2c
Compare
|
cmux-next tour of The tour job failed before the tour ran (build or setup); the run log has the output. The tour produced no media. Tours are data in |
cg-design-judge's sidebar Thunderdome (Tact #115, 108 blind bouts on the cmux NEXT sidebar) reported two status bugs (items 1 and 4). Bead cx-npdew.
Item 4: a one-line status doubled the row (24 to 40 pt). By default a row draws reported status under the name, so one "Building" made the row two lines and the list's pitch jumped with state.
cmux status set) or the hooks' status line.Item 1: status was invisible. On the current base this is already fixed, so this PR adds only guard tests:
ee8d80672c35) predates CmuxNext: sidebar rows badge their logo's corner instead of a count #20492's row badges.cmux status set --state busydraws the grey spinner, because the default row shows progress.--state errordraws the red glyph and--state waitingthe question glyph, on the icon's corner. Routine states stay quiet.Found while capturing, not fixed here:
cmux status setrun the moment a new tab's shell starts can fail withno terminal matches "term_...", because the tab's terminal is not registered yet.In the app
Fleet DEV builds of base (
64944d6a7586) and this head, same seed, dark theme:Tests
SidebarStatusVisibleTests(new), at the mapping-to-row boundary (daemon store,SidebarMapping, layout, row view):status set --state busyrow draws the busy glyph; a failure and a question draw theirs.Changed fixtures:
SidebarMinimalModeTestsreports two entries, so its "status draws under the name" case is still a block.SidebarStatusGlyphCenterTeststurns the folder element on, so its two-line row still has a second line.Fleet receipts:
c58e0b1f4266(light stepeb97026c4827a440d64946ef):SidebarStatusVisibleTestsfails on behavior. The rows are 36 and 40 pt, the subtitle and block draw, and nothing is on the name's line. The two guard tests pass on base, as expected.3b99e2c34c4b(light stepbb1d4c2e1d60f62e661aad25):SidebarStatusVisibleTests,SidebarStatusBlockTests,SidebarMinimalModeTests,SidebarStatusGlyphCenterTestsand 291 other suites pass. The reds come from base:AgentChatFromHomeTestsandSettingsSchemaExportTestsfail the same way on the red run.3b99e2c34c4b(isolated step44e6d562aa26bc63d612b4cf):BUILD SUCCEEDED.Review notes (Opus, no blocking findings):
SidebarStatusVisibleTests' doc comment says this change sends a status's state to the badge; base already did that (CmuxNext: sidebar rows badge their logo's corner instead of a count #20492). The two glyph tests guard that existing behavior.Changelog
Showcase
Open the live gallery
🤖 Generated with Claude Code