Repository navigation
Fix update-channel regressions: nightly exit + older nightly filtering - #115
Closed
lawrencecchen wants to merge 5 commits into
Closed
lawrencecchen wants to merge 5 commits into
lawrencecchen wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Older manaflow preview screenshots (latest comment is below)Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Screenshot status is unknown for this run. Generated by manaflow preview system |
Contributor
Older manaflow preview screenshots (latest comment is below)Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Screenshot capture was skipped.
Generated by manaflow preview system |
Contributor
Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Screenshot capture was skipped.
Generated by manaflow preview system |
lawrencecchen
added
the
stale-revisit
teamleaderleo
added a commit
that referenced
this pull request
Oct 14, 2026
cg-design-judge's sidebar Thunderdome (Tact #115): status set --state busy drew no glyph, and a one-line status doubled the row (24 to 40 pt). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 14, 2026
* test: a reported status shows its glyph and keeps a one-line row's pitch cg-design-judge's sidebar Thunderdome (Tact #115): status set --state busy drew no glyph, and a one-line status doubled the row (24 to 40 pt). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: a one-line status keeps a one-line sidebar row's height A one-line status on an otherwise one-line row (one reported entry, or the hooks' status line) now sits dim on the right of the name's line, truncated at 40% of the row, instead of a second line that grew the row from 24 to 40 pt. A richer block (several entries, a log line or a progress label) still draws under the name, as do rows with another second-line element. The hover card lists every entry; VoiceOver reads the text. A status's state already reaches the row's badge on this base: busy draws the grey spinner (the default row shows progress), and failed and waiting draw their colored glyphs (#20492). The tests guard those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.58.xand getting offered0.56.x-nightly)Why
Two bad update-channel edge cases were possible:
onNewerThanLatestVersion).What changed
Sources/Update/UpdateDelegate.swiftUpdateChannelSettingsshouldOfferNightlyCandidate(...)guardbestValidUpdate(in:for:)logic:>=current semantic versionSUAppcastItem.empty()to avoid falling back to an older nightly suggestioncmuxTests/CmuxWebViewKeyEquivalentTests.swift0.58current vs0.56-nightlycandidate)Verification
xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux-unit -configuration Debug -destination 'platform=macOS' -only-testing:cmuxTests/UpdateChannelSettingsTests test./scripts/reload.sh --tag fix-nightly-exitxcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug -destination 'platform=macOS' build