[teamleaderleo]

Summary

First step of a typed acpmux protocol (plan: manaflow-ai/cmuxterm-hq#2025; T3 Code's packages/contracts is the model). Rust is the source of truth, and the web gets generated types plus a typed request, with drift checks on both sides.

• Registry (cmux-tui/crates/acpmux/src/protocol/).
  • Names all 121 methods and notifications acpmux serves or sends (ACP, _acpmux/*, catalog.*, chats, transfer), with their kind.
  • Typed so far: _acpmux/sessions, _acpmux/permission_respond, _acpmux/permission_groups, _acpmux/permission_group_respond, _acpmux/permission_chat_revoke, and the _acpmux/session_changed and _acpmux/permission_pending notifications.
  • Every other method is declared as any JSON until it is typed.
• The daemon builds from the types.
  • Hub::session_summary builds SessionSummary, and permission groups build PermissionGroup.
  • Reviewed for wire equivalence against the old json! output; no key, null or number changes.
  • One fix: a non-UTF-8 cwd is now lossy instead of a json! panic.
• IR. spec/acpmux-protocol.json holds JSON Schema 2020-12 from schemars.
• Web.
  • webviews/scripts/acpmux-protocol-codegen.ts generates agent-session/acpmux/protocol/generated/: one type per schema, plus AcpmuxRequests, AcpmuxNotifications and ACPMUX_METHODS.
  • protocol/client.ts adds typedRequest and isNotification.
  • The permission group client, permission_respond, and the session_changed and permission_pending handlers now use them, and the hand-written permission types alias the generated ones.
• Drift checks.
  • Rust: protocol_ir_is_current fails on a stale IR (bless with ACPMUX_PROTOCOL_BLESS=1).
  • Rust: protocol_registry_names_every_served_method fails when rpc::method or a server literal names a method the registry lacks.
  • Web: bun run check now ends with acpmux-protocol:check, which fails on stale generated TS.

Follow-ups in hq#2025: type the rest (attach, detach, view, events, watch, then everything else); serve the IR from _acpmux/schema and retire the hand-written docs/acpmux-schema.json; Swift Codable.

Changelog

none

Verification

All of this ran on the private Linux builder, on the merged head (base 93d4ef2):

• cargo test --locked -p acpmux --lib protocol_: 3 passed.
• cargo clippy --locked -p acpmux --all-targets -- -D warnings: clean.
• bun run check in webviews: green, including the new drift check and the typecheck of 1318 files.
• bun test src/agent-session/acpmux/protocol: 4 pass.
• Two non-browser permission and queue tests pass. The chromium tests were skipped on the builder (no browser installed there), so CI runs them.

The crash ratchet is ok.

No UI change.

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Turns acpmux into a typed protocol: one Rust registry names every method and notification, and the web gets generated types plus a typed request from it.

• Typed so far: sessions, permission group, respond, and revoke, plus the session_changed and permission_pending notifications; the rest are any JSON.
• The daemon builds SessionSummary and PermissionGroup from the types; a non-UTF-8 cwd is now lossy instead of a json! panic.
• The session summary carries the lane fields (lane, inputSince, lastTurn.detail) and chat tools (tools, toolsMutable); the workspace field was dropped again with the branch's last merge.
• spec/acpmux-protocol.json holds the JSON Schema 2020-12 IR; codegen lives beside the pane protocol codegen, outside the pane sources, so pane-english does not scan its developer-facing errors.
• Web views get generated types plus typedRequest and isNotification helpers.
• Drift checks fail on a stale IR or generated web types, and when the dispatcher serves a method the registry lacks (bless with ACPMUX_PROTOCOL_BLESS=1); they caught offer_session, offer_respond, prompt_withdraw, the tools, stats, bookmark, and process methods, now registered as untyped requests.
• Follow-ups: type the rest of the methods, serve the IR from _acpmux/schema, add Swift Codable.

<pull_request_end>

^{Written for commit 563926c. Summary will update on new commits.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 961ce922-7d77-4690-99d9-ba61644089b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

all web/size checks green

[github-actions]

Passes: CI passes on 563926ce20.

CI passes on 563926ce20 (run 38662673687 attempt 2).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

[github-actions]

CI fast guards passes on 563926ce20 (https://github.com/manaflow-ai/cmux/actions/runs/38662673687). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

[github-actions]

cmux-next tour of 88b624c7517bfb3df153438e88c7d43187c7ef24 (run)

The tour job failed before the tour ran (build or setup); the run log has the output.

The tour produced no media.

_{Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.}

[github-actions]

Gallery

Review in feed

227 states changed: gallery.visual-media-board/all-previews, agent-pane.edited-files/fourteen-files, agent-pane.transcript/shell-grouped-commands, pages.settings/notifications-group-2, pages.settings/general-group-3, ... · 2 new states · 48 broken states · 106 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State	Before · after
gallery.visual-media-board/all-previews (Apple System Colors, chromium)
agent-pane.edited-files/fourteen-files (Apple System Colors, chromium)
agent-pane.transcript/shell-grouped-commands (Apple System Colors Light, webkit)
pages.settings/notifications-group-2 (Apple System Colors, webkit)
pages.settings/general-group-3 (Apple System Colors, webkit)
pages.settings/browser-group-8 (Apple System Colors, webkit)

221 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

• gallery.visual-media-board/all-previews: /wt/cx-acpmux-typed-protocol/?entry=gallery.visual-media-board#/gallery.visual-media-board/all-previews
• agent-pane.edited-files/fourteen-files: /wt/cx-acpmux-typed-protocol/?entry=agent-pane.edited-files#/agent-pane.edited-files/fourteen-files
• agent-pane.transcript/shell-grouped-commands: /wt/cx-acpmux-typed-protocol/?entry=agent-pane.transcript#/agent-pane.transcript/shell-grouped-commands
• pages.settings/notifications-group-2: /wt/cx-acpmux-typed-protocol/?entry=pages.settings#/pages.settings/notifications-group-2
• pages.settings/general-group-3: /wt/cx-acpmux-typed-protocol/?entry=pages.settings#/pages.settings/general-group-3
• pages.settings/browser-group-8: /wt/cx-acpmux-typed-protocol/?entry=pages.settings#/pages.settings/browser-group-8
• 132 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

• gallery.visual-media-board/all-previews (Apple System Colors, chromium): step 1 click button "Pause previews": layout shift 0.0002 (limit 0) · step 2 click button "Play previews": layout shift 0.0002 (limit 0) · play: waitFor did not hold within 5000 ms
• agent-pane.artifact-panel/versions (Apple System Colors Light, webkit): play: no element for button "Open preview"
• agent-pane.artifact-panel/markdown (Apple System Colors Light, chromium): play: no element for button "Open preview"
• agent-pane.dictation/hide (Apple System Colors Light, webkit): play: no element for menuitem "Hide Dictation Button"
• ui.disclosure/controlled (Apple System Colors Light, webkit): step 1 click button "Advanced settings": anchor .disclosure-gallery-receipt moved 110.0 px (limit 0) · step 2 click button "Advanced settings": anchor .disclosure-gallery-receipt moved 110.0 px (limit 0)
• agent-pane.changes-scope-menu/open (Apple System Colors Light, webkit): play: waitFor did not hold within 5000 ms
• 594 more on the diff page

636 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

_{6635 unchanged · base eddae17 · head 5ef117c}

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[teamleaderleo]

Visual preview of 594928e: in the maintainers' private review feed.