[teamleaderleo]

The fleet Release compile of feat-cmux-next is red. swift-frontend (Xcode 26.6) crashes in EarlyPerfInliner (isCallerAndCalleeLayoutConstraintsCompatible) on the deinit of ThemedPicker.Coordinator, a MainActor class nested in the generic ThemedPicker<ID>. The crash started after the package moved to a macOS 14 deployment target (ae36648).

The cause is one class of bug. In the UI targets (defaultIsolation(MainActor)) a class's deinit is isolated, and below macOS 15 that runs through the back-deploy path. The Release inliner crashes on it for a generic class. TaskLocal+InTask's ImmediateRun already opts out with nonisolated deinit {}.

• ThemedPicker: the pop-up's target is now one non-generic class, ThemedPickerTarget. On each update the picker sets the closure it calls. Behavior is unchanged: a choice still writes the binding, and an out-of-range index is still ignored.
• CEFReplyWaiters and BrowserHistoryWriter.Once, the remaining main-actor generic classes, get a nonisolated deinit {}. The first fix's compile crashed next on CEFReplyWaiters. Neither class had a deinit body.

A scan of the package's Sources (generic classes, and classes nested in generic types) finds no other main-actor generic class without a nonisolated deinit.

Verification

• Red: fleet Release compile of base afbe6fa crashes on ThemedPicker.Coordinator's deinit.
• Green: fleet Release compile of this head (receipt in a comment below).
• check-concurrency.sh and crash_ratchet.py pass.

Changelog

none

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes the fleet Release compile crash of feat-cmux-next: swift-frontend (Xcode 26.6) crashed in EarlyPerfInliner on the deinit of ThemedPicker.Coordinator, a MainActor class nested in the generic ThemedPicker<ID>, after the package moved to a macOS 14 deployment target.

The cause is one class of bug. In the UI targets (defaultIsolation(MainActor)) a class's deinit is isolated, and below macOS 15 that runs through the back-deploy path. The Release inliner crashes on it for a generic class; TaskLocal+InTask's ImmediateRun already opts out with nonisolated deinit {}.

• ThemedPicker: the pop-up's target is now one non-generic class, ThemedPickerTarget. On each update the picker sets the closure it calls. Behavior is unchanged: a choice still writes the binding, and an out-of-range index is still ignored.
• CEFReplyWaiters and BrowserHistoryWriter.Once, the remaining main-actor generic classes, get a nonisolated deinit {}. Neither had a deinit body.
• A scan of the package's Sources finds no other main-actor generic class without a nonisolated deinit.

Verification

• Fleet Release compile of the old base crashes on ThemedPicker.Coordinator's deinit; this head compiles green.
• check-concurrency.sh and crash_ratchet.py pass.

^{Written for commit 503464c. Summary will update on new commits.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 621ac81e-9c32-4cb1-b8d8-35bac4ca48f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Not verified: macOS jobs did not run: compile and app tests were skipped on 503464c8f6; ci-status is green without them.

CI passes on 503464c8f6 (run 38505906780 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

[teamleaderleo]

Bisect from op-next-continuity, fleet Release compiles:

• Green at 6686ace, b7cd53c, ef964fd, 46fadb9 and cabe2b6.
• Red at 583b209, aabc496 and 437e006.

The only Package.swift change in the gap is ae36648 (deployment target 26 to 14); its own compile was cancelled. The red runs crash the same way: swift-frontend 6.3.3, -O -wmo, arm64-apple-macos14.0, EarlyPerfInliner isCallerAndCalleeLayoutConstraintsCompatible on ThemedPicker.Coordinator's deallocating deinit, exit 65 with no error line. This PR removes the generic nested coordinator, the only class the crash names.

[teamleaderleo]

Fleet Release compile on 503464c: exit 0 (check-release-compile.sh, isolated). It's green past both earlier crash sites: ThemedPicker in CmuxNextDesign and CEFReplyWaiters in CmuxNextBrowser. Review subagent: no blockers. lint-ios-package-conventions.sh, check-concurrency.sh and crash_ratchet.py pass.