Agent chat: the trust ask names a chat's private folder in words by teamleaderleo · Pull Request #20160 · manaflow-ai/cmux

teamleaderleo · 2026-10-13T04:44:39Z

Agent chat dogfood on a capture mini (DEV build of feat-cmux-next). A new chat in a workspace starts in its private folder under ~/Library/Application Support/cmux/agent-home/…. Its trust ask read "The agent can edit and run code in /User…": the raw path, cut off before it named anything, so the one decision the chat asks for had no subject.

That folder is now named in words: "The agent can edit and run code in this chat's private folder", and after the answer "Trusted this chat's private folder" or "Won't trust this chat's private folder". The full path is in the tooltip. A project folder still shows its name ("atlas-web").

Localization: three new sentence keys (trust.askPrivate, trust.trustedPrivate, trust.untrustedPrivate) in all 21 agent pane locales, written as whole sentences because the folder slot takes different grammatical cases across locales (pl, ru, de). generated/strings.json was regenerated with gen-strings.mjs agentPane. ./scripts/localize-changes reports no new macOS keys and no changed web messages.

Verification

Red at cce50e7 (test only): bun test test/trust-ask-private-folder.test.tsx received the raw path.
Green on this head: that test (2 pass), ui-rules (4 pass), and bun run check formatting and lint. Typecheck fails only on NewTabPage.gallery.tsx, a base red from cx-39b5r: New Tab always lands on the New Tab page; drop the template dots #20127 that this branch does not touch.

Changelog

Fixed: The folder trust question names a chat's private folder in words instead of a cut-off path.

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Fixes the agent chat trust ask so a chat's private folder is named in words ("this chat's private folder") instead of the raw path, which was cut off before it named anything.

The full path now lives in the tooltip, and project folders still show their name.
Adds three new sentence keys (trust.askPrivate, trust.trustedPrivate, trust.untrustedPrivate) in all 21 agent pane locales, plus tests for the private-folder and project-folder cases.

^{Written for commit 986194e. Summary will update on new commits.}

Agent chat dogfood: the ask showed the private folder's raw path, cut to "/User…". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A workspace's new chat starts in its private folder under Application Support, and its trust ask showed the raw path, cut to "/User…". The ask and its answer now say "this chat's private folder", with the path in the tooltip. Three new strings in all 21 agent pane locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-13T04:44:50Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 0b0aa9bf-76a5-485d-9feb-8e7801dd4543

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-13T04:46:40Z

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 986194e29c (run 38348978677 attempt 1): 1 unknown.

Job	Verdict	Why
web / react-apps-check	unknown	no known signature; failed step: `Test webviews`

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

github-actions · 2026-10-13T04:47:20Z

CI fast guards failed on 986194e29c (https://github.com/manaflow-ai/cmux/actions/runs/38348978677). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

blacksmith-sh · 2026-10-13T05:10:31Z

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
`test/harnesses-page.test.tsx/harnesses-page.test.tsx`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

teamleaderleo · 2026-10-13T05:13:45Z

Merge receipt for head 986194e: react-apps-check ran test/trust-ask-private-folder.test.tsx and it passed. The one red is a base red: the page shows each harness's state on this Mac also fails on #20159, which doesn't touch this area. The gallery render matrix only reports results and doesn't gate the merge.

github-actions · 2026-10-13T05:58:06Z

Gallery

Review in feed

216 states changed: agent-pane.transcript/long-code, agent-pane.artifact-panel/markdown, agent-pane.artifact-panel/versions, agent-pane.artifact-panel/html, agent-pane.trust-ask/trusted, ... · 3 new states · 50 broken states · 96 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State	Before · after
agent-pane.transcript/long-code (Apple System Colors, webkit)
agent-pane.artifact-panel/markdown (Apple System Colors, chromium)
agent-pane.artifact-panel/versions (Apple System Colors, chromium)
agent-pane.artifact-panel/html (Apple System Colors, chromium)
agent-pane.artifact-panel/html (Apple System Colors, chromium)
agent-pane.trust-ask/trusted (Apple System Colors Light, chromium)

210 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

agent-pane.transcript/long-code: /wt/op-next-trust-private-folder/?entry=agent-pane.transcript#/agent-pane.transcript/long-code
agent-pane.artifact-panel/markdown: /wt/op-next-trust-private-folder/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/markdown
agent-pane.artifact-panel/versions: /wt/op-next-trust-private-folder/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/versions
agent-pane.artifact-panel/html: /wt/op-next-trust-private-folder/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/html
agent-pane.trust-ask/trusted: /wt/op-next-trust-private-folder/?entry=agent-pane.trust-ask#/agent-pane.trust-ask/trusted
pages.settings/browser-group-2: /wt/op-next-trust-private-folder/?entry=pages.settings#/pages.settings/browser-group-2
124 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

agent-pane.artifact-panel/markdown (Apple System Colors, chromium): play: no element for button "Open preview"
agent-pane.artifact-panel/versions (Apple System Colors, chromium): play: no element for button "Open preview"
agent-pane.artifact-panel/html (Apple System Colors, chromium): play: no element for button "Open preview"
agent-pane.artifact-panel/html (Apple System Colors, chromium): play: no element for button "Open preview"
agent-pane.trust-ask/trusted (Apple System Colors Light, chromium): step 1 click button "Undo": layout shift 0.0171 (limit 0)
agent-pane.trust-ask/trusted (Apple System Colors, chromium): step 1 click button "Undo": layout shift 0.0171 (limit 0)
522 more on the diff page

566 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

_{6369 unchanged · base 3bfa441 · head 986194e}

teamleaderleo and others added 2 commits October 12, 2026 21:40

test: a trust ask names a chat's private folder in words

cce50e7

Agent chat dogfood: the ask showed the private folder's raw path, cut to "/User…". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge origin/feat-cmux-next (base typecheck fix #20159)

986194e

teamleaderleo merged commit 14099a3 into feat-cmux-next Oct 13, 2026
98 of 100 checks passed

teamleaderleo deleted the op-next-trust-private-folder branch October 13, 2026 05:13

teamleaderleo mentioned this pull request Oct 13, 2026

fix: Home reads the open conversation when the page shows #20173

Merged

Navigation Menu

Repository navigation

Agent chat: the trust ask names a chat's private folder in words - #20160

Agent chat: the trust ask names a chat's private folder in words#20160
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
op-next-trust-private-folder

teamleaderleo commented Oct 13, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

blacksmith-sh Bot commented Oct 13, 2026

Uh oh!

teamleaderleo commented Oct 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 13, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Verification

Changelog

Summary by cubic

Uh oh!

coderabbitai Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blacksmith-sh Bot commented Oct 13, 2026

Failure

Uh oh!

teamleaderleo commented Oct 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026

Gallery

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 13, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading

github-actions Bot commented Oct 13, 2026 •

edited

Loading

github-actions Bot commented Oct 13, 2026 •

edited

Loading