Skip to content

fix(webviews): align new tab gallery with current props - #20159

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/cx-bl-newtab-gallery-base
Oct 13, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/cx-bl-newtab-gallery-base

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Changelog

Fixed the legacy New Tab gallery fixture to match the current NewTabPage props after #20127 removed default-kind and harness callbacks.

This clears the feat-cmux-next web typecheck base red introduced by the merged gallery coverage change.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the legacy New Tab gallery fixture so the feat-cmux-next web typecheck base passes again after #20127 removed the default-kind and harness callback props.

  • Drops defaultKind, onSetDefaultKind, and onAddHarness from the fixture and the withReceipt wrapper, along with their recording callbacks.

Written for commit e5dc46a. Summary will update on new commits.

View guided diff Turn on auto-fix

@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b9e5ed48-be0d-41bb-ab09-d56b32d91df3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Gallery

Review in feed

2 states changed: agent-pane.new-tab-page/prefixes, agent-pane.new-tab-page/folder-chooser · 1 play check failed

Diff page and renders (the run's gallery-pr artifact)

State Before · after
agent-pane.new-tab-page/prefixes (Apple System Colors, chromium)
agent-pane.new-tab-page/folder-chooser (Apple System Colors, webkit)

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

  • agent-pane.new-tab-page/prefixes: /wt/fix-cx-bl-newtab-gallery-base/?entry=agent-pane.new-tab-page#/agent-pane.new-tab-page/prefixes
  • agent-pane.new-tab-page/folder-chooser: /wt/fix-cx-bl-newtab-gallery-base/?entry=agent-pane.new-tab-page#/agent-pane.new-tab-page/folder-chooser

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

  • agent-pane.new-tab-page/default-kind (Apple System Colors Light, chromium): play: no element for .acpmux-newtab-default
  • agent-pane.new-tab-page/default-kind (Apple System Colors Light, webkit): play: no element for .acpmux-newtab-default
  • agent-pane.new-tab-page/default-kind (Apple System Colors Light, chromium): play: no element for .acpmux-newtab-default
  • agent-pane.new-tab-page/default-kind (Apple System Colors Light, webkit): play: no element for .acpmux-newtab-default
  • agent-pane.new-tab-page/default-kind (Apple System Colors, chromium): play: no element for .acpmux-newtab-default
  • agent-pane.new-tab-page/default-kind (Apple System Colors, webkit): play: no element for .acpmux-newtab-default
  • 2 more on the diff page

9 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

61 unchanged · base b392213 · head e5dc46a

@blacksmith-sh

blacksmith-sh Bot commented Oct 13, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test/harnesses-page.test.tsx/harnesses-page.test.tsx View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on e5dc46a8a5 (run 38347731024 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

Copy link
Copy Markdown
Contributor

CI fast guards failed on e5dc46a8a5 (https://github.com/manaflow-ai/cmux/actions/runs/38347731024). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

@teamleaderleo
teamleaderleo merged commit 3bfa441 into feat-cmux-next Oct 13, 2026
100 of 102 checks passed
@teamleaderleo
teamleaderleo deleted the fix/cx-bl-newtab-gallery-base branch October 13, 2026 04:56
lawrencecchen added a commit that referenced this pull request Oct 13, 2026
… (cx-cdcff)

6b7ab55 (#20127) removed the New Tab page's default-kind toggle and its
props; 3946abe (#19041) landed after it with the props and a play that
clicks .acpmux-newtab-default. 3bfa441 (#20159) fixed the typecheck by
dropping the props but kept that play, which clicks an element that no longer
exists. The play becomes a no-default-toggle check, matching #20127's intent.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant