Repository navigation
fix(webviews): align new tab gallery with current props - #20159
Conversation
cx-bl-chief base-red fix
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gallery2 states changed: agent-pane.new-tab-page/prefixes, agent-pane.new-tab-page/folder-chooser · 1 play check failed Diff page and renders (the run's
Live preview (follows this branch; start it with
Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):
9 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes. |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Unclear: CI failed on
Not re-run automatically: Written by |
|
Agents: |
… (cx-cdcff) 6b7ab55 (#20127) removed the New Tab page's default-kind toggle and its props; 3946abe (#19041) landed after it with the props and a play that clicks .acpmux-newtab-default. 3bfa441 (#20159) fixed the typecheck by dropping the props but kept that play, which clicks an element that no longer exists. The play becomes a no-default-toggle check, matching #20127's intent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>


Changelog
Fixed the legacy New Tab gallery fixture to match the current NewTabPage props after #20127 removed default-kind and harness callbacks.
This clears the feat-cmux-next web typecheck base red introduced by the merged gallery coverage change.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the legacy New Tab gallery fixture so the
feat-cmux-nextweb typecheck base passes again after #20127 removed the default-kind and harness callback props.defaultKind,onSetDefaultKind, andonAddHarnessfrom the fixture and thewithReceiptwrapper, along with their recording callbacks.Written for commit e5dc46a. Summary will update on new commits.