Agent chat: a failed turn's error reads as its own block by teamleaderleo · Pull Request #20145 · manaflow-ai/cmux

teamleaderleo · 2026-10-13T04:06:38Z

Agent chat dogfood against the Codex and Claude desktop apps. A failed turn (rate limit, unreachable proxy, signed out) drew its error inside the turn's footer row: "Worked for 42s" and Retry on the left, the error and its Switch model / Copy error buttons squeezed in the middle, the time on the right. A two-line rate-limit message read as a narrow column next to the footer.

The failure now reads as the turn's answer does. It's a block above the footer row, and the footer row keeps Worked for, Retry and the time, same as a turn that answered.

Gallery (Transcript rows): before /live/?entry=agent-pane.transcript#/agent-pane.transcript/turn-error, after /wt/op-next-turn-error-layout/?entry=agent-pane.transcript#/agent-pane.transcript/turn-error (also turn-error-long, turn-error-unreachable, turn-error-signed-out).

Verification

Red at f13b9c6 (test only): bun test test/turn-error-layout.test.tsx failed, because the note was inside .cv-turn-actions.
Green on this head: that test, signed-out-harness and retry-model (5 pass), ui-rules (4 pass), and bun run check.

Changelog

Fixed: A failed agent turn shows its error as its own block above the turn's footer instead of squeezed between Worked for and the time.

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Fixes failed agent turn error layout so the error reads as its own block above the footer row, matching how a turn's answer displays, instead of being squeezed between Worked for and the time.

Bug Fixes

The error now renders above the footer row; the footer keeps Worked for, Retry, and the time.
Added a test asserting the error sits outside the footer row.

^{Written for commit 79361dd. Summary will update on new commits.}

Agent chat dogfood: the error drew inside the footer row, between Worked for and the time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The failure note drew inside the turn's footer row, between Worked for and Retry on the left and the time on the right, so a rate limit read as a narrow middle column. It now sits above the footer row, where the turn's answer would be. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-13T04:06:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 04e51264-7f78-4a5d-9bec-d0fbda606e78

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

blacksmith-sh · 2026-10-13T04:19:20Z

Found 2 test failures on Blacksmith runners:

Failures

Test	View Logs
`test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test`	View Logs
`test/model-chip-fresh-chat.test.tsx/model-chip-fresh-chat.test.tsx`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

github-actions · 2026-10-13T04:19:34Z

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 79361dda41 (run 38344877309 attempt 1): 1 unknown.

Job	Verdict	Why
web / react-apps-check	unknown	no known signature; failed step: `Test webviews`

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

github-actions · 2026-10-13T04:19:47Z

CI fast guards failed on 79361dda41 (https://github.com/manaflow-ai/cmux/actions/runs/38344877309). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

github-actions · 2026-10-13T04:27:44Z

Gallery

Review in feed

146 states changed: agent-pane.transcript/long-code, agent-pane.artifact-panel/versions, agent-pane.artifact-panel/markdown, agent-pane.transcript/turn-error-proxy-401, agent-pane.transcript/turn-error, ... · 51 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State	Before · after
agent-pane.transcript/long-code (Apple System Colors, webkit)
agent-pane.artifact-panel/versions (Apple System Colors, webkit)
agent-pane.artifact-panel/markdown (Apple System Colors, webkit)
agent-pane.transcript/turn-error-proxy-401 (Apple System Colors Light, webkit)
agent-pane.transcript/turn-error-proxy-401 (Apple System Colors, chromium)
agent-pane.transcript/turn-error-proxy-401 (Apple System Colors Light, chromium)

140 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

agent-pane.transcript/long-code: /wt/op-next-turn-error-layout/?entry=agent-pane.transcript#/agent-pane.transcript/long-code
agent-pane.artifact-panel/versions: /wt/op-next-turn-error-layout/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/versions
agent-pane.artifact-panel/markdown: /wt/op-next-turn-error-layout/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/markdown
agent-pane.transcript/turn-error-proxy-401: /wt/op-next-turn-error-layout/?entry=agent-pane.transcript#/agent-pane.transcript/turn-error-proxy-401
agent-pane.transcript/turn-error: /wt/op-next-turn-error-layout/?entry=agent-pane.transcript#/agent-pane.transcript/turn-error
agent-pane.transcript/turn-error-long: /wt/op-next-turn-error-layout/?entry=agent-pane.transcript#/agent-pane.transcript/turn-error-long
58 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

agent-pane.artifact-panel/versions (Apple System Colors, webkit): play: no element for button "Open preview"
agent-pane.artifact-panel/markdown (Apple System Colors, webkit): play: no element for button "Open preview"
agent-pane.artifact-panel/versions (Apple System Colors Light, webkit): play: no element for button "Open preview"
agent-pane.artifact-panel/markdown (Apple System Colors Light, webkit): play: no element for button "Open preview"
agent-pane.artifact-panel/versions (Apple System Colors Light, webkit): play: no element for button "Open preview"
agent-pane.artifact-panel/html (Apple System Colors Light, webkit): play: no element for button "Open preview"
258 more on the diff page

298 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

_{2028 unchanged · base c0a8cb1 · head 79361dd}

teamleaderleo · 2026-10-13T04:28:34Z

Gallery: the after state at /wt/op-next-turn-error-layout/?entry=agent-pane.transcript#/agent-pane.transcript/turn-error shows the error as a block above the footer row. Render and compare jobs pass. react-apps-check on 79361dd fails only on base reds: model-chip-fresh-chat (fixed on base by #20141, landed after this head) and agent-pane-no-capsules (red on base, #20127's run too). turn-error-layout and the other web tests pass.

teamleaderleo and others added 2 commits October 12, 2026 21:05

test: a failed turn's error sits above its footer row

f13b9c6

Agent chat dogfood: the error drew inside the footer row, between Worked for and the time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo mentioned this pull request Oct 13, 2026

A remote or resumed chat's model chip waits for its session (base red) #20141

Merged

teamleaderleo merged commit 6df5523 into feat-cmux-next Oct 13, 2026
99 of 102 checks passed

teamleaderleo deleted the op-next-turn-error-layout branch October 13, 2026 04:28

Navigation Menu

Repository navigation

Agent chat: a failed turn's error reads as its own block - #20145

Agent chat: a failed turn's error reads as its own block#20145
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
op-next-turn-error-layout

teamleaderleo commented Oct 13, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 13, 2026

Review skipped

Uh oh!

blacksmith-sh Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

teamleaderleo commented Oct 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 13, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Verification

Changelog

Summary by cubic

Uh oh!

coderabbitai Bot commented Oct 13, 2026

Review skipped

Uh oh!

blacksmith-sh Bot commented Oct 13, 2026

Failures

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Gallery

Uh oh!

teamleaderleo commented Oct 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 13, 2026 •

edited by cubic-dev-ai Bot

Loading