Skip to content

A remote or resumed chat's model chip waits for its session (base red) - #20141

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
op-next-model-chip-remote
Oct 13, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
op-next-model-chip-remote

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Base red on feat-cmux-next: test/model-chip-fresh-chat.test.tsx fails "a resumed or remote chat's chip does not guess a model" (seen on #20127's react-apps-check).

cx-ncc.58 (5f17347) landed after #19908. To keep the chip's width before a session reports, it names a predicted model: the default this harness last resolved to, else the catalog's. It did this for every unreported chip, including a chat on another machine, which then read this Mac's default ("Claude Sonnet 5") before its session said what it runs.

Now only a fresh chat on this Mac predicts, which is #19908's rule. A remote or resumed chat shows "Model" until its session reports. A fresh local chat keeps cx-ncc.58's steady width.

Verification

  • Red on base 87980a5: bun test test/model-chip-fresh-chat.test.tsx failed with Expected "Model", Received "Claude Sonnet 5".
  • Green on this head: 3 pass. The nearby chip and picker tests (new-tab-picker-fold, model-picker-picks, new-tab-picker-clip, new-tab-ask-model, effort-track-labels, model-picker-live-refresh, agent-pane-no-capsules) pass, and bun run check passes.

Changelog

Fixed: A remote or resumed chat's model chip no longer shows a guessed model before its session reports one.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the model chip on remote or resumed chats showing a guessed model name before the session reports one.

A remote or resumed chat's chip now shows "Model" until its session reports the actual model. Only a fresh chat on this Mac predicts its model, keeping the chip's steady width while waiting.

Written for commit 0e198e3. Summary will update on new commits.

View guided diff Turn on auto-fix

cx-ncc.58 named a predicted model on every chip whose session had not
reported, so a chat on another machine read this Mac's default (Claude
Sonnet 5) instead of waiting. Only a fresh chat on this Mac predicts, as
#19908's rule says. Fixes the base red model-chip-fresh-chat test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e00a7b0d-a0d9-4c1b-badc-9c0bf0b97d5e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

blacksmith-sh Bot commented Oct 13, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test View Logs
test/chat-find.test.ts/chat-find.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 0e198e3582 (run 38344045189 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

Copy link
Copy Markdown
Contributor

CI fast guards failed on 0e198e3582 (https://github.com/manaflow-ai/cmux/actions/runs/38344045189). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

@github-actions

Copy link
Copy Markdown
Contributor

Gallery

Review in feed

73 states changed: agent-pane.dictation/hide, agent-pane.composer/working-stop, agent-pane.transcript/shell-grouped-commands, agent-pane.new-tab/dictation-show, agent-pane.composer/queued-keyboard, ... · 22 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State Before · after
agent-pane.dictation/hide (Apple System Colors Light, chromium)
agent-pane.composer/working-stop (Apple System Colors Light, webkit)
agent-pane.transcript/shell-grouped-commands (Apple System Colors Light, chromium)
agent-pane.new-tab/dictation-show (Apple System Colors Light, chromium)
agent-pane.new-tab/dictation-show (Apple System Colors, chromium)
agent-pane.composer/queued-keyboard (Apple System Colors Light, webkit)

67 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

  • agent-pane.dictation/hide: /wt/op-next-model-chip-remote/?entry=agent-pane.dictation#/agent-pane.dictation/hide
  • agent-pane.composer/working-stop: /wt/op-next-model-chip-remote/?entry=agent-pane.composer#/agent-pane.composer/working-stop
  • agent-pane.transcript/shell-grouped-commands: /wt/op-next-model-chip-remote/?entry=agent-pane.transcript#/agent-pane.transcript/shell-grouped-commands
  • agent-pane.new-tab/dictation-show: /wt/op-next-model-chip-remote/?entry=agent-pane.new-tab#/agent-pane.new-tab/dictation-show
  • agent-pane.composer/queued-keyboard: /wt/op-next-model-chip-remote/?entry=agent-pane.composer#/agent-pane.composer/queued-keyboard
  • agent-pane.replay/playing: /wt/op-next-model-chip-remote/?entry=agent-pane.replay#/agent-pane.replay/playing
  • 39 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

  • agent-pane.dictation/hide (Apple System Colors Light, chromium): play: no element for menuitem "Hide Dictation Button"
  • agent-pane.composer/popup-surface (Apple System Colors, webkit): shared popup is missing glass material
  • agent-pane.composer-pickers/effort-press-drag-release (Apple System Colors Light, chromium): step 3 up text "High": layout shift 0.0001 (limit 0)
  • agent-pane.composer-pickers/effort-press-drag-release (Apple System Colors, chromium): step 3 up text "High": layout shift 0.0010 (limit 0)
  • agent-pane.composer-pickers/effort-press-drag-release (Apple System Colors, chromium): step 3 up text "High": layout shift 0.0001 (limit 0)
  • agent-pane.composer-pickers/model-press-drag-release (Apple System Colors, chromium): play: waitFor did not hold within 5000 ms
  • 81 more on the diff page

204 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

1299 unchanged · base 6b7ab55 · head 0e198e3

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

react-apps-check on 0e198e3: model-chip-fresh-chat passes (the base red this fixes). Two other reds, neither from this change:

@teamleaderleo
teamleaderleo merged commit 503ea8f into feat-cmux-next Oct 13, 2026
99 of 102 checks passed
@teamleaderleo
teamleaderleo deleted the op-next-model-chip-remote branch October 13, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant