Repository navigation
test: ignore NSTextView's own delegate reads during init on macOS 27 - #19189
Merged
teamleaderleo merged 2 commits intoOct 11, 2026
Merged
Conversation
On macOS 27, NSTextView's initializer reads its own `delegate` four times. The probes that check cmux never touches the unsafe-unretained NSTextView.delegate counted those AppKit reads, so four tests failed with "4 is not equal to 0" on the macOS 27 minis while passing on the macOS 15/26 runners. Reset each probe's counter after construction so only reads made by the code under test are counted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The tests exclude AppKit’s initialization reads while continuing to check reads made by the code under test. No merge-blocking risk was identified. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 3 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (24 passed)
-
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Cmux Cloud Persistent Session And Early Input PASS: The pull request changes only three test files and adds/reset delegate-read counters around NSTextView initialization. It does not change Cloud terminal creation, cmux-tui transport, manual rend… Cmux Swift Actor Isolation The pull request changes only three cmuxTestsfiles. It adds counter-reset helpers and calls them in tests. No production Swift code changes exist, so the custom check's actor-isolation failure cond…Cmux Swift Blocking Runtime PASS. The PR changes only three cmuxTests/*.swiftfiles. The additions only resetdelegateReadCountafterNSTextViewinitialization. They add no semaphore, blocking wait, sleep, delayed dispatch…Cmux Browser Automation Off-Main The pull request changes only three test files. The diff adds NSTextView delegate-read counter reset helpers and test setup calls. It does not change browser socket commands, processV2Command, `sock…Cmux Expensive Synchronous Load The pull request changes only three cmuxTestsfiles. The diff adds delegate-read counter reset helpers and test setup calls; it adds no production Swift code and no synchronous agent-history load or…Cmux Cache Substitution Correctness The pull request changes only three cmuxTestsSwift files. The diff adds test-only delegate counter reset methods and calls; it does not change production Swift, TypeScript, or JavaScript, and it do…Cmux No Hacky Sleeps PASS. The pull request changes only Swift test files. It adds delegate-read counter resets and does not add sleeps, timers, polling, delayed dispatch, or wall-clock synchronization. The rule covers no… Cmux Algorithmic Complexity PASS. The diff changes only cmuxTests/BrowserConfigTests.swift,cmuxTests/ShortcutAndCommandPaletteTests.swift, andcmuxTests/TerminalAndGhosttyTests.swift. It adds counter-reset methods and cal…Cmux Swift Concurrency The PR changes only XCTest probe helpers and calls that reset NSTextView.delegateread counters after initialization. The authoritative diff adds no Dispatch queues, Combine state, completion-handle…Cmux Swift @ConcurrentThe diff only adds synchronous resetDelegateReadCount()helpers and synchronous test call sites in three test files. It adds noasync,nonisolated,@concurrent, or async helper call-site chang…Cmux Swift Package Boundaries The diff changes only three files under cmuxTests/. It adds counter-reset methods to test-onlyNSTextViewprobes and calls them after initialization. No production Swift feature logic, app-target …Cmux Swiftpm Lockfiles The pull request changes only three Swift test files. The diff adds delegate-read counter reset helpers and test calls. It changes no Package.swift, Package.resolved, Xcode project package references,… Cmux Swift Logging The diff changes only three files under cmuxTests/. It adds delegate-counter reset methods and calls. It adds noprint,debugPrint,dump,NSLog, file logging,Logger, or sensitive-data log…Cmux User-Facing Error Privacy PASS. The pull request changes only three cmuxTestsfiles. The additions reset delegate-read counters in test probes and add developer-only comments. No production user-facing errors, alerts, comman…Cmux Full Internationalization The pull request changes only three Swift test files. The diff adds delegate-counter reset methods, comments, and test setup calls. It adds no production user-facing text, localization API usage, stri… Cmux Swiftui State Layout PASS: The pull request changes only three XCTest files. The diff adds delegate-read counter reset methods and test calls on NSTextView probe subclasses. It introduces no SwiftUI code, ObservableObject… Cmux Architecture Rethink PASS. The diff changes only three test files and adds reset methods plus calls that clear existing probe counters after NSTextView initialization. It introduces no sleeps, delayed dispatch, polling, l… Cmux Swift Auxiliary Window Close Shortcuts The diff changes only three files under cmuxTests/. It adds delegate-read counter reset methods and calls them in test cases. It does not add or materially change any user-visibleNSWindow, `NSPan…Cmux Source Artifacts All three changed paths are hand-written Swift test sources: cmuxTests/BrowserConfigTests.swift,cmuxTests/ShortcutAndCommandPaletteTests.swift, andcmuxTests/TerminalAndGhosttyTests.swift. The …Cmux No Test Or Debug Seam In Production Source The pull request changes only three files under cmuxTests/. The diff addsresetDelegateReadCount()methods and calls in test probe classes. No Swift file under a productionSources/path changes…Title check The title clearly and concisely describes the test-only change that excludes NSTextView initializer delegate reads on macOS 27. Description check The description clearly explains the failure, root cause, implementation, affected tests, and validation results. It includes Summary, Changelog, and detailed testing information, although it omits th…
-
✨ Finishing Touches 💡 2
-
-
-
-
📝 Generate docstrings 💡
-
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
-
🧪 Generate unit tests (beta)
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
-
🛠️ Fix failing CI checks 💡
-
-
- Commit to this branch
- Create a new PR
-
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
teamleaderleo
deleted the
fix/macos27-textview-delegate-probe-baseline
branch
October 11, 2026 04:32
Contributor
|
Merge receipt for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four app-host tests fail on every macOS 27.0.1 mini and pass on the macOS 15/26 Blacksmith runners:
CmuxWebViewKeyEquivalentTests/testWindowFirstResponderGuardAvoidsTextViewDelegateLookupForWebViewResolutionCmuxWebViewKeyEquivalentTests/testWindowFirstResponderGuardResolvesTrackedWebViewForFieldEditorResponderCommandPaletteFocusStealerClassificationTests/testDoesNotReadTextViewDelegateForFocusStealerClassificationGhosttyResponderResolutionTests/testDoesNotReadTextViewDelegateForGhosttyResponderResolutionAll four fail with
XCTAssertEqual failed: ("4") is not equal to ("0"). The Ghostty and command-palette tests only construct the probe text view and call one cmux helper, so the four reads come from NSTextView's own initializer on macOS 27, not from cmux. That is AppKit reading its own property, which the unsafe-unretained rule does not cover.Each probe now resets its counter right after construction, so it counts only reads made by the code under test. No product code changes.
Evidence
Recent
ci.ymlruns (since 2026-10-10 20:14Z): each test failed 0/4 on the 27 minis and passed 10/10 (CmuxWebView) and 5-6/6 (others) on blacksmith macos-26, plus 2/2 on blacksmith macos-15.Changelog
none
Test plan
ci.ymlruns, and passed on these same minis on 2026-10-07 before the upgrade (run 37700242931).RemoteTmuxMirrorSplitRoutingTests.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes four app-host tests that failed on macOS 27 because NSTextView's initializer reads its own
delegatefour times, which the test probes counted as cmux reads.resetDelegateReadCount()to eachNSTextViewprobe, called right after construction so only reads made by the code under test are counted.Written for commit e73693d. Summary will update on new commits.
Note
Low Risk
Test-only changes to counter reset timing; no app behavior or security-sensitive paths modified.
Overview
Fixes four app-host tests that fail on macOS 27 because
NSTextView’s initializer readsdelegateduring construction, so probe subclasses were reporting 4 reads before any cmux code ran.Adds
resetDelegateReadCount()on the delegate-tracking probeNSTextViewtypes inBrowserConfigTests,ShortcutAndCommandPaletteTests, andTerminalAndGhosttyTests, and calls it immediately after creating each probe so assertions still enforce zero delegate reads from first-responder / focus-stealer / Ghostty resolution paths. No production code changes.Reviewed by Cursor Bugbot for commit 5426df7. Bugbot is set up for automated code reviews on this repo. Configure here.