Skip to content

fix(webviews): mark the catalog refresh error as developer text - #18343

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/webviews-catalog-refresh-l10n
Oct 7, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/webviews-catalog-refresh-l10n

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

react-apps-check on feat-cmux-next fails test/pane-english.test.ts on App.tsx:771 "models.catalog refresh failed". #18277 (7fac2bf) added that string as the message of an error thrown after a failed model catalog refresh. The picker shows refreshStatus, never that message, so this PR marks the line l10n-allow with the reason, as the test's header asks.

The same job's later bun run test step was killed with exit 137 (SIGKILL) on the #18337 run. That kill is the runner, not this string.

Testing

  • bun test test/pane-english.test.ts: fails on base, passes here.
  • vp check on the file passes.
  • build-agent-pane-web.sh --check: the committed pane bundle is unchanged, since minification strips comments.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Marks the model catalog refresh error message as developer-only text so test/pane-english.test.ts no longer fails on feat-cmux-next.

  • The picker already displays refreshStatus on errors, never the thrown message.
  • No bundle changes are needed since minification strips comments.

Written for commit 6ccc391. Summary will update on new commits.

Review in cubic Turn on auto-fix


Note

Low Risk
Comment-only change for localization tooling; no runtime behavior change.

Overview
Adds an l10n-allow comment on the throw new Error("models.catalog refresh failed") path in DefaultComposerChips’ catalog refresh handler so pane-english stops flagging that string as user-facing copy.

The comment documents that the message is for developers/callers only—the model picker surfaces refreshStatus, not this error text.

Reviewed by Cursor Bugbot for commit 6ccc391. Bugbot is set up for automated code reviews on this repo. Configure here.

#18277 (7fac2bf) throws "models.catalog refresh failed" after a failed
model catalog refresh. The picker shows refreshStatus, never that message,
but webviews/test/pane-english.test.ts reads it as user-visible English and
fails react-apps-check on feat-cmux-next. This marks it l10n-allow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c5c7be2c-a5a5-41e0-9b62-02e707455a44

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit 689c694 into feat-cmux-next Oct 7, 2026
38 of 40 checks passed
@teamleaderleo
teamleaderleo deleted the fix/webviews-catalog-refresh-l10n branch October 7, 2026 10:18
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Check webviews (Oxlint, Oxfmt, type check). This PR merged before its CI finished: fix forward on main.

CI failed on 6ccc391106 (run 37606462044 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Check webviews (Oxlint, Oxfmt, type check)

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Gallery

No state changed

Diff page and renders (the run's gallery-pr artifact)

84 unchanged · base 187560c · head 6ccc391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant