Repository navigation
fix(webviews): mark the catalog refresh error as developer text - #18343
Conversation
#18277 (7fac2bf) throws "models.catalog refresh failed" after a failed model catalog refresh. The picker shows refreshStatus, never that message, but webviews/test/pane-english.test.ts reads it as user-visible English and fails react-apps-check on feat-cmux-next. This marks it l10n-allow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Unclear: CI failed on
Not re-run automatically: Written by |
GalleryNo state changed Diff page and renders (the run's |
Summary
react-apps-check on feat-cmux-next fails
test/pane-english.test.tsonApp.tsx:771 "models.catalog refresh failed". #18277 (7fac2bf) added that string as the message of an error thrown after a failed model catalog refresh. The picker showsrefreshStatus, never that message, so this PR marks the linel10n-allowwith the reason, as the test's header asks.The same job's later
bun run teststep was killed with exit 137 (SIGKILL) on the #18337 run. That kill is the runner, not this string.Testing
bun test test/pane-english.test.ts: fails on base, passes here.vp checkon the file passes.build-agent-pane-web.sh --check: the committed pane bundle is unchanged, since minification strips comments.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Marks the model catalog refresh error message as developer-only text so
test/pane-english.test.tsno longer fails onfeat-cmux-next.refreshStatuson errors, never the thrown message.Written for commit 6ccc391. Summary will update on new commits.
Note
Low Risk
Comment-only change for localization tooling; no runtime behavior change.
Overview
Adds an
l10n-allowcomment on thethrow new Error("models.catalog refresh failed")path inDefaultComposerChips’ catalog refresh handler sopane-englishstops flagging that string as user-facing copy.The comment documents that the message is for developers/callers only—the model picker surfaces
refreshStatus, not this error text.Reviewed by Cursor Bugbot for commit 6ccc391. Bugbot is set up for automated code reviews on this repo. Configure here.