Skip to content

style(webviews): format projectChooser.test.tsx - #18337

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/webviews-project-chooser-format
Oct 7, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/webviews-project-chooser-format

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

react-apps-check fails on feat-cmux-next at vp check with "Formatting issues found" in webviews/src/agent-session/acpmux/projectChooser.test.tsx. #18224 (daf0d36) left one expect() unformatted. It landed while the diff-viewer budget red (fixed by #18332) stopped that job before vp check ran.

This PR is vp fmt output only.

Testing

bunx vp check in webviews/: all 1071 files formatted, no lint or type errors.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes the react-apps-check formatting failure on feat-cmux-next by applying vp fmt output to projectChooser.test.tsx.

This is formatting-only: one expect() call in projectChooser.test.tsx is reformatted. No behavior changes.

Written for commit d3ee986. Summary will update on new commits.

Review in cubic Turn on auto-fix


Note

Low Risk
Test-only formatting with identical assertions; no runtime or production code affected.

Overview
Applies formatter output to one expect() in projectChooser.test.tsx: the branch-menu assertion is split across lines so the array argument and ["main", "true", "true"] match vp fmt / vp check style. No test logic or assertions change—only whitespace and line breaks.

Reviewed by Cursor Bugbot for commit d3ee986. Bugbot is set up for automated code reviews on this repo. Configure here.

#18224 (daf0d36) left one expect() unformatted, so react-apps-check's
`vp check` fails on feat-cmux-next with "Formatting issues found".
This is `vp fmt` output only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ae75c040-80e7-4621-b1da-867761398de0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit 1b8923a into feat-cmux-next Oct 7, 2026
39 of 40 checks passed
@teamleaderleo
teamleaderleo deleted the fix/webviews-project-chooser-format branch October 7, 2026 10:10
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews. This PR merged before its CI finished: fix forward on main.

CI failed on d3ee986ceb (run 37605531639 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant