Repository navigation
cmux-next: onboarding and Accounts show labels and actions only - #17588
Conversation
… CodeRouter is unreachable Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le CodeRouter is unreachable
Onboarding's Accounts and Import screens drop their subtitles ("Sign-ins
cmux found on this Mac...", "Each profile becomes a cmux profile. Nothing
leaves this Mac."). The "CodeRouter accounts are unavailable" line is
gone from onboarding and Settings > Accounts; Connect, which links to
CodeRouter, hides while CodeRouter cannot be reached. Settings > Accounts
also drops its "cmux checks this Mac for sign-ins..." intro. The page
bundle is regenerated (it also picks up #17539's Interface Scale string).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The banner sentence about CodeRouter (also Connect's tooltip) is gone; the page state carries only the button's title. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…' line Settings > Accounts hid nothing: Connect sat greyed out when signed out or for a provider not signed in locally, and unroutable providers said "CodeRouter does not route this provider yet." Connect now appears only when it can run, and the line is gone (the CLI still reports it when a connect is refused). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Batch queue: green. Batch stack Next: land it yourself with gh-merge-green on this receipt. |
…try glyphs (#17583) * test(cmux-next): chrome badges and placeholders draw registry glyphs at text size (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmux-next): chrome badges, placeholders and dismiss buttons draw registry glyphs The incognito badge, remote-terminal and elsewhere placeholders, notifications empty state and dismiss, restart notice dismiss and the bookmarks bar fallback drew stock SF Symbols at fixed or default sizes. They now draw the cmux icon registry's glyph for their meaning, sized to the text beside them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(cmux-next): a narrowed incognito badge shows its glyph, not a clipped word (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmux-next): a narrowed incognito badge shows its glyph, not a clipped word The titlebar row gives the badge only the room before the new button; the label clipped mid-word. The label now fades out whenever it does not fully fit, keeping the badge's fitting width for when room returns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmux-next): decide the incognito badge's word from its fitting width In the badge's layout pass the stack has not placed the label yet, so its frame was stale and the word stayed hidden at full width. Compare the badge's width with its fitting width instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test(cmux-next): reproduce palette provider teardown crash Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmux-next): make palette provider teardown executor independent Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
merge-override: Fast checks green with the new tests executed; only the heavy same-tree cmux-tui wait job is still running |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
merge-override: Fast checks green on 5ec5c29 with the new tests executed; only the heavy same-tree cmux-tui wait job is still running |
The base made onboarding show labels and actions only (#17588): the idle import step keeps the Find Browsers action and the short "Not looked for yet." list text, with no descriptive hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leo's labels-and-actions rule (2026-10-06), routed to this lane by the coordinator while the onboarding lanes are idle.
What changes
Onboarding, Accounts: the subtitle "Sign-ins cmux found on this Mac. Nothing is uploaded unless you choose Connect." is gone.
Onboarding, Import from Browsers: "Each profile becomes a cmux profile. Nothing leaves this Mac." is gone.
CodeRouter unreachable (onboarding and Settings > Accounts): no more "CodeRouter accounts are unavailable: …" line. Connect links an account into CodeRouter, so it now hides while CodeRouter can't be reached (
AccountRowState.canConnect, and the Settings row and page buttons). It comes back when CodeRouter loads again.Settings > Accounts: the intro "cmux checks this Mac for sign-ins and keys. …" is gone too (same screen, same rule). Refresh stays at the trailing edge.
Onboarding, Import: the note "macOS asks before cmux reads each browser's sign-ins." is gone (seen on the after build's capture).
Settings > Accounts rows: Connect appears only when it can run (signed in to cmux, CodeRouter reachable, a routable provider) instead of sitting greyed out. "CodeRouter does not route this provider yet." is gone from the rows; the CLI still returns it when a connect is refused.
The two gallery-only variants that reused the removed onboarding subtitles drop the line as well. Dead strings are removed from the catalogs.
The Settings page bundle is regenerated. It also picks up feat(cmux-next): add live app interface scale #17539's "Interface Scale" string, which was missing from the committed locales.
Settings > Accounts, signed out: one "Sign In to cmux" button at the top of Accounts, leading the Refresh row. The banner sentence "Sign in to cmux to connect accounts to CodeRouter, so cmux agents and Cloud machines can use them." is gone, and so is Connect's tooltip that repeated it. The page state carries only the button title (
signIn: String?).Tests
OnboardingNoProseTestsrenders the default Accounts and Import screens and checks that none of the removed sentences are shown.CredentialAndRowTests.connectHidesWhileCodeRouterIsUnreachable: Connect is unavailable afterlinkedFailedand returns afterlinkedLoaded.AccountsModelTests.signedOutIsOneSignInButton: the encoded signed-out page carries the button title and no CodeRouter sentence.AccountsModelTests.rowsOfferOnlyWhatCanRun: signed out, no row has Connect and none says "does not route".OnboardingNoProseTestsalso covers the Import sign-ins note.Red commits (tests only): a7a48b9, 5fcd66c, 47aae12, 2c15424. Green: 9a8080f, a9902bd, eec02eb, and the Connect/row fix.
Captures
Fleet DEV builds on a capture mini. "Before" for onboarding is feat-cmux-next 70fb440 (same mini session as #17553). The Settings "before" is this PR's intermediate build, which already had the intro and banner cut; it still showed greyed Connect buttons and "CodeRouter does not route this provider yet." "After" is this PR's head (onbprose-after3). The mini isn't signed in to cmux, so Settings shows the signed-out state.
Changelog
🤖 Generated with Claude Code