Repository navigation
ci: run backend migrations gate on every PR again (revert #17415) - #17432
Merged
Merged
Conversation
backend migrations applied is a required check on main. The paths filter from #17415 stops the workflow from running on PRs that don't touch backend/db, so the required check never reports and those PRs can't merge. The gate already passes at once when no migration changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe backend migrations workflow no longer filters pull request events by changed paths. Qualifying pull requests now trigger the workflow regardless of which files changed. ChangesBackend migration workflow
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The migration check is configured to run for matching pull requests and pass when there are no migrations. No actionable merge-blocking issue is established. 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
teamleaderleo
enabled auto-merge (squash)
October 5, 2026 20:02
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
Agents: |
Collaborator
Author
|
Merged. The main ruleset was temporarily without |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Oct 5, 2026
eed6000 ci: run backend migrations gate on every PR again (revert manaflow-ai#17415) (manaflow-ai#17432) dda24fb Show Cloud to everyone by default and bump 0.65.0 to build 108 (manaflow-ai#17436) # Conflicts: # .github/workflows/backend-migrations.yml
teamleaderleo
added a commit
that referenced
this pull request
Oct 5, 2026
…te tokens A workflow that produces a required check may not put paths or paths-ignore on its pull_request, pull_request_target or merge_group trigger (#17415 did that to backend-migrations.yml; #17432 reverted it). The required contexts come from scripts/ci/required_status_checks.py, which now mirrors the live `backend migrations applied` requirement. A workflow's top-level permissions may not grant a write scope (#17447, fixed in #17449). The 11 workflows that did now set `permissions: {}` and carry the same grants on each job, so no job's token changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 5, 2026
…te tokens (#17457) * ci: guard required checks against paths filters and workflow-wide write tokens A workflow that produces a required check may not put paths or paths-ignore on its pull_request, pull_request_target or merge_group trigger (#17415 did that to backend-migrations.yml; #17432 reverted it). The required contexts come from scripts/ci/required_status_checks.py, which now mirrors the live `backend migrations applied` requirement. A workflow's top-level permissions may not grant a write scope (#17447, fixed in #17449). The 11 workflows that did now set `permissions: {}` and carry the same grants on each job, so no job's token changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: match the required-check mirror to the ruleset and bound backend migrations Web complexity, ci-status and web-validation left the main ruleset on purpose, so drop them from REQUIRED_CHECKS; the drift reconciliation now passes against the live API. The timeout guard reads that list instead of keeping its own copy, which puts backend-migrations.yml under it, so its four jobs get timeout-minutes (plan 10, apply jobs 30, gate 15). The merge-queue fixtures keep requiring Web complexity to exercise its dynamic-name routing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: keep ci-status, web-validation and Web complexity under the timeout guard The timeout guard now checks the required checks plus an explicit ALWAYS_BOUNDED list of the contexts it covered before, so dropping them from the ruleset does not drop ci.yml and the web workflows from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend migrations appliedis a required check on main. #17415 added a paths filter tobackend-migrations.yml, so the workflow no longer runs on PRs that don't touchbackend/db, the required check never reports, and those PRs can't merge (for example #17419). The gate already passes at once when no migration changed, so running it on every PR costs one quick job.This PR reverts only the paths filter. It doesn't touch backend files, so under the current base workflow its own required check won't report either and it needs an admin merge once.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Reverts the
pathsfilter added in #17415 so the backend migrations gate runs on every PR again.The filter stopped the workflow from running on PRs that don't touch
backend/db, so the requiredbackend migrations appliedcheck never reported and those PRs couldn't merge. Since the gate already passes immediately when no migration changed, running it on every PR adds only one quick job.Note: this PR doesn't touch backend files, so under the current base workflow its own required check won't report and it needs an admin merge.
Written for commit 32490c5. Summary will update on new commits.
Summary by CodeRabbit
mainorfeat-cmux-next, even when no migration files change.