Skip to content

fix(cloud): refresh stale WireGuard enrollment during hub recovery - #16669

Merged
austinywang merged 101 commits into
mainfrom
issue-16665-cloud-activation-hub
Oct 3, 2026
Merged

austinywang merged 101 commits into
mainfrom
issue-16665-cloud-activation-hub

Conversation

@austinywang

@austinywang austinywang commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Cloud activation now recovers a stale terminal WireGuard enrollment without interrupting a hub that already belongs to the current authenticated account and team. Activation state, team-scope fencing, Settings refresh, and Cloud Machines onboarding remain coordinated across entry points.

Testing

  • python3 scripts/localization_catalog.py check (10 catalogs, 9 locales, 0 parity errors)
  • python3 scripts/verify-local.py --only swift-syntax --swift-changed (passed, 9 files)
  • python3 scripts/wire-app-sources.py --check (passed)
  • python3 scripts/sync_test_wiring.py --check (passed, 1,210 test files)
  • PYTHONPATH=tests python3 -m unittest tests/test_app_host_test_rerun.py (52 passed)
  • Native Xcode app tests were not run locally; CI remains the native compilation and app-test gate.

Changelog

  • Fixed Cloud activation and terminal WireGuard recovery when persisted enrollment is stale.

Demo Video

Not recorded. This review round changes recovery, onboarding state, localization coverage, and test seams; CI provides the native validation.

Checklist

  • Addressed review comments on scope-aware WireGuard prewarming.
  • Removed duplicated VM list decoding entry point.
  • Added complete Cloud activation and Settings localization coverage.
  • Sanitized user-facing Cloud error copy.
  • Updated focused tests and CI assertion coverage.
  • Native Xcode app tests run in CI.

— unregistered

Summary by CodeRabbit

  • New Features

    • Added a guided Cloud Machines setup flow in the Cloud tab, with progress, cancellation, retry, sign-in, and upgrade options.
    • Added activation controls and status guidance in Settings, including plan and VPN setup guidance.
    • Added clearer team-switching progress, a menu for copying Cloud error details, Cloud Workspace in the command palette, and new Cloud pricing information.
  • Updates

    • Cloud activation is no longer controlled through Beta Features. The Cloud tab and Settings section remain discoverable when Cloud is available; managed device policies can still restrict access.
    • When Cloud is available but not activated, Machines and VPN actions guide you to enable it first. Setup completes activation after readiness is confirmed.

Graduate Cloud Machines from the Beta Features presentation while retaining the existing activation marker and readiness side effects. The Cloud tab now owns first-use setup with shared retry and cancellation state.\n\nCloses #15759
…reen

# Conflicts:
#	Resources/Localizable.xcstrings
…-cloud-enable-screen

# Conflicts:
#	Resources/Localizable.xcstrings
…-cloud-enable-screen

# Conflicts:
#	Packages/macOS/CmuxCloud/Sources/CmuxCloud/VMClient/VMClient.swift
#	cmux.xcodeproj/project.pbxproj
…-cloud-enable-screen

# Conflicts:
#	cmux.xcodeproj/project.pbxproj
@blacksmith-sh

This comment has been minimized.

@cursor

cursor Bot commented Oct 2, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@cursor

cursor Bot commented Oct 2, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Merge-main commit by scripts/merge-main.sh.
Merged by scripts/merge-main.sh: origin/main at a03f6b9.

Resolved conflicts:
- Resources/Localizable.xcstrings: xcstrings key-level union
- cmux.xcodeproj/project.pbxproj: union of added entries, then normalize-pbxproj.py

Merge-main-previous-head: ed8017b
Merge-main-base: a03f6b9
@austinywang
austinywang merged commit 916dc50 into main Oct 3, 2026
86 checks passed
@austinywang
austinywang deleted the issue-16665-cloud-activation-hub branch October 3, 2026 00:16
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 78932cbf9f: every check was green at merge (34 verified; 23 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 3, 2026
ef96c2e Fix cloud VNC pane drop preview flicker (manaflow-ai#16681)
916dc50 fix(cloud): refresh stale WireGuard enrollment during hub recovery (manaflow-ai#16669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant