test(cloud): re-enable the Cloud header width tests by measuring each row

[teamleaderleo]

Summary

• Two tests in CloudMachinesHeaderCountTests were disabled. They hosted CloudTeamPickerHeader in a bare NSHostingView and searched SwiftUI's accessibility tree, which an in-process test without an assistive client does not reliably publish. They found nothing, not even the button identifiers.
• The header's ViewThatFits now builds both candidate rows through one internal actionsRow(_:picker:), with a CloudHeaderMachineActions value (.inline or .overflowMenu). This also removes the duplicated row code. Product behaviour does not change: it is the same two rows, in the same order, with the same modifiers and identifiers.
• The re-enabled tests skip the accessibility tree. They measure each candidate's ideal width and compare it with the bar's content width (sidebar width minus the bar's horizontal padding). That is the comparison ViewThatFits makes:
  • Narrow: with the long team name, the inline row is too wide for 220 pt, so the header falls back to the overflow menu.
  • Wide: with a short team name, the inline row fits 420 pt, and the overflow row is never wider than the inline row.
• The wide test now uses a short team name. The old version used the long fixture name, which by estimate does not fit 420 pt next to Invite and the buttons, so that test would likely have failed even with working hosting.

Testing

CI; app-host changed suites. No local build: swiftc -parse passes on both files, and python3 scripts/verify-local.py passed 17/17 (it does not compile natively or run app tests).

Resource check: test-only measurement plus a behaviour-neutral view refactor. It adds no loops, caches, logs or long-lived resources.

Changelog: none

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Re-enables the two Cloud header width tests by measuring each ViewThatFits candidate's ideal width instead of reading SwiftUI's accessibility tree, which a bare NSHostingView does not publish in-process.

The header now builds both candidate rows through one internal actionsRow(_:picker:) with a CloudHeaderMachineActions value (.inline or .overflowMenu), which also removes the duplicated row code. Product behavior is unchanged. The tests compare each row's ideal width against the bar's content width — the same comparison ViewThatFits makes — and the wide case now uses a short team name, since the old long fixture name does not fit 420 pt.

^{Written for commit edf547d. Summary will update on new commits.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e528aef9-a93c-4034-b9dc-facb93371b3a

📥 Commits

Reviewing files that changed from the base of the PR and between 6090053 and edf547d.

📒 Files selected for processing (2)

• Sources/Cloud/CloudTeamPickerHeader.swift
• cmuxTests/CloudMachinesHeaderCountTests.swift

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[teamleaderleo]

Subagent review at edf547d: approve.

• The actionsRow(.inline|.overflowMenu) refactor is behaviour-neutral: each arm matches the old row's views, modifiers, identifiers, Invite popover binding and confirmedTeamID gate, and ViewThatFits keeps the same two candidates in the same order.
• The tests compare fittingSize of row.fixedSize() against width − 16pt, which matches the chrome bar's 8+8 padding.
• Non-blocking: reordering the ViewThatFits candidates would still pass.
• No new strings.

Resource check: one-time layout code with no new loops, caches or logs, so no CPU, memory or disk impact.

[github-actions]

Dogfood tours of edf547da

cloud-machine-author-tour at edf547da: not run

skipped: CI built this head on a runner pool whose products the UI test Macs cannot load, and media never compiles one; gh workflow run pr-media.yml -f pr=<n> -f allow_compile=true does

_{Tours are picked by the paths globs in dogfood/scenarios/*.json; a Dogfood-tours: a, b line in the description picks them instead (none turns this off). Look at every frame before merging: a green tour only means no step failed.}

[github-actions]

Merge receipt for edf547da0c: every check was green at merge (14 verified; 18 skipped by policy). Full suite runs on main after merge.