fix: make browser import hint cover all supported browsers

[BlueRaddish]

Summary

The Settings browser import hint named six browsers although the import descriptor table supports 23. It now asks users to choose a browser, so the hint stays accurate when browser support changes. Updated the existing localization key in all nine macOS locales.

Fixes #15688.

Testing

• python scripts/localization_catalog.py check: 10 catalogs, 9 locales, 0 parity errors.
• python tests/test_localization_catalog.py: 23 passed.
• python tests/test_lint_xcstrings.py: 4 passed.
• python tests/test_localizable_xcstrings_structure.py: 3 passed.
• python scripts/verify-local.py: 4 selected checks passed; Swift syntax unsupported because no Swift toolchain is installed on Windows.
• python scripts/localize_changes.py: catalog parity passed, but it flagged a pre-existing interpolated string elsewhere in BrowserSection.swift for manual review. The changed key and all nine locale values were checked manually.
• python tests/test_localize_changes.py: 30 ran, 3 failures and 3 errors from Windows path, encoding, and symlink behavior; this suite is not green locally.
• git diff --check passed. macOS build and UI check remain unverified.

Changelog

Fixed: The browser import hint no longer limits its description to six browsers.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Fixes #15688 by updating the browser import hint so it no longer lists six specific browsers. The new copy asks users to choose a browser, keeping the hint accurate as supported browser import options change. Updated the localization key in all nine macOS locales.

^{Written for commit c3e1ff3. Summary will update on new commits.}

Summary by CodeRabbit

• Documentation
  • Updated the browser import description to prompt users to choose a browser, while retaining details about importing bookmarks, history, and cookies and automatically removing duplicates.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0895ba5c-b6de-4106-a6ba-0ded486f8265

📥 Commits

Reviewing files that changed from the base of the PR and between c5f158d and c3e1ff3.

📒 Files selected for processing (2)

• Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/BrowserSection.swift
• Resources/Localizable.xcstrings

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 96934055-eb6b-4436-b71a-bda79525efa4

📥 Commits

Reviewing files that changed from the base of the PR and between 15cf1ed and c5f158d.

📒 Files selected for processing (2)

• Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/BrowserSection.swift
• Resources/Localizable.xcstrings

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The browser import hint now asks users to choose a browser instead of listing browser names. It retains the references to bookmarks, history, cookies, and automatic deduplication.

Changes

Browser import hint

Layer / File(s)	Summary
Update browser import hint Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/BrowserSection.swift, Resources/Localizable.xcstrings	The hint and its localized descriptions replace the named browser list with an instruction to choose a browser. References to imported data and automatic deduplication remain.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to c5f15

The updated hint clearly points to browser selection, and the localized descriptions preserve the import details. No material merge risk is evident.

🚥 Pre-merge checks | ✅ 24 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (24 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: updating the browser import hint to cover all supported browsers.
Description check	✅ Passed	The description includes the required Summary, Testing, and Changelog sections. It explains the user-visible change, records test results and known limitations, and states that all nine macOS locales …
Linked Issues check	✅ Passed	The PR addresses the active direct issue [#15688]. BrowserSection.swift replaces the stale six-browser list with a direction to choose a browser for import. This keeps the hint valid as the supporte…
Out of Scope Changes check	✅ Passed	The changes are limited to the browser import hint in BrowserSection.swift and its nine localized values in Resources/Localizable.xcstrings. These changes directly implement [#15688]. The reported…
Cmux Cloud Persistent Session And Early Input	✅ Passed	PASS: The pull request changes only browser import hint text in BrowserSection.swift and Resources/Localizable.xcstrings. It does not change Cloud terminal creation, cmux-tui transport, PTY or she…
Cmux Swift Actor Isolation	✅ Passed	PASS. The Swift diff changes only the localized subtitle string in BrowserSection. BrowserSection is an allowed SwiftUI view type and remains explicitly @MainActor; the change adds no models, pr…
Cmux Swift Blocking Runtime	✅ Passed	PASS: The Swift diff changes only the browser-import subtitle string. It adds no semaphore, blocking wait, sleep, delayed dispatch, polling, main-queue sync, or manual lock. The other changed file con…
Cmux Browser Automation Off-Main	✅ Passed	The pull request changes only the browser import hint text in BrowserSection.swift and its localized strings in Resources/Localizable.xcstrings. It does not change `Sources/TerminalController.swif…
Cmux Expensive Synchronous Load	✅ Passed	PASS — The pull request changes only the BrowserSection hint text and nine localized string values. The diff adds no agent-history, transcript, JSON/JSONL, directory-scan, or synchronous loading call,…
Cmux Cache Substitution Correctness	✅ Passed	PASS: The diff changes only the browser-import hint text in BrowserSection.swift and its nine localized values. The changed Swift expression is a transient Text(String(localized: ...)) UI hint; it…
Cmux No Hacky Sleeps	✅ Passed	PASS: The pull request changes only Swift UI text and localization values in BrowserSection.swift and Resources/Localizable.xcstrings. It adds no TypeScript, JavaScript, shell, or build/runtime ch…
Cmux Algorithmic Complexity	✅ Passed	PASS. The pull request changes only localized browser-import text in BrowserSection.swift and Resources/Localizable.xcstrings. It adds no loops, collection scans, sorting, filtering, joins, or run…
Cmux Swift Concurrency	✅ Passed	The pull request changes one Swift string literal in BrowserSection.swift and updates its nine localized values. The added Swift line contains no Dispatch, Combine, Task, completion-handler, async, or…
Cmux Swift @Concurrent	✅ Passed	PASS: The Swift diff changes only the default localized subtitle string in importBrowserDataBlock; it adds no async, nonisolated, or @concurrent code and does not change isolation or call site…
Cmux Swift Package Boundaries	✅ Passed	PASS: The Swift diff changes only the localized subtitle string in the existing SwiftUI BrowserSection view. It adds no independently testable domain logic, reusable API, provider, persistence, or a…
Cmux Swiftpm Lockfiles	✅ Passed	PASS: The PR changes only BrowserSection.swift and localized strings. The diff contains no Package.swift, Package.resolved, .gitignore, workflow, or Xcode project package-reference changes. Th…
Cmux Swift Logging	✅ Passed	The pull request changes only browser-import UI and localization strings. The Swift diff replaces one subtitle string and adds no print, debugPrint, dump, NSLog, file/stdout logging, Logger declaratio…
Cmux User-Facing Error Privacy	✅ Passed	PASS. The changed text reaches the macOS Settings > Browser UI through BrowserSection.importBrowserDataBlock, but it is an informational import hint, not an error or recovery message. The new Englis…
Cmux Full Internationalization	✅ Passed	The changed user-facing Swift subtitle remains routed through String(localized:defaultValue:) with key browser.import.hint.subtitle. The matching Resources/Localizable.xcstrings entry was update…
Cmux Swiftui State Layout	✅ Passed	PASS. The PR changes only the browser import subtitle string in BrowserSection.swift and its nine localized values. The diff adds no ObservableObject, @Published, GeometryReader, lazy/list row…
Cmux Architecture Rethink	✅ Passed	PASS: The PR makes a small copy correction. It changes one Swift localization fallback and the matching nine localized values. It introduces no sleeps, delayed dispatch, polling, locks, observers, sid…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	The Swift diff changes only the default localized browser-import subtitle. It does not add or materially change an NSWindow, NSPanel, NSWindowController, SwiftUI Window, or WindowGroup. It adds no win…
Cmux Source Artifacts	✅ Passed	The PR changes only the intentional Swift source file Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/BrowserSection.swift and the localization catalog `Resources/Localizable.xcstrings…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS: The only Swift production change is a localized subtitle string in BrowserSection.swift. It adds no #if DEBUG block, test/debug member, visibility widening, or wrapper accessor. The other ch…

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

No issues found across 2 files

_{Re-trigger cubic}

[teamleaderleo]

Taking this: verifying the generic browser-import hint and all nine translations, updating against main, and checking review and CI. Thanks @BlueRaddish for keeping the hint in step with the browser picker.

OrchardSpoon g1 🌀
Run: run_cx_bl_outside_prs_20261002_0004
Session: cx-bl-outside-prs

[teamleaderleo]

Thanks @BlueRaddish. Updated with main at c3e1ff3 and completed independent review with no remaining finding. The changed hint and catalog entries were audited across all nine supported locales. A verified tagged Debug build passed, and its Browser settings window shows the generic import hint without clipping; a 16-second capture confirms the rendered text. All bot threads are resolved.

OrchardSpoon g1 🌀
run: run_cx_bl_outside_prs_20261002_0004
session: cx-bl-outside-prs

[github-actions]

Merge receipt for c3e1ff3dec: every check was green at merge (19 verified; 21 skipped by policy). Full suite runs on main after merge.