Repository navigation
Unblock release verification build #16414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
0d2b732
0d7239b
56837e5
ef7f5f8
6e9a537
2bac0fa
db6e391
337f0b5
8f5550c
8374a1b
0510b7c
806cb15
0beabb7
36651d9
f58f193
b4e2672
6459994
7428e6f
4beac05
097bf9a
6c131b2
c4bf7b1
fee0ee0
9737bc7
f439359
259d531
6910617
ef2c886
06b298a
a5ce445
fa9b5fd
278d636
58c1700
9de35d6
1b61c17
2dbbcd5
6f7170f
1bac05f
86a6aea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -92,7 +92,7 @@ public struct CustomSidebarTemplateCatalog: Sendable { | |||||||||||
| } | ||||||||||||
| let installedSource = source | ||||||||||||
| .split(separator: "\n", omittingEmptySubsequences: false) | ||||||||||||
| .filter { !$0.trimmingCharacters(in: .whitespaces).hasPrefix("// cp Examples/CustomSidebars/") } | ||||||||||||
| .filter { !$0.contains("cp Examples/CustomSidebars/") } | ||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This filter's only job is to strip copy-command lines from installed template source, but the tests never assert that behavior. Prompt for AI agentsThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The broadened Prompt for AI agents
Suggested change
|
||||||||||||
| .joined(separator: "\n") | ||||||||||||
| return CustomSidebarTemplate(descriptor: descriptor, source: installedSource) | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,13 +10,14 @@ public extension Notification.Name { | |
|
|
||
| /// Holds a gallery request until the progressively mounted Custom Sidebars | ||
| /// section is ready to present it. | ||
| // lint:allow namespace-type - one-shot main-actor handoff from a host menu to the lazily mounted Custom Sidebars section. | ||
| @MainActor | ||
| public enum CustomSidebarTemplateGalleryRequest { | ||
| private static var pending = false | ||
|
|
||
| public static func request() { | ||
| pending = true | ||
| NotificationCenter.default.post(name: .customSidebarTemplateGalleryRequested) | ||
| NotificationCenter.default.post(name: .customSidebarTemplateGalleryRequested, object: nil) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The explicit Prompt for AI agents |
||
| } | ||
|
|
||
| public static func consume() -> Bool { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -110,3 +110,9 @@ if [ -n "${GITHUB_ENV:-}" ]; then | |
| echo "CMUX_CI_RUNTIME_SOURCE_ROOT=$CMUX_CI_RUNTIME_SOURCE_ROOT" >> "$GITHUB_ENV" | ||
| fi | ||
| scripts/ci/canonical-build-root.sh --runtime-source "$PWD" | ||
| # `#filePath` literals keep the producer's canonical path even though the | ||
| # compiler's prefix map makes the rest of the test metadata portable. Keep a | ||
| # second alias at that exact path for tests that still open repository files | ||
| # directly (for example bundled CLI scripts). | ||
| CMUX_CI_RUNTIME_SOURCE_ROOT="${CMUX_CI_CANONICAL_ROOT:-/private/tmp/cmux-ci}" \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This second invocation makes Prompt for AI agents |
||
| scripts/ci/canonical-build-root.sh --runtime-source "$PWD" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
CMUX_CI_CANONICAL_ROOTis not available in this step's shell: it was only written to$GITHUB_ENVearlier in the same step (line 217), and GITHUB_ENV entries are applied to subsequent steps, not the current running step. So${CMUX_CI_CANONICAL_ROOT:-/private/tmp/cmux-ci}always expands to/private/tmp/cmux-ci. When the producer compiled on an owned Mac's second compile slot,take-product-canonical-root.shsetroot=/private/tmp/cmux-ci-<n>, and this call then aliases the wrong root: the producer's embedded#filePath(/private/tmp/cmux-ci-<n>/src/...) still cannot resolve, so the fix silently does nothing in that case. Worse,canonical-build-root.sh --runtime-sourcerunsrm -rf "$runtime_src"before symlinking, so it deletes/private/tmp/cmux-ci/src— a root this job did not take viatake-product-canonical-root.shand that another job on the same Mac may be compiling in. Use therootvariable already computed in this step instead.Prompt for AI agents