Unblock release verification build

.github/workflows/iroh-release-gate.yml

@@ -365,10 +365,10 @@ jobs:
           chmod 600 "$production_env"
 
       - name: Run Iroh gate
-        # Every non-soak phase is capped at 25 minutes. Stress soaks retain
-        # their one-hour workload window while the gate script bounds each
-        # setup, build, and launch phase separately.
-        timeout-minutes: ${{ inputs.soak_profile == 'stress' && 75 || 25 }}
+        # Relay-only stress is one hour of use plus the 30-minute credential
+        # rollover observation and bounded cleanup. The script's report
+        # timeout is 5,850 seconds, so this step must be longer than that.
+        timeout-minutes: ${{ inputs.soak_profile == 'stress' && 125 || 25 }}
         env:
           # The hosted runner does not have cmuxterm-hq's tagged-backend
           # helper. The explicit Worker origin remains the app's API and v2
@@ -379,6 +379,9 @@ jobs:
           # has no cmux-tui artifact yet, use the newest older artifact with
           # identical client inputs instead of failing before the app starts.
           CMUX_TUI_CLIENT_MAX_FALLBACK: 5
+          CMUX_CODEX_MODEL: gpt-5.3-codex-spark
+          CMUX_CODEX_DURATION_SECONDS: "3600"
+          CMUX_CODEX_STRICT_MODEL: "1"
         run: |
           set -euo pipefail
           case "${{ matrix.mode }}" in
@@ -408,11 +411,45 @@ jobs:
           if [[ "${{ matrix.mode }}" == automatic || "${{ matrix.mode }}" == relay-only ]]; then
             GATE_ARGS+=(--soak-profile "${{ inputs.soak_profile }}")
           fi
-          if [[ "${{ inputs.environment }}" == production && "${{ matrix.mode }}" == relay-only && "${{ inputs.soak_profile }}" == stress ]]; then
+          if [[ "${{ inputs.soak_profile }}" == stress && ( "${{ matrix.mode }}" == automatic || "${{ matrix.mode }}" == relay-only ) ]]; then
             GATE_ARGS+=(--real-usage)
           fi
           ./scripts/run-iroh-release-gate.sh "${GATE_ARGS[@]}"
 
+      - name: Verify canonical v2 Worker identity
+        if: ${{ always() }}
+        env:
+          EXPECTED_ENVIRONMENT: ${{ inputs.environment }}
+          EXPECTED_V2_URL: ${{ inputs.environment == 'production' && 'https://cmux-v2.debussy.workers.dev' || inputs.v2_base_url }}
+          HEALTH_OUTPUT: ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-worker-health.json
+        run: |
+          set -euo pipefail
+          curl --fail --silent --show-error --retry 3 --retry-connrefused \
+            --connect-timeout 10 --max-time 30 \
+            "$EXPECTED_V2_URL/v2/health" > "$HEALTH_OUTPUT"
+          EXPECTED_ENVIRONMENT="$EXPECTED_ENVIRONMENT" EXPECTED_V2_URL="$EXPECTED_V2_URL" HEALTH_OUTPUT="$HEALTH_OUTPUT" \
+            /usr/bin/python3 - <<'PY'
+          import json
+          import os
+          from urllib.parse import urlparse
+
+          with open(os.environ["HEALTH_OUTPUT"], encoding="utf-8") as handle:
+              health = json.load(handle)
+          expected_environment = os.environ["EXPECTED_ENVIRONMENT"]
+          expected_url = os.environ["EXPECTED_V2_URL"]
+          if health.get("schemaId") != "health.v1":
+              raise SystemExit("Worker health schema is not health.v1")
+          if health.get("environment") != expected_environment:
+              raise SystemExit("Worker health environment does not match the gate")
+          if not isinstance(health.get("sourceRevision"), str) or not health["sourceRevision"] or health["sourceRevision"] == "unknown":
+              raise SystemExit("Worker health did not identify its source revision")
+          if health.get("storage", {}).get("maxSchemaVersion", 0) < 7:
+              raise SystemExit("Worker storage schema is older than v2")
+          if urlparse(expected_url).hostname in {"cmux-iroh-v2.debussy.workers.dev", "cmux-iroh-v2-staging.debussy.workers.dev"}:
+              raise SystemExit("release gate used a compatibility alias instead of the canonical Worker")
+          print(json.dumps({"url": expected_url, "health": health}, sort_keys=True))
+          PY
+
       - name: Upload redacted verdict
         if: ${{ always() }}
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
@@ -426,6 +463,9 @@ jobs:
             ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-ios-*.jsonl
             ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-ios-*.log
             ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-mac-failure.cmuxdiag
+            ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-latency.state*
+            ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-latency.json
+            ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-worker-health.json
             ${{ runner.temp }}/iroh-release-gate-${{ matrix.mode }}-real-usage/**
           if-no-files-found: warn
           retention-days: 7

CLI/CMUXCLI+AgentHookAdmission.swift

@@ -565,7 +565,7 @@ extension CMUXCLI {
                     )
                 }
                 changed = true
-            case .unavailable, .pending, .healthy:
+            case .unavailable, .pending, .aborted, .healthy:
                 break
             }
         }

CLI/CodexTranscriptFailureReadResult.swift

@@ -1,6 +1,7 @@
 enum CodexTranscriptFailureReadResult {
     case unavailable
     case pending
+    case aborted
     case healthy(lastAssistantMessage: String?)
     case failure(CodexHookFailureCandidate)
 }

CLI/CodexTranscriptMonitorStopReplay.swift

@@ -6,18 +6,21 @@ struct CodexTranscriptMonitorStopReplay {
     let payload: String
     let workspaceId: String
     let surfaceId: String?
+    let suppressNotification: Bool
 
     init?(
         sessionId: String,
         turnId: String?,
         transcriptPath: String?,
         workspaceId: String,
         surfaceId: String?,
-        lastAssistantMessage: String?
+        lastAssistantMessage: String?,
+        suppressNotification: Bool = false
     ) {
         guard !sessionId.isEmpty, !workspaceId.isEmpty else { return nil }
         self.workspaceId = workspaceId
         self.surfaceId = surfaceId
+        self.suppressNotification = suppressNotification
 
         var object: [String: Any] = [
             "session_id": sessionId,

CLI/cmux.swift

@@ -30805,6 +30805,8 @@ struct CMUXCLI {
                 return summarizeCodexHookFailureCandidate(failure)
             case .healthy:
                 return nil
+            case .aborted:
+                return nil
             case .pending, .unavailable:
                 break
             }
@@ -30818,6 +30820,8 @@ struct CMUXCLI {
                 return summarizeCodexHookFailureCandidate(failure)
             case .healthy:
                 return nil
+            case .aborted:
+                return nil
             case .pending, .unavailable:
                 break
             }
@@ -30852,6 +30856,7 @@ struct CMUXCLI {
         var candidateCanPublishBeforeTerminal = false
         var sawAssistantMessage = false
         var sawTerminalTurn = false
+        var sawAbortedTurn = false
         var sawRelevantTurn = turnId == nil
         var lastAssistantMessage: String?
         for line in lines {
@@ -30885,6 +30890,7 @@ struct CMUXCLI {
                 sawRelevantTurn = true
                 candidate = nil
                 candidateCanPublishBeforeTerminal = false
+                sawAbortedTurn = false
             case "error":
                 let payloadTurnId = firstString(in: payload, keys: ["turn_id", "turnId"])
                 if let turnId, let payloadTurnId {
@@ -30930,6 +30936,7 @@ struct CMUXCLI {
                 // has no final response to classify as a failure, so let the
                 // normal Stop replay retire its stale prompt record.
                 if eventType == "turn_aborted" {
+                    sawAbortedTurn = true
                     continue
                 }
                 // Codex persists fatal turn failures inside task_complete.error. Standalone
@@ -30979,6 +30986,9 @@ struct CMUXCLI {
         if candidate != nil, turnId != nil, !sawRelevantTurn {
             return .pending
         }
+        if sawAbortedTurn, candidate == nil {
+            return .aborted
+        }
         if requireTerminalCompletion, !sawTerminalTurn {
             return .pending
         }
@@ -31848,6 +31858,16 @@ struct CMUXCLI {
                         surfaceId: surfaceId,
                         lastAssistantMessage: lastAssistantMessage
                     )
+                case .aborted:
+                    return CodexTranscriptMonitorStopReplay(
+                        sessionId: sessionId,
+                        turnId: turnId,
+                        transcriptPath: currentTranscriptPath,
+                        workspaceId: workspaceId,
+                        surfaceId: surfaceId,
+                        lastAssistantMessage: nil,
+                        suppressNotification: true
+                    )
                 case .pending:
                     break
                 case .unavailable:
@@ -37641,6 +37661,7 @@ export default {
                     turnID: effectiveCodexStopTurnID,
                     workspaceID: workspaceId,
                     surfaceID: surfaceId,
+                    claimNotification: monitorReplay?.suppressNotification != true,
                     // Tokenized Codex launches must not let a delayed Stop
                     // for an older turn settle the currently active turn.
                     // Legacy unwrapped launches retain their historical
@@ -37700,6 +37721,7 @@ export default {
                 }
             }
             let suppressCompletionNotification = suppressVisibleMutations
+                || monitorReplay?.suppressNotification == true
                 || codexHasActiveBackgroundWork
             let cursorStopApprovalNotificationKeys: [String] = {
                 guard def.name == "cursor", !sessionId.isEmpty else { return [] }

Packages/macOS/CmuxFoundation/Tests/CmuxFoundationTests/JumpToBottomAffordanceTests.swift

@@ -46,8 +46,10 @@ import Testing
             ownerChecks += 1
             return true
         }
-        #expect(!affordance.update(snapshot(below: 8), isEnabled: true, contentOwnsScrolling: ownsScrolling))
-        #expect(!affordance.update(snapshot(below: 9), isEnabled: true, contentOwnsScrolling: ownsScrolling))
+        let firstChanged = affordance.update(snapshot(below: 8), isEnabled: true, contentOwnsScrolling: ownsScrolling)
+        let secondChanged = affordance.update(snapshot(below: 9), isEnabled: true, contentOwnsScrolling: ownsScrolling)
+        #expect(!firstChanged)
+        #expect(!secondChanged)
         #expect(!affordance.isVisible)
         // The owner is asked once per departure from the bottom, not per snapshot.
         #expect(ownerChecks == 1)

Packages/macOS/CmuxRemoteSession/Tests/CmuxRemoteSessionTests/RemoteRelaySlotTeardownTests.swift

@@ -293,7 +293,7 @@ struct RemoteRelaySlotTeardownTests {
 
         let succeeded = await coordinator.stopAndWait(cleanupScope: .persistentSlot)
 
-        let cleanupCommand = try #require(runner.requests.last?.arguments.last)
+        let cleanupCommand = try command(in: runner) { $0.contains("serve --persistent-stop --slot") }
         #expect(succeeded)
         #expect(cleanupCommand.contains("serve --persistent-stop --slot"))
         #expect(cleanupCommand.contains("64010.shell"))
@@ -316,7 +316,7 @@ struct RemoteRelaySlotTeardownTests {
 
         let succeeded = await coordinator.stopAndWait(cleanupScope: .transport)
 
-        let cleanupCommand = try #require(runner.requests.last?.arguments.last)
+        let cleanupCommand = try command(in: runner) { $0.contains("64010.slot") }
         #expect(succeeded)
         #expect(!cleanupCommand.contains("serve --persistent-stop --slot"))
         #expect(!cleanupCommand.contains("rm -rf"))
@@ -335,7 +335,7 @@ struct RemoteRelaySlotTeardownTests {
 
         let succeeded = await coordinator.stopAndWait(cleanupScope: .persistentSlot)
 
-        let cleanupCommand = try #require(runner.requests.last?.arguments.last)
+        let cleanupCommand = try command(in: runner) { $0.contains("serve --persistent-stop --slot") }
         #expect(succeeded)
         #expect(cleanupCommand.contains("$HOME/.cmux/bin/cmuxd-remote"))
         #expect(cleanupCommand.contains("serve --persistent-stop --slot"))
@@ -355,9 +355,9 @@ struct RemoteRelaySlotTeardownTests {
 
         #expect(succeeded)
         #expect(runner.requests.count == 2)
-        let metadataCleanup = try #require(runner.requests.first?.arguments.last)
+        let metadataCleanup = try command(in: runner) { $0.contains("64010.slot") }
         #expect(metadataCleanup.contains("64010.slot"))
-        let directCleanup = try #require(runner.requests.last?.arguments.last)
+        let directCleanup = try command(in: runner) { $0.contains("$HOME/.cmux/bin/cmuxd-remote") }
         #expect(directCleanup.contains("$HOME/.cmux/bin/cmuxd-remote"))
         #expect(directCleanup.contains("serve --persistent-stop --slot"))
         #expect(!directCleanup.contains("relay_socket="))
@@ -410,6 +410,19 @@ struct RemoteRelaySlotTeardownTests {
         )
     }
 
+    private func command(
+        in runner: SpyProcessRunner,
+        matching predicate: (String) -> Bool
+    ) throws -> String {
+        let commands = runner.requests.compactMap(\.arguments.last)
+        guard let command = commands.first(where: { predicate($0) }) else {
+            throw MissingCleanupCommand()
+        }
+        return command
+    }
+
+    private struct MissingCleanupCommand: Error {}
+
     enum MalformedSlotCleanupScope: String, CaseIterable, Sendable {
         case persistentSlot
         case transport

Packages/macOS/CmuxSettings/Sources/CmuxSettings/Resources/CustomSidebarTemplates/agents-board.js

@@ -1,7 +1,7 @@
 // agents-board: subagents grouped by STATUS, attention first. The question
 // this layout answers is "what needs me right now" - needs-input sessions
 // get the loudest section at the top, everything else stays quiet.
-//   cmux sidebar set custom agents-board
+//   cmux left-sidebar set custom agents-board
 
 const STATUS_META = {
   needs_input: { label: "NEEDS YOU", color: "#FF9F0A", strong: true },

Packages/macOS/CmuxUpdaterUI/Package.swift

@@ -14,6 +14,7 @@ let package = Package(
         ),
     ],
     dependencies: [
+        .package(path: "../CmuxAppKitSupportUI"),
         .package(path: "../CmuxFoundation"),
         .package(path: "../CmuxUpdater"),
         .package(url: "https://github.com/sparkle-project/Sparkle", from: "2.9.0"),
@@ -23,6 +24,7 @@ let package = Package(
             name: "CmuxUpdaterUI",
             dependencies: [
                 "CmuxFoundation",
+                .product(name: "CmuxAppKitSupportUI", package: "CmuxAppKitSupportUI"),
                 "CmuxUpdater",
                 .product(name: "Sparkle", package: "Sparkle"),
             ],
@@ -34,7 +36,10 @@ let package = Package(
         ),
         .testTarget(
             name: "CmuxUpdaterUITests",
-            dependencies: ["CmuxUpdaterUI"],
+            dependencies: [
+                "CmuxUpdaterUI",
+                .product(name: "CmuxAppKitSupportUI", package: "CmuxAppKitSupportUI"),
+            ],
             swiftSettings: [
                 .swiftLanguageMode(.v6),
                 .enableUpcomingFeature("ExistentialAny"),

Packages/macOS/CmuxUpdaterUI/Sources/CmuxUpdaterUI/UpdateBadge.swift

@@ -1,12 +1,18 @@
 public import SwiftUI
+import CmuxAppKitSupportUI
 public import CmuxUpdater
+import AppKit
 
 /// A badge view that displays the current state of an update operation (icon, progress ring,
 /// or loading spinner) for the update pill.
 public struct UpdateBadge: View {
     private let model: UpdateStateModel
     private let appearance: UpdateAppearance
 
+    private static let iconSize: CGFloat = 14
+    private static let iconPointSize: CGFloat = 13
+    private static let iconWeight: NSFont.Weight = .semibold
+
     /// Creates a badge for `model`, using `appearance` for the loading-spinner tint.
     public init(model: UpdateStateModel, appearance: UpdateAppearance) {
         self.model = model
@@ -22,7 +28,7 @@ public struct UpdateBadge: View {
     private var badgeContent: some View {
         if model.showsDetectedBackgroundUpdate {
             if let iconName = model.iconName {
-                Image(systemName: iconName)
+                badgeImage(iconName)
             }
         } else {
             switch model.effectiveState {
@@ -31,7 +37,7 @@ public struct UpdateBadge: View {
                     let progress = min(1, max(0, Double(download.progress) / Double(expectedLength)))
                     ProgressRingView(progress: progress)
                 } else {
-                    Image(systemName: "arrow.down.circle")
+                    badgeImage("arrow.down.circle")
                 }
 
             case .extracting(let extracting):
@@ -42,11 +48,39 @@ public struct UpdateBadge: View {
 
             default:
                 if let iconName = model.iconName {
-                    Image(systemName: iconName)
+                    badgeImage(iconName)
                 }
             }
         }
     }
+
+    /// Builds the AppKit-owned request used by every updater symbol.
+    @MainActor
+    static func hostedIconRequest(
+        systemName: String,
+        tintColor: NSColor
+    ) -> CmuxResolvedIconRequest {
+        CmuxResolvedIconRequest(
+            source: .systemSymbol(name: systemName, accessibilityDescription: nil),
+            size: NSSize(width: iconSize, height: iconSize),
+            tintColor: tintColor,
+            symbolWeight: iconWeight,
+            fallbackSource: .systemSymbol(
+                name: systemName,
+                accessibilityDescription: nil
+            ),
+            symbolPointSize: iconPointSize
+        )
+    }
+
+    private func badgeImage(_ systemName: String) -> some View {
+        CmuxResolvedIconImage(request: Self.hostedIconRequest(
+            systemName: systemName,
+            tintColor: NSColor(appearance.foregroundColor(for: model))
+        ))
+        .frame(width: Self.iconSize, height: Self.iconSize)
+        .accessibilityHidden(true)
+    }
 }
 
 private struct ProgressRingView: View {