Skip to content

Pass the temporary-config flag to the Codex provider override parser #16243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lawrencecchen wants to merge 2 commits into from
Closed

Pass the temporary-config flag to the Codex provider override parser #16243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e329e2
Pass the temporary-config flag to the Codex provider override parser
lawrencecchen Sep 30, 2026
3f8bd14
test: match temporary Codex config argument scope
teamleaderleo Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CLI/CMUXCLI+AutoNaming.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,14 @@ struct CodexAutoNamingArguments: Sendable {
arguments.insert("--ignore-user-config", at: arguments.firstIndex(of: "--ignore-rules")!)
}
guard let configToml else { return arguments }
let overrides = providerOverrides(from: configToml)
let overrides = providerOverrides(from: configToml, usesTemporaryConfig: usesTemporaryConfig)
for override in overrides.reversed() {
arguments.insert(contentsOf: ["-c", override], at: 1)
}
return arguments
}

private static func providerOverrides(from toml: String) -> [String] {
private static func providerOverrides(from toml: String, usesTemporaryConfig: Bool) -> [String] {
var model: String?
var modelProvider: String?
var providerEntries: [(section: String, key: String, value: String)] = []
Expand Down
5 changes: 4 additions & 1 deletion cmuxCLITests/CodexAutoNamingArgumentsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ struct CodexAutoNamingArgumentsTests {
let overrides = configOverrides(args)
#expect(overrides.contains("model_provider=\"subrouter\""))
#expect(overrides.contains("model=\"gpt-5-codex\""))
#expect(overrides.contains("model_providers.subrouter.base_url=\"http://127.0.0.1:31415/v1\""))
// With a temporary CODEX_HOME, the provider definition is already
// available in its mode-restricted config.toml. Do not duplicate it
// on argv, where nested provider values could expose credentials.
#expect(!overrides.contains("model_providers.subrouter.base_url=\"http://127.0.0.1:31415/v1\""))
#expect(!overrides.contains(where: {
$0.contains("secret") || $0.contains("experimental_bearer_token") || $0.contains("api-secret")
}))
Expand Down
Loading