Pass the temporary-config flag to the Codex provider override parser

[lawrencecchen]

The CLI does not compile on main since #16201: CLI/CMUXCLI+AutoNaming.swift:271: cannot find 'usesTemporaryConfig' in scope. providerOverrides(from:) reads the flag, but the flag is a parameter of build(configToml:usesTemporaryConfig:). This passes it through, so provider entries stay out of argv when a temporary CODEX_HOME carries them, as #16201 intended.

Changelog

none

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Fixes the CLI build on main, which broke after #16201 because providerOverrides(from:) read usesTemporaryConfig without receiving it as a parameter.

• Passes usesTemporaryConfig into providerOverrides(from:usesTemporaryConfig:).
• Preserves Keep Codex auto-naming credentials out of argv #16201's intent: provider entries stay out of argv when a temporary CODEX_HOME carries them.
• Adds a test asserting provider entries aren't duplicated on argv, so nested provider values like credentials aren't exposed.

^{Written for commit 3f8bd14. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Auto-naming now honors temporary configuration: it uses the selected provider and model without applying that provider’s saved settings. When temporary configuration isn’t in use, the selected provider’s non-credential settings continue to apply. This keeps auto-naming behavior aligned with the active configuration.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 78a17eaa-e4fd-4987-a0ee-482dd942f0a6

📥 Commits

Reviewing files that changed from the base of the PR and between 3e329e2 and 3f8bd14.

📒 Files selected for processing (1)

• cmuxCLITests/CodexAutoNamingArgumentsTests.swift

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cd7d5fc3-68b0-40a0-a41e-35aedc601a2a

📥 Commits

Reviewing files that changed from the base of the PR and between 579a979 and 3e329e2.

📒 Files selected for processing (1)

• CLI/CMUXCLI+AutoNaming.swift

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

---

📝 Walkthrough

Walkthrough

Auto-naming now passes the temporary-config flag to provider override extraction. When temporary config is active, the overrides include the selected provider and optional model, but not provider-section settings.

Changes

Auto-Naming Provider Overrides

Layer / File(s)	Summary
Provider override extraction CLI/CMUXCLI+AutoNaming.swift	build passes usesTemporaryConfig to providerOverrides. The helper omits provider-section settings when temporary config is active and retains the existing behavior otherwise.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3e329

Temporary-config runs retain provider settings while applying provider and model overrides. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 23 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the compile failure and intended behavior, but it omits the required Summary and Testing sections, Demo Video section, and Checklist. It also does not report any tests execute…	Add the required Summary and Testing sections. State the tests or build commands that ran and their results. Include the Demo Video section or explain why it does not apply, complete the Checklist, and retain the Changelog entry.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (23 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: passing the temporary-config flag to the Codex provider override parser.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	PASS. The diff changes only CodexAutoNamingArguments in CLI/CMUXCLI+AutoNaming.swift: it passes usesTemporaryConfig to the Codex provider override parser. It does not change Cloud terminal creat…
Cmux Swift Actor Isolation	✅ Passed	PASS: The production diff only forwards the existing usesTemporaryConfig Bool from CodexAutoNamingArguments.build to providerOverrides. It does not add or change actor annotations, protocols, sh…
Cmux Swift Blocking Runtime	✅ Passed	The pull request changes only the usesTemporaryConfig argument passed to providerOverrides and the parser signature. It adds no semaphores, blocking waits, sleeps, delayed dispatch, polling, main-…
Cmux Browser Automation Off-Main	✅ Passed	PASS. The pull request changes only CLI/CMUXCLI+AutoNaming.swift, where it passes usesTemporaryConfig to Codex provider override parsing. The diff contains no browser.* commands, socket-worker r…
Cmux Expensive Synchronous Load	✅ Passed	The PR changes only CodexAutoNamingArguments.build and providerOverrides(from:usesTemporaryConfig:) in CLI/CMUXCLI+AutoNaming.swift. It passes a Boolean and conditionally skips provider-section …
Cmux Cache Substitution Correctness	✅ Passed	PASS: The diff only threads the existing usesTemporaryConfig boolean into providerOverrides. It does not replace an authoritative read with a cache, and the Codex auto-naming argument construction…
Cmux No Hacky Sleeps	✅ Passed	PASS: The PR changes only CLI/CMUXCLI+AutoNaming.swift, which is Swift. The diff only passes usesTemporaryConfig into providerOverrides; it introduces no sleep, timer, polling, delay, or wall-cl…
Cmux Algorithmic Complexity	✅ Passed	The PR changes only the providerOverrides call and adds a Boolean parameter. It does not add collection scans, sorting, filtering, joins, or batch processing. The existing linear TOML scan and provi…
Cmux Swift Concurrency	✅ Passed	The pull request changes only synchronous Codex configuration parsing. It passes usesTemporaryConfig from CodexAutoNamingArguments.build to providerOverrides; it adds no Dispatch, Combine, compl…
Cmux Swift @Concurrent	✅ Passed	PASS: The PR changes only the synchronous CodexAutoNamingArguments.build call and providerOverrides signature to pass usesTemporaryConfig. It adds no async, nonisolated, @concurrent, or ac…
Cmux Swift Package Boundaries	✅ Passed	The diff changes only CLI/CMUXCLI+AutoNaming.swift: it forwards the existing usesTemporaryConfig value and adds that parameter to the existing private parser. It does not introduce or materially e…
Cmux Swiftpm Lockfiles	✅ Passed	The pull request changes only CLI/CMUXCLI+AutoNaming.swift. It does not change a Package.swift dependency, a .gitignore, an Xcode package reference, or a SwiftPM lockfile. The SwiftPM lockfile p…
Cmux Swift Logging	✅ Passed	PASS: The pull request changes only the Codex provider override parameter and call. It adds no print, debugPrint, dump, NSLog, file logging, Logger declaration, or diagnostic output. The chang…
Cmux User-Facing Error Privacy	✅ Passed	PASS. The pull request changes only argument construction in CLI/CMUXCLI+AutoNaming.swift: it forwards usesTemporaryConfig to providerOverrides. The diff adds or changes no user-facing error, al…
Cmux Full Internationalization	✅ Passed	PASS. The PR changes only the providerOverrides call and parameter propagation in CLI/CMUXCLI+AutoNaming.swift. The change adds no user-facing text, localization keys, catalogs, web messages, meta…
Cmux Swiftui State Layout	✅ Passed	PASS. The pull request changes only CLI/CMUXCLI+AutoNaming.swift. The diff updates a CodexAutoNamingArguments parser call and its parameter. The file is a Foundation-based CLI value/parser file an…
Cmux Architecture Rethink	✅ Passed	PASS. The diff is a small local correctness fix. It passes the existing usesTemporaryConfig value from CodexAutoNamingArguments.build to providerOverrides, which resolves the pre-existing scope/…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	PASS: The PR changes only CLI/CMUXCLI+AutoNaming.swift, where CodexAutoNamingArguments.build passes usesTemporaryConfig to providerOverrides. The diff adds no NSWindow, NSPanel, `NSWindowC…
Cmux Source Artifacts	✅ Passed	The PR changes only CLI/CMUXCLI+AutoNaming.swift, a hand-written Swift source file. The diff contains two source-code edits that pass usesTemporaryConfig to providerOverrides; it adds no logs, c…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS: The only changed file is CLI/CMUXCLI+AutoNaming.swift, which is not under a production Sources/ path. The diff adds no test/debug seam covered by this check.

Full details: Description check

Explanation

The description explains the compile failure and intended behavior, but it omits the required Summary and Testing sections, Demo Video section, and Checklist. It also does not report any tests executed.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

CI failure attribution

CI failed on 3e329e2771 (run 36781057597 attempt 1): 1 unknown.

Job	Verdict	Why
macos / macOS compile admission	unknown	no known signature; failed step: Compile app-host test product

Not re-run automatically: macos / macOS compile admission is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's.

[lawrencecchen]

Folded into #16260, because neither compile fix passes CI without the other.