Repository navigation
Show Codex TUI approvals as Needs input - #15926
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
CI failure attributionCI failed on
Matched log linesNot re-run automatically: Written by |
Dogfood tours of
|
|
Red here is not this PR's fault. This branch pins
— Raindrop g2 🫧 / Run: run_worker_20260930_3fc64ba6 |
|
/catch-up My earlier catch-up comment on this PR did nothing: I wrapped the command in backticks, and the gate is — Raindrop g2 🫧 / Run: run_worker_20260930_3fc64ba6 |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Merge receipt for
Labeled |
15cf1ed Reject malformed Cloud VM snapshot and clone arguments (manaflow-ai#15963) c73d135 fix: surface Codex TUI approval attention (manaflow-ai#15926) f4c9ec4 Localization omissions: one record per key, and a loader that rejects duplicates (manaflow-ai#16302) 733616c Add pointer cursor modifier to custom sidebars (manaflow-ai#16263)
Codex TUI
PermissionRequesthooks are zero-wait telemetry because Codex owns the approval prompt in the terminal. The Feed inserted the event but skipped its needs-input attention path, so the sidebar continued to showRunningwhile a Cloud or local Codex session waited for the user.The coordinator now resolves one transient attention target for Codex decision telemetry, surfaces the existing needs-input state without blocking the hook, and retires that target on the next event from the same session. Claude's blocking waiter path and ordinary telemetry remain unchanged, and zero-wait events do not create native approval notifications.
Regression coverage verifies Codex zero-wait attention and limits the classifier to Codex decision events.
Changelog
Validation:
FeedCoordinator.swiftandFeedCoordinatorTests.swiftgit diff --checkSummary by cubic
Shows Codex TUI approval waits as "Needs input" in the sidebar instead of leaving the session stuck on "Running".
Codex owns its approval prompt in the terminal, so its
PermissionRequesthook is zero-wait telemetry. The coordinator now resolves a transient attention target for Codex decision events, surfaces the existing needs-input state without blocking the hook, and retires that target on the next event from the same session. Claude's blocking waiter path and ordinary telemetry are unchanged, and zero-wait events don't create native approval notifications.Adds regression tests covering the transient attention behavior and confirming the classifier only applies to Codex decision events.
Changelog
Written for commit 8ca10af. Summary will update on new commits.