Repository navigation
Align Cloud machine stale status punctuation - #15900
teamleaderleo wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Heads up on the check rollup here: it reads SUCCESS but there is no CI in it. This PR is Worth knowing because the rollup being green here means nothing at all. Resolving the conflict brings CI back on the next push. Leaving the conflict to you since your session is on this branch. — Raindrop g2 🫧 / Run: run_worker_20260930_3fc64ba6 |
|
Closing in favour of #16228, which is the same two commits at the same tree on an One note that travelled with it: the rewritten test is a real improvement, since the old version compared the rendered row against Nothing to redo, just follow #16228. Thanks :) — Raindrop g2 🫧 |
When cached Cloud machines stay visible, the toolbar now separates the sign-in and Pro status from "showing last known" with the same dash used for offline and unavailable states. Each leading clause stays unchanged. This is a copy-only change with no behavior change; status handling, glyphs, actions and truncation are unchanged.
The four keys are
machines.offline.stale,machines.listUnavailable.stale,machines.sessionRejected.staleandmachines.requiresPro.stale. Only the last two catalog entries change. All nine macOS locales retain their wording and use the separator already present in their offline and unavailable entries. The four Swift defaults use literal dash characters becauselocalize-changescannot decode the existing Unicode escapes; the offline and unavailable text renders identically.Validation
The same focused command runs on the separate regression and fix commits:
The dispatcher requires a suite selector, so the selector omits the
.swiftsuffix.7568a7303340c888be52b94c3c09c54f97eff3c7: run 36689405426,Test run with 4 tests in 1 suite failed after 0.061 seconds with 2 issues.Both failures are the comma-separated sign-in and Pro stale lines.583b156c4b0bd22dce4ea88828e92a580f778c4c: run 36694512072,Test run with 4 tests in 1 suite passed after 0.062 seconds.The focused dispatch test job was skipped because the selected tests executed inside the build job; the build job passed.python3 scripts/verify-local.py: all 6 selected checks ran and passed: Swift syntax, XCStrings structure, localization parity, app-source wiring, test wiring and feature flag policy. The wiring tool executed 13 tests with 0 skipped. No local app build, native test execution or app launch was performed../scripts/localize-changes --work-file /tmp/cloud-sidebar-status-localization.jsonimported 16 non-English entries, covering the two changed keys in all nine locales including the updated English entries. The strict validator reports10 catalogs, 9 locales: 0 parity errors.Changelog
Changed: Use consistent separators before "showing last known" in all four Cloud machine toolbar status lines.
🤖 Generated with Claude Code