Skip to content

ci: recover owned order during overflow failover - #15620

Merged
teamleaderleo merged 1 commit into
ci/pickers-account-capacityfrom
ci/cloud-overflow-order-rescue-v2
Sep 29, 2026
Merged

teamleaderleo merged 1 commit into
ci/pickers-account-capacityfrom
ci/cloud-overflow-order-rescue-v2

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

Follow up cmux#15614's outage routing fix for an explicitly Blacksmith-only CI_PR_POOL_ORDER. During an active CI_CLOUD_OVERFLOW_SAVED record, the picker now rebuilds the owned order for the pinned PR Xcode when the configured order has no owned labels. It still refuses to emit a dead Blacksmith candidate and keeps the retry route owned.

Validation

  • Focused failover picker tests pass, including the Blacksmith-only order case.
  • Python compilation and git diff --check pass.

This is a dependent follow-up on #15609; it contains only the small recovery correction.


Summary by cubic

Fixes the failover path so a hand-set Blacksmith-only pool order can't turn an active cloud overflow record into a direct, unmeasured runner route. When the configured order drops to zero owned labels, the picker now rebuilds the owned order for the pinned PR Xcode and keeps the retry route owned.

  • Rebuilds the order from the owned pools for the pinned Xcode when only transient (Blacksmith) labels remain.
  • Adds a regression test covering the Blacksmith-only order case.

Written for commit 4c06d91. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 26c6a892-8d37-4103-9a62-5970ad458e90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit 24fd106 into ci/pickers-account-capacity Sep 29, 2026
43 of 46 checks passed
@teamleaderleo
teamleaderleo deleted the ci/cloud-overflow-order-rescue-v2 branch September 29, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant