Skip to content

ci: recover owned order during overflow failover - #15618

Closed
teamleaderleo wants to merge 1 commit into
ci/pickers-account-capacityfrom
ci/cloud-overflow-order-rescue
Closed

teamleaderleo wants to merge 1 commit into
ci/pickers-account-capacityfrom
ci/cloud-overflow-order-rescue

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

Follow up cmux#15614's outage routing fix for an explicitly Blacksmith-only CI_PR_POOL_ORDER. During an active CI_CLOUD_OVERFLOW_SAVED record, the picker now rebuilds the owned order for the pinned PR Xcode when the configured order has no owned labels. It still refuses to emit a dead Blacksmith candidate and keeps the retry route owned.

Validation

  • Focused failover picker tests pass, including the Blacksmith-only order case.
  • Python compilation and git diff --check pass.

This is a dependent follow-up on #15609; it contains only the small recovery correction.


Summary by cubic

Fixes owned pool routing during a cloud overflow outage so the picker no longer places or retries jobs onto a dead Blacksmith pool. Follow-up to cmux#15614 for an explicitly Blacksmith-only CI_PR_POOL_ORDER.

Bug Fixes

  • While CI_CLOUD_OVERFLOW_SAVED is present (and its recorded lane matches the live MACOS_RUNNER_PR), the picker keeps normal owned placement but never emits a non-owned candidate or retry target.
  • A Blacksmith-only configured order is rebuilt as the owned default for the pinned PR Xcode instead of falling back to an unmeasured direct route.

Written for commit 4c06d91. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b04e2992-491c-45c9-87dd-a69cce662b37

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo force-pushed the ci/cloud-overflow-order-rescue branch from f787d40 to 4c06d91 Compare September 29, 2026 15:07
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Superseded by #15620 after rebasing the dependent change onto the current picker branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant