Repository navigation
PR media: keep each tour's folder through the artifact hand-off - #15405
Conversation
download-artifact extracts a single matched artifact straight into the path, without the per-artifact folder the publish step renamed, so a one-tour run published nothing it made and wrote 'left no result'. Each tour now uploads the folder above its own, so the archive holds <tour>/, and publish downloads them merged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Merge receipt for |
9eb402d Sidebar: opt-in compact status glyph for agent, PR and branch state (manaflow-ai#14838) 0b2d3e0 ci: run CmuxCloud package tests and move 22 Cloud logic suites out of the app host (manaflow-ai#15333) defccda fix(cloud): say a machine's id and age in its accessibility label (manaflow-ai#15326) 8b23dd7 ci: re-run lost-runner jobs; end the UI wait when compile admission fails (manaflow-ai#15400) 734cff3 ci: let the UI test lane replay the fuzzer regressions (manaflow-ai#15401) c9b235a Refuse a split that would leave a pane below its minimum size (manaflow-ai#15392) 56eacd4 Describe memory-pressure hibernation the way it works (manaflow-ai#15290) da27bbc ci: passing guard tests print no ::error annotations (manaflow-ai#15399) 93d0706 ci: explicit owned E2E runs take root runners; rescue jobs waiting in setup (manaflow-ai#15402) f12f578 PR media: keep each tour's folder through the artifact hand-off (manaflow-ai#15405) cd9d1c9 test: release offscreen terminal fixtures before the next suite (manaflow-ai#15322) 78c566c triage: severity and area labels, with the rules in the repo (manaflow-ai#15228) 54473f6 Serialize async test app contexts (manaflow-ai#15390) 192ee4c Stabilize minimal-mode workspace routing test (manaflow-ai#15385) 31a59ab Cloud machine list reports who created each machine (manaflow-ai#15261)
|
Subagent review at 39bf414 (post-merge backfill): approved. Findings: (LOW) keeping the frame scratch out of the artifact relies on upload-artifact's default include-hidden-files: false, recorded only in a comment; (LOW) the new test checks the workflow's upload and download settings, not the merged download layout itself. No HIGH or MEDIUM findings; the LOWs are not addressed yet. |
1 participant
Summary
This fixes a bug where the manifest written by a single-tour run never reached the publish job.
actions/download-artifactextracts a single matched artifact straight intopath, without the per-artifact folder the publish step expected to rename. In a proof run on Settings: Font card with live preview, font gallery, and line height #15210, the tour wrote a skip note ("CI left no app build yet"; that PR's compile admission had failed). Publish didn't find the manifest and posted "the tour job left no result" instead.<tour>/.... Publish downloads all tours merged into one folder, and the rename loop is gone. Frame scratch folders are hidden and stay out of the artifact.Testing
python3 tests/test_ci_pr_media.py: 63 tests, including a new check of the upload path and the merged download.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes a single-tour run where the manifest written by the tour never reached the publish job, so it posted "left no result" instead of the tour's output.
download-artifactno longer gets a per-artifact folder to rename; each tour now uploads the folder above its own so the archive holds<tour>/..., and publish downloads all tours merged.Written for commit 39bf414. Summary will update on new commits.