Repository navigation
test: release offscreen terminal fixtures before the next suite - #15322
Merged
teamleaderleo merged 4 commits intoSep 28, 2026
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughTerminal offscreen startup tests now track created panels and managers. Teardown releases hosted surfaces and closes managers. The browser-and-terminal chrome test runs its glass-setting cases sequentially. ChangesTerminal test resource cleanup
Overlay chrome test execution
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change only affects test cleanup and test execution order in the test suite; it does not alter shipped application behavior and poses no merge-blocking risk. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
added
the
full-ci
Contributor
CI failure attributionCI passes on Written by |
teamleaderleo
force-pushed
the
fix/window-portal-cluster
branch
from
September 28, 2026 11:27
632f57c to
fa13c48
Compare
The three DEBUG mobile tests built untracked RecordingMobileTabManager instances whose workspaces hold terminals, so their surfaces could still be freed in a later suite. Track them like the others. The window backdrop change rested on argument cases running concurrently, which a serialized suite does not do; each case is one synchronous main-actor turn. Drop it so it cannot mask what removes the glass root. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
teamleaderleo
changed the title
teamleaderleo
enabled auto-merge (squash)
September 28, 2026 12:25
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 28, 2026
9eb402d Sidebar: opt-in compact status glyph for agent, PR and branch state (manaflow-ai#14838) 0b2d3e0 ci: run CmuxCloud package tests and move 22 Cloud logic suites out of the app host (manaflow-ai#15333) defccda fix(cloud): say a machine's id and age in its accessibility label (manaflow-ai#15326) 8b23dd7 ci: re-run lost-runner jobs; end the UI wait when compile admission fails (manaflow-ai#15400) 734cff3 ci: let the UI test lane replay the fuzzer regressions (manaflow-ai#15401) c9b235a Refuse a split that would leave a pane below its minimum size (manaflow-ai#15392) 56eacd4 Describe memory-pressure hibernation the way it works (manaflow-ai#15290) da27bbc ci: passing guard tests print no ::error annotations (manaflow-ai#15399) 93d0706 ci: explicit owned E2E runs take root runners; rescue jobs waiting in setup (manaflow-ai#15402) f12f578 PR media: keep each tour's folder through the artifact hand-off (manaflow-ai#15405) cd9d1c9 test: release offscreen terminal fixtures before the next suite (manaflow-ai#15322) 78c566c triage: severity and area labels, with the rules in the repo (manaflow-ai#15228) 54473f6 Serialize async test app contexts (manaflow-ai#15390) 192ee4c Stabilize minimal-mode workspace routing test (manaflow-ai#15385) 31a59ab Cloud machine list reports who created each machine (manaflow-ai#15261)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The full suite no longer lets window-test fixtures leak process-wide backdrop changes or native terminal frees into later suites.
Testing
WindowOverlayChromeTests/browserAndTerminalRespectChrome(useGlass:)failed after the two argument cases ran concurrently; the same signature also occurred in runs 36341390537 and 36379348668.TerminalWindowPortalLifecycleTests/testDragDrivenSidebarResizeDoesNotScheduleLateSecondTerminalResize()failed during setup while two terminal frees fromTerminalOffscreenStartupTestswere still pending.python3 scripts/verify-local.py --only swift-syntax --swift-changed upstream/mainpassed for both edited files.full-ciremains requested because the fix targets cross-suite leakage and must exercise later app-host shards, not only the edited suites. No cmux app build or native test ran on this Mac.Impact map
TerminalOffscreenStartupTestsand process-global window backdrop defaults used byWindowOverlayChromeTests.Review
Independent and isolated structured reviews found no actionable issue in the exact test-only patch. CodeRabbit reviewed the current head and reported minimal merge risk with no actionable comments; Cursor supplied only a spend-limit notice.
— Mochi
Mergeability
8743ec8c36ebf59badf47b499b780adc310a1f11d70294cc4afd807420ba4d53ab9095ae68da93421859b95ed1608333ce6ee3800b8a2616a996fe0c.Changelog
none