Skip to content

Say why the portal fixture's scrollback wait failed #14898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Sep 27, 2026
Merged

Say why the portal fixture's scrollback wait failed #14898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion cmuxTests/TerminalPortalGeometryFixture.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,25 @@ final class TerminalPortalGeometryFixture {
await flushLayout()
} while ContinuousClock.now < deadline && !Task.isCancelled
let hasScrollback = false
try #require(hasScrollback, "Expected shell output to create real scrollback", sourceLocation: sourceLocation)
try #require(
hasScrollback,
Comment(rawValue: "Expected shell output to create real scrollback; " + scrollbackDiagnostics()),
sourceLocation: sourceLocation
)
}

/// Separates the two ways the scrollback wait can fail: the command never
/// produced output (the terminal holds no scrollback), or it did and the
/// view never received the runtime's scrollbar packet.
private func scrollbackDiagnostics() -> String {
var runtime = ghostty_surface_scrollbar_s()
let runtimeScrollbar = hosted.surfaceView.readAuthoritativeScrollbar(&runtime)
? "total=\(runtime.total) offset=\(runtime.offset) len=\(runtime.len)"
: "unavailable"
let text = surface.visibleText().map { String($0.suffix(600)) } ?? "nil"
return "viewScrollbar=\(String(describing: hosted.surfaceView.scrollbar)), " +
"runtimeScrollbar=\(runtimeScrollbar), tty=\(surface.controllingTTYName() ?? "nil"), " +
"visibleText=\(text.debugDescription)"
}

/// Read the actual terminal screen and kernel TTY, not just Ghostty's
Expand Down
Loading