Repository navigation
Say why the portal fixture's scrollback wait failed - #14898
Merged
Merged
Conversation
legacyScrollerCommitsClipWidthWithoutPaneResize() fails on main now and then (2 of the 16 full-suite main runs on 2026-09-26) with only "Expected shell output to create real scrollback". That can't tell a command that never produced output from output whose scrollbar packet never reached the view. The failure now records the view's scrollbar, the runtime's own scrollbar, the TTY and the visible text. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe scrollback test assertion now reports view and runtime scrollbar values, the controlling TTY, and up to 600 characters of visible text when it fails. ChangesScrollback diagnostics
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds diagnostic details to an existing scrollback test failure without a supported impact on passing tests or terminal state. 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 27, 2026
f77bfdd Show a password input indicator while echo is off (manaflow-ai#14867) ec04960 web tests: spawn client-config-env children asynchronously (manaflow-ai#14899) f10c5ce test: say why the portal fixture's scrollback wait failed (manaflow-ai#14898) 2e6a5ba ci: give each virtual display helper its own serial (manaflow-ai#14897) 208a6bf Keep the unfocused-pane dim in step with focus when a pane is revealed (manaflow-ai#14892) 33b4c92 fix: finish a detach-induced checklist popover close without its animation (manaflow-ai#14895) a3baec3 test: free the remaining hosted test terminals and scope the portal leak check (manaflow-ai#14888)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TerminalWindowPortalCommittedGeometryTests/legacyScrollerCommitsClipWidthWithoutPaneResize()fails on main now and then. When it does, the only message is "Expected shell output to create real scrollback". That doesn't say whether the command never produced output, or produced it and the scrollbar packet never reached the view. Now the failure also records the view's scrollbar, the runtime's own scrollbar (ghostty_surface_scrollbar), the TTY, and the last 600 characters of visible text. The next failure will show which of the two it was.This PR changes only the failure message. It doesn't fix the flake, because I couldn't find its cause:
26a1e883, a docs-only commit (36239073356, shard 5, cmuxs-mac-mini-5), and passed at the commit before it (4061427e, cmux11s). It failed again at022cc2dc(36271922019, shard 5, cmux7s) and passed at the next commit,c5e72222. That's 2 of the 16 full-suite main runs on 2026-09-26./bin/shran.Validation: this head's tree passed the focused suite (11 tests, including this one) on the owned lane in 36291078295 (cmux14). That run was at
8913e4ca, which has the same tree with a different commit message.🤖 Generated with Claude Code
Summary by cubic
Adds diagnostics to the portal scrollback test's failure message so the next flake shows whether the command never produced output or its scrollbar packet never reached the view. The failure now records the view's and runtime's scrollbars, the TTY, and the last 600 characters of visible text. The change only affects the failure message; the cause of the flake wasn't found—the test and the code it exercises haven't changed since 2026-09-16, and it doesn't reproduce on demand (100/100 repeats passed).
Written for commit 8424612. Summary will update on new commits.
Summary by CodeRabbit