test(ios): align Mac switch and pool tests with build-scoped identity

[teamleaderleo]

Why

Five CmuxMobileShell tests in the "Mac switch / secondary promotion" group of #14689 fail on every full package run. PR CI only runs selected suites, so they went unseen until #14439 turned iOS PR runs back on. A traced CI run (debug branch, since deleted) showed where each one stops. All three causes are fixtures that predate #10179 ("Use build-scoped identity for every iOS computer operation"). The product behavior is intentional, so these are test fixes.

What

• promotedSecondaryMacUsesItsOwnTaskCreateCapability, taskComposerDoesNotArmCreateBoundaryBeforeTargetCapabilityCheck, taskComposerArmsCreateBoundaryAfterTargetMacPromotion: the composer calls switchToMac with no instance tag. Since 5aedb51 (Use build-scoped identity for every iOS computer operation #10179), resolvePromotableSecondaryOwnerKey promotes a live secondary on a device-only request only when the loaded paired-Mac cache shows exactly one untagged row for that device. It no longer accepts zero rows. The tests never loaded that cache (trace: candidates=1 stored=[]), so promotion was skipped and the fresh dial had no routes. switchToMac returned false and the composer reported notConnected. The tests now call loadPairedMacs() and assert that it succeeds, as the app loads the cache before the composer opens.
• switchingToIrohCapableMacUsesPinnedIrohRoute: the stored row has no tag, but the scripted host authenticates as tag "default". The dial connected over Iroh (trace: resolved=test-mac tag=default route=iroh-personal), but since 1d036db (Use build-scoped identity for every iOS computer operation #10179) a switch counts only when the live foreground matches the stored pairing's build. The host is now the same untagged build as the row.
• connectionPoolRecordsFallbackRouteThatActuallyConnected: the route was pooled correctly under test-mac + default (trace: onDevice=test-mac\x1fdefault good), but the test read it by bare device id, which now resolves only the untagged owner. It now asserts the authenticated tag and reads the exact pairing key, the same fix test(ios): give pool alias fixtures one build identity #14004 made in the pool tests.

The change is test-only.

Proof

• Focused package run on the final head, covering the five tests and the whole MobileTaskComposerSubmitTests suite: all 29 tests pass. https://github.com/manaflow-ai/cmux/actions/runs/36183676725
• An earlier run over all three suites passed all five: https://github.com/manaflow-ai/cmux/actions/runs/36183217741. Its only failures were hungRedialSettlesAtDeadlineAndUnfreezesRecovery and operationFailurePreservesOpenIrohConnection, which belong to the connection-recovery group.
• This PR's full-suite mobile-core-package run also passes all five. What still fails there is the render-grid group plus the intermittent byteGapDeliversLiveChunkAndRequestsSingleReplay, and those have their own PRs.
• Failing on main: https://github.com/manaflow-ai/cmux/actions/runs/36177304860

Refs #14689.

🤖 Generated with Claude Code

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[coderabbitai]

Warning

Review limit reached

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 36e1ccd8-3e49-4da4-abd7-3ab40d00f177

📥 Commits

Reviewing files that changed from the base of the PR and between fba6c47 and c30c3e1.

📒 Files selected for processing (3)

• Packages/iOS/CmuxMobileShell/Tests/CmuxMobileShellTests/IrohReconnectRouteSelectionTests.swift
• Packages/iOS/CmuxMobileShell/Tests/CmuxMobileShellTests/MobileTaskComposerSubmitTests.swift
• Packages/iOS/CmuxMobileShell/Tests/CmuxMobileShellTests/ReconnectRouteSelectionTests.swift

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[github-actions]

Merge receipt for c30c3e130c, merged 2026-09-25 20:33:13 UTC

• Not verified at merge: ios-simulator (ipad) (in progress), ios-simulator (iphone) (in progress), mobile-core-package (failure)
• Verified: ci-status, Web complexity, web-validation, detect-ios-changes, Fast static checks, guards (6), ios-simulator-build, package-conventions-lint, runner, Testbox broker trust boundary, tests
• Skipped by policy: browser, Claude wrapper regressions, GhosttyKit release check, linux-preflight, macos, macOS admission gate, remote-daemon, suite-coverage, web, web-build, web-database-tests, web-tests
• Full suite: runs on main after merge.