Skip to content

Add app.equalizeSplitsOnCreate to balance panes on new splits - #14703

Merged
teamleaderleo merged 2 commits into
mainfrom
equalize-splits-on-create
Sep 25, 2026
Merged

teamleaderleo merged 2 commits into
mainfrom
equalize-splits-on-create

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #731

Adds app.equalizeSplitsOnCreate (default false, so nothing changes unless you turn it on). When on, creating a split rebalances the panes in that split's row or column, so repeated Cmd+D gives 50/50, then thirds, then quarters instead of 50/25/12.5.

How it works:

  • One shared step, Workspace.equalizeSplitsAfterCreatingSplitIfEnabled, runs the new PaneLayoutService.equalizeSplitRun. It equalizes only the run of same-orientation splits that holds the new pane (a pure plan in CmuxPanes, equalizeDividerPlan(forSplitRunContainingPaneId:), with the same span weighting as Equalize Splits). A vertical split never moves the dividers between side-by-side panes, and a split in one row leaves hand-tuned dividers in other rows alone.
  • It runs after user-initiated splits: TabManager.createSplitOutcome (keyboard shortcut, menu, context menu, command palette, Ghostty split action passthrough), TabManager.newSplit (AppleScript), TabManager.newBrowserSplit (browser split actions), the v1 new_split and v2 surface.split / pane.create socket commands, and bonsplit's own split buttons.
  • An explicit divider position (for example --ratio on the CLI) still wins. Session restore, workspace layouts, remote tmux mirrors and canvas mode are left alone. The Dock split store, Cmd-click links that open in a new split, and drag-to-split are not covered.

Setting surfaces: settings catalog, cmux.json path support and template, schema (embedded copy regenerated), skills/cmux-settings/references/all-keys.md, and a toggle in Settings > App next to the focus history row, localized in all nine macOS locales.

Tests: TabManagerEqualizeSplitsOnCreateTests covers off (50/25/25), on (thirds), orientation scoping, unrelated rows staying put, and an explicit divider winning. SplitGeometryTests covers the run plan. SettingCatalogTests checks the default is off.

Known limit: when the run spans more than the new split, the other panes' terminals keep their old frames until their anchors re-layout, the same as running Equalize Splits by hand. The new split's pair still gets its provisional frames.

Not duplicating #1701 or #3200: those add an equalize shortcut, which main already has. This one equalizes automatically on create.

Thanks @aibakun for the request.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d7fbb76d-8884-491c-a7f9-b5048861bec9

📥 Commits

Reviewing files that changed from the base of the PR and between 8538fa9 and d3b1366.

⛔ Files ignored due to path filters (1)
  • Packages/macOS/CmuxFoundation/Sources/CmuxFoundation/ConfigValidation/CmuxConfigSchema.generated.swift is excluded by !**/*.generated.*
📒 Files selected for processing (22)
  • Packages/macOS/CmuxPanes/Sources/CmuxPanes/Geometry/ExternalTreeNode+SplitGeometry.swift
  • Packages/macOS/CmuxPanes/Sources/CmuxPanes/PaneLayoutService.swift
  • Packages/macOS/CmuxPanes/Tests/CmuxPanesTests/SplitGeometryTests.swift
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Keys/AppCatalogSection.swift
  • Packages/macOS/CmuxSettings/Tests/CmuxSettingsTests/SettingCatalogTests.swift
  • Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Navigation/CuratedSettingEntry+Default.swift
  • Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/AppSection.swift
  • Packages/macOS/CmuxSettingsUI/Tests/CmuxSettingsUITests/SettingsRowAnchorResolutionTests.swift
  • Resources/Localizable.xcstrings
  • Sources/CmuxSettingsFileStore+SupportedPaths.swift
  • Sources/CmuxSettingsJSONPathSupport.swift
  • Sources/KeyboardShortcutSettingsFileStore+Template.swift
  • Sources/TabManager+TerminalSplitAction.swift
  • Sources/TabManager.swift
  • Sources/TerminalController+ControlPaneContext.swift
  • Sources/TerminalController+ControlSurfaceContext2.swift
  • Sources/TerminalController.swift
  • Sources/Workspace+EqualizeSplitsSupport.swift
  • Sources/Workspace.swift
  • cmuxTests/TabManagerUnitTests.swift
  • skills/cmux-settings/references/all-keys.md
  • web/data/cmux.schema.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

teamleaderleo and others added 2 commits September 25, 2026 16:09
When on, creating a split rebalances the splits along that split's
orientation so the panes share the space evenly (50/50, then thirds,
then quarters) instead of halving the source pane. Default off keeps
the current behavior. The shared post-create step runs from the
TabManager split actions (shortcut, menu, context menu, command palette,
Ghostty split passthrough), browser splits, AppleScript, the v1 and v2
socket split commands, and bonsplit's split buttons. Explicit divider
positions still win.

Fixes #731

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Equalize only the run of same-orientation splits that holds the new pane
(new CmuxPanes plan + PaneLayoutService.equalizeSplitRun), so a split in
one row no longer resets hand-tuned dividers in another. Move the three
Settings strings to the app catalog that String(localized:) reads, and
equalize before publishing the ui_split event.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo force-pushed the equalize-splits-on-create branch from 4a1c3c0 to d3b1366 Compare September 25, 2026 20:10
@teamleaderleo
teamleaderleo merged commit e817240 into main Sep 25, 2026
22 checks passed
@teamleaderleo
teamleaderleo deleted the equalize-splits-on-create branch September 25, 2026 20:11
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for d3b13669f1, merged 2026-09-25 20:11:13 UTC

  • Not verified at merge: ci-status (not reported), browser-skill (in progress), detect-ios-changes (in progress), Fast static checks (in progress), Web complexity candidate (in progress)
  • Verified: Web complexity, web-validation, catalog-structure, runner, Testbox broker trust boundary
  • Skipped by policy: web-build, web-database-tests, web-tests
  • Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

@github-actions github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Sep 25, 2026
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 25, 2026
b63ab49 Fail remote-tmux review when a wait is a timer instead of an event (manaflow-ai#11264)
b436c92 Fail closed when CLI forwarding loops back to the GUI binary (manaflow-ai#8788)
136eb2a fix(ios): make the last intermittent CmuxMobileShell tests deterministic (manaflow-ai#14721)
dc7f5bd fix(ios): keep terminal composer dock at bottom (manaflow-ai#14702)
cb4429b ci: add owned_build_state.py warm-keys for warm admission routing (manaflow-ai#14717)
be1ab5e ci(ios): charge in-flight auto runs simulators only when they took the fleet (manaflow-ai#14716)
5110582 ci: clear fixed DerivedData by renaming it aside first (manaflow-ai#14710)
1b8a603 fix(ios): unregister terminal output streams by registration identity; fix stale render-grid tests (manaflow-ai#14711)
3cae7dd refactor: move the browser WebKit support layer into CmuxBrowser (manaflow-ai#14398)
6693884 Run the Codex monitor Stop replay outside the hook handler frame (manaflow-ai#14715)
133a083 ci(e2e): take the owned Mac's gui token just before testing in the build (manaflow-ai#14705)
4c36ace ci: re-run every job of an E2E run whose build did not succeed (manaflow-ai#14712)
ab5ac72 ci: start owned E2E builds from the Mac's kept state, upload after tests (manaflow-ai#14692)
6a3d2d0 test(ios): align Mac switch and pool tests with build-scoped identity (manaflow-ai#14708)
0b16a8b Keep closePanel's unmapped fallback from closing another panel's tab (manaflow-ai#14704)
69c9518 close-surface: reject a blank --workspace or --window (manaflow-ai#14706)
8476043 ci: route warm admission by static runner labels, never write labels (manaflow-ai#14696)
537d53f Guard direct GhosttyKit setup against incompatible Zig (manaflow-ai#4706)
4b200e1 Restore Pi wakeup alerts across reloads (manaflow-ai#12861)
9b291c0 ci: resolve an owned Mac's kept Swift packages offline (manaflow-ai#14709)
31c9105 Stop attaching the unverified per-resume relay MAC (manaflow-ai#14694)
5443f43 Merge pull request manaflow-ai#13565 from manaflow-ai/feat-recover-forgotten-computers
e817240 Add app.equalizeSplitsOnCreate to balance panes on new splits (manaflow-ai#14703)
a358095 fix: never use a shell bootstrap executable in a resume binding (manaflow-ai#5848)
3f177af Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
8b4c97b Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
dce9509 ci: update iOS checkout routing assertion
5dbf06c ci: update CLA workflow digest after main pin
44c00fb Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
d22189d Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
eeca51a fix: make event reconnect policy instance based
9e29c96 Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
d860564 Model first Cloud receipt before remote graph discovery
87f1305 Verify forgotten Mac recovery with the real paired store
2237f8c Merge main and retain upstream test repairs
9ccaa7a Avoid type-check timeout in process fixture
a848b5e Simplify AppKit accessibility test setup
82a9769 Isolate process generation fixture from runner TTY state
4c129bb Enable and restore AppKit assistive access in mounted tree test
9a9acca Enable accessibility output in the hosted SwiftUI test fixture
5ce39d0 Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
a29a7ec Read proxy accessibility children and text through one attribute bridge
12938b6 Test accessibility walkers against modern and legacy proxy nodes
04a30c5 Revoke the original pairing in the targeted dial authority regression
ff1888e Import the extracted Cloud module in the team picker
9c9f259 Merge main and adopt the verified focus recovery fixture
5d41fc8 Align hosted UI fixtures with runtime paths and presentation lifecycle
87dbbd9 Preserve unknown legacy restore liveness after main integration
41a8d4b Revert "Establish running agent state in auto-resume fixtures"
6c7d14b Revert "Use the running-agent fixture for second-restore cwd coverage"
9d276b5 Route Kiro permission-mode fixtures through the mock delivery target
cdb4eae Restore the host app delegate after registration tests
4bdc410 Use the running-agent fixture for second-restore cwd coverage
0b58cbc Establish running agent state in auto-resume fixtures
20c6415 Wait for mounted project content in accessibility test
3ba7b6a Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
2c3c680 Make reparent focus test geometry deterministic
d2f563b Stabilize canonical cache recipe guard
cc60792 Merge current main into forgotten Mac recovery
7dc515f Merge branch 'main' into feat-recover-forgotten-computers
cfd4773 Preserve per-instance forgotten Mac recovery
6a95584 Canonicalize recovered directory identities
f083246 Preserve queued forgotten Mac refreshes
e5202a6 test(ios): use canonical UUID duplicate fixture
ca7ee53 fix(ios): serialize forgotten Mac recovery retries
db851c2 Merge remote-tracking branch 'origin/main' into feat-recover-forgotten-computers
35269cb fix(ios): rehydrate Macs after forget recovery
d0266b7 Merge current CI workflow identity guard into device recovery
45b7c72 fix(i18n): distinguish signed-in Mac recovery from connectivity
730260c Merge remote-tracking branch 'origin/feat-recover-forgotten-computers' into feat-recover-forgotten-computers
a17f8dd fix: complete forgotten Mac recovery without replaying revocation
d64766a test: reproduce revocation during device recovery registration
faf5b55 test: keep recovery authority limited to enrollment
a9c437a test: cover duplicate forget and recovery lifecycle gaps
033e7a0 chore: normalize project ordering
28f63ec fix: recover forgotten Macs from revocation events
7b8e322 fix: recover forgotten Mac registrations
f1aca40 test: validate recovery enrollment proof
62b4e14 test: cover authenticated forgotten-device recovery
9cb2f97 test: cover recovery after device forget

# Conflicts:
#	.github/workflows/app-host-test-rerun.yml
#	.github/workflows/ci-guards.yml
#	.github/workflows/ci-macos.yml
#	.github/workflows/ci-queue-janitor.yml
#	.github/workflows/ci.yml
#	.github/workflows/nightly.yml
#	.github/workflows/seed-derived-data.yml
#	.github/workflows/test-e2e.yml
#	.github/workflows/test-ios.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-unverified A judging check was not green at merge; see the merge receipt comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: distribute split panes evenly when creating new splits

1 participant