Skip to content

docs: review with a subagent, not a second model; re-dogfood is a judgment call - #14590

Merged
teamleaderleo merged 3 commits into
mainfrom
docs/subagent-review-policy
Sep 25, 2026
Merged

teamleaderleo merged 3 commits into
mainfrom
docs/subagent-review-policy

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Two policy updates from Leo (2026-09-25). Paired with manaflow-ai/cmuxterm-hq#673, which makes the same change in hq CLAUDE.md.

Location Class Evidence Change
CLAUDE.md First pass, review paragraph stale / contradicts Leo, 2026-09-25: second-model review is outdated, "you guys do subagents now". Old text (#9194, 2026-07-29) made review explicit user opt-in, while skills/cmux-review said to use it before opening a PR Replaced with: review subagent on the exact diff (correctness first), fix, quick second subagent pass when fixes were non-trivial; no second model (codex review, $autoreview) as a gate. Bots still run asynchronously
CLAUDE.md dogfood/approval paragraph missing Leo, 2026-09-25: re-dogfood after a merge directive "makes sense sometimes, doesn't others"; hq CLAUDE.md said "do not ask the user to dogfood again" Added the shared re-dogfood sentence (word-identical to hq): re-dogfood when a later fix changes user-visible behavior beyond what was dogfooded, skip for internal/test-only/tightly scoped fixes, say on the PR which and why. Approval now also accepts a direct merge directive, defined as in hq (merge, merge it, auto-merge; not finish, lgtm, ship it), since the new sentence depends on it
skills/cmux-review/SKILL.md description + new "Default pre-merge review" section contradicts description said "Use before opening a PR" while CLAUDE.md said review is opt-in The skill now leads with the default subagent pass (steps match CLAUDE.md, including the app/runtime/UI approval gate); the full adversarial protocol is for high-risk changes or a user-requested deep review. Rest of the protocol unchanged

Review: one review subagent on the exact diff (found the skill's merge step skipped the approval gate and the merge directive was undefined; both fixed), then a quick second subagent pass (clean).

Flagged, not changed: .github/pull_request_template.md still carries a commented-out @codex review / bot trigger block for contributors (outside CLAUDE.md and skills/). No scripts in this repo become unreferenced (the Codex review scripts live in cmuxterm-hq and are listed there).

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Updates the review and dogfood policies in CLAUDE.md and the cmux-review skill so pre-merge review runs on a subagent, not a second model.

  • Replaces the second-model review gate (codex review, $autoreview) with a review subagent on the exact diff, then a quick second pass when the fixes were non-trivial.
  • Adds a re-dogfood judgment call after a merge directive: re-dogfood when a later fix changes user-visible behavior, skip for internal/test-only/tightly scoped fixes, and say which on the PR.
  • Defines a direct merge directive (merge, merge it, auto-merge; finish, lgtm, and ship it are not) as an alternative to explicit approval for app/runtime/UI merges.
  • Makes cmux-review lead with the default subagent pass; the full adversarial protocol is now only for high-risk changes or when the user asks for a deep review.

Written for commit 2c825a1. Summary will update on new commits.

Review in cubic

teamleaderleo and others added 3 commits September 25, 2026 08:00
…ter a merge directive

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ctive

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3002370e-9a7e-4bd7-8fef-f441aa22f67f

📥 Commits

Reviewing files that changed from the base of the PR and between 2d4edfa and 2c825a1.

📒 Files selected for processing (2)
  • CLAUDE.md
  • skills/cmux-review/SKILL.md
 _____________________________________
< No code too small, no bug too tall. >
 -------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit 6b6fdc3 into main Sep 25, 2026
51 of 53 checks passed
@teamleaderleo
teamleaderleo deleted the docs/subagent-review-policy branch September 25, 2026 12:10
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for 2c825a1562: every check was green at merge (8 verified; 11 skipped by policy). Full suite runs on main after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant