Repository navigation
ci: let a dispatched seed save the SwiftPM manifest cache - #14288
Merged
Merged
Conversation
The workspace-path resolve that stage depends on ran only on main pushes, so a workflow_dispatch of seed-derived-data restored, resolved and then skipped the save. Main dispatches run in ci-cache-writer too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
enabled auto-merge (squash)
September 24, 2026 21:05
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe manifest-evaluation step now runs on a SwiftPM manifest cache miss when the workflow ref is ChangesManifest evaluation workflow
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Manual runs on main can now stage and save the manifest cache as intended. No actionable merge risk remains after normal checks. 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 24, 2026
fb1759a Merge pull request manaflow-ai#14116 from manaflow-ai/issue-13251-display-session-flicker 4bcfbdb ci: keep compile admission's build state on an owned Mac between jobs (manaflow-ai#14285) 5f01b36 Merge pull request manaflow-ai#14284 from manaflow-ai/issue-14027-sidebar-tmux-focus 2062c82 Merge pull request manaflow-ai#14045 from manaflow-ai/14024-hook-prompt-length 616cd44 ci: let a dispatched seed save the SwiftPM manifest cache (manaflow-ai#14288) c4dcf65 iOS: rebuild the workspace list table engine (manaflow-ai#14040) 1670d11 Document focusable sidebar IDs and remote readiness cff83c2 Expose focusable sidebar surfaces and preserve explicit focus 44fd840 Test sidebar surface identities and cross-workspace focus 8c5a1c7 docs: bound display-change rationale to observed code path 900b55d Merge remote-tracking branch 'origin/main' into issue-13251-display-session-flicker a530c4c test: retry expected event-stream disconnects while collecting telemetry 9250404 test: inspect app exit status only after process termination 072809c test: clean socket probe process diagnostics 4098af4 test: launch the socket-only probe without expected activation failures c3771e6 Merge commit '169cd1af66b1e96cdedf9d30b415a370574948bf' into 14024-hook-prompt-length 169cd1a fix: split the SSH session-list merge so it type-checks on slow runners 2b713cc test: resolve probe Python from the selected Xcode installation 570412f Merge branch 'main' into 14024-hook-prompt-length f4d8ac2 fix(terminal): avoid redraw on display topology changes 2e42f86 test: assert each hook entrypoint retains its existing attribution contract 024965f test: collect event frames separately from Debug CLI diagnostics 3ce127f test: isolate hook probe app storage under the shared fixture home a276c01 test: keep hook probe socket in the runner-owned temporary directory 5482f48 test: launch hook probe app outside the runner sandbox 857c953 test: retain isolated app startup evidence for hook probe 7dab194 test: use Xcode Python directly inside the UI test sandbox 0bf8cb2 test: launch socket-only hook probe without foreground activation 5181aed test: wait for hook delivery and handle event stream timeouts 8f21fac chore: refresh generated schema after upstream word-wrap shortcut cfe5ed7 Merge remote-tracking branch 'origin/main' into 14024-hook-prompt-length 2adae62 fix: keep legacy prompt length fallback bound to its message 80cffee fix: preserve original prompt length in hook event telemetry cfcb3fd test: reproduce original hook prompt length loss through events # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/seed-derived-data.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
workflow_dispatchofseed-derived-data.ymlon main never saves the SwiftPM manifest cache. "Evaluate manifests at the cli-pipe-regressions path" was gated ongithub.event_name == 'push', and "Stage SwiftPM manifest cache" requires that step to succeed. Dispatch 36057477097 restored, resolved, then skipped both "Stage SwiftPM manifest cache" and "Save SwiftPM manifest cache".That matters because
decideonly builds when the build fingerprint changes. A change toscripts/ci/swiftpm-manifest-cache.shalone (like #14282) moves the cache key without reseeding, and dispatch is the way to reseed it. The gate is nowgithub.ref == 'refs/heads/main'. Dispatches on main run inci-cache-writerlike pushes do, and every other manifest step is already main-only.Validation (local):
actionlint,test_seed_derived_data.pyandtest_ci_pull_request_caches_are_read_only.pypass.Signed: Manifold g1 ✨ (run_swiftpm-manifest-cache-20260924)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the
seed-derived-data.ymlworkflow so aworkflow_dispatchon main can now save the SwiftPM manifest cache, previously only pushes triggered the save. This matters because changing the manifest cache script alone shifts the cache key without reseeding, and dispatch was the only way to reseed it.Written for commit a71ba15. Summary will update on new commits.
Summary by CodeRabbit