Repository navigation
Fix terminal session flicker on display changes - #14116
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 40 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 24, 2026
fb1759a Merge pull request manaflow-ai#14116 from manaflow-ai/issue-13251-display-session-flicker 4bcfbdb ci: keep compile admission's build state on an owned Mac between jobs (manaflow-ai#14285) 5f01b36 Merge pull request manaflow-ai#14284 from manaflow-ai/issue-14027-sidebar-tmux-focus 2062c82 Merge pull request manaflow-ai#14045 from manaflow-ai/14024-hook-prompt-length 616cd44 ci: let a dispatched seed save the SwiftPM manifest cache (manaflow-ai#14288) c4dcf65 iOS: rebuild the workspace list table engine (manaflow-ai#14040) 1670d11 Document focusable sidebar IDs and remote readiness cff83c2 Expose focusable sidebar surfaces and preserve explicit focus 44fd840 Test sidebar surface identities and cross-workspace focus 8c5a1c7 docs: bound display-change rationale to observed code path 900b55d Merge remote-tracking branch 'origin/main' into issue-13251-display-session-flicker a530c4c test: retry expected event-stream disconnects while collecting telemetry 9250404 test: inspect app exit status only after process termination 072809c test: clean socket probe process diagnostics 4098af4 test: launch the socket-only probe without expected activation failures c3771e6 Merge commit '169cd1af66b1e96cdedf9d30b415a370574948bf' into 14024-hook-prompt-length 169cd1a fix: split the SSH session-list merge so it type-checks on slow runners 2b713cc test: resolve probe Python from the selected Xcode installation 570412f Merge branch 'main' into 14024-hook-prompt-length f4d8ac2 fix(terminal): avoid redraw on display topology changes 2e42f86 test: assert each hook entrypoint retains its existing attribution contract 024965f test: collect event frames separately from Debug CLI diagnostics 3ce127f test: isolate hook probe app storage under the shared fixture home a276c01 test: keep hook probe socket in the runner-owned temporary directory 5482f48 test: launch hook probe app outside the runner sandbox 857c953 test: retain isolated app startup evidence for hook probe 7dab194 test: use Xcode Python directly inside the UI test sandbox 0bf8cb2 test: launch socket-only hook probe without foreground activation 5181aed test: wait for hook delivery and handle event stream timeouts 8f21fac chore: refresh generated schema after upstream word-wrap shortcut cfe5ed7 Merge remote-tracking branch 'origin/main' into 14024-hook-prompt-length 2adae62 fix: keep legacy prompt length fallback bound to its message 80cffee fix: preserve original prompt length in hook event telemetry cfcb3fd test: reproduce original hook prompt length loss through events # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/seed-derived-data.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display connect/disconnect notifications schedule a second backing-properties callback for every terminal view. This candidate fix for #13251 removes that synthetic callback and leaves scale changes to AppKit, avoiding an extra settled geometry commit during screen transitions. Display identity and renderer visibility still update in the screen-change handler.
Validation on pushed head
8c5a1c72be056b42cc59fe54c4d6ce8b7a7f6076(includes main at150ba9f55e):ec6d7cd04ba5fcdedcbc0a60succeeded and published issue-13251-display-session-flicker. Artifact SHA-256:67561a540071634483537ae677e4d6502c2a7603223f84931c9f094c90381255. Bundle name and identifier were verified against the requested tag, and the opener returned HTTP 200./tmp/cmux-debug-issue-13251-display-session-flicker.sockpassed identity/ping, two terminal panes, send/readback, advancing presentation counters, and nonblank IOSurface snapshots. CLI window placement ran on the only available built-in display; this does not prove a cross-display transition.window.displaysnever exposed them. Helpers were removed. Hosted display E2E run36056625035failed screen-capture setup before tests executed. Its retry and the no-recording follow-up36061334701were canceled while queued; no hosted display-test pass is claimed.ORANGE / human dogfood required: connect and disconnect the two external displays while both prepared terminal panes are producing output; verify sessions keep rendering without a flash. The reported macOS 27 flicker has not been reproduced or verified fixed. The dev app remains running for that check. No user-facing strings changed.
Receipts and exact socket-command harnesses are retained under this worktree’s
artifacts/fleet/andartifacts/runtime/, including failed attempts and captured frames.