ci: stop retrying a missing cmux-tui manifest

[teamleaderleo]

Summary

scripts/ci/resolve-cmux-tui-client-commit.sh probed each candidate manifest with curl --retry 5 --retry-delay 3 --retry-all-errors. That flag retries a genuine 404 too, so every unpublished candidate cost about 15 s before the resolver moved on. It happens in every release and nightly fallback, and in the tui-resolution guard leg, which took 81 s on CI (60 s in this one test). macOS admission on PRs waits for that leg.

The probe is now an explicit loop:

• HTTP 404 or 410, or a missing file:// path (curl exit 37), moves on at once.
• DNS, connection, 5xx and 429 failures keep the bounded retry (6 attempts, 3 s apart), so a network blip on a release runner still does not read as a missing manifest.
• Statuses below 400 still count as found, as they did under curl -f.

CMUX_TUI_CLIENT_PROBE_RETRY_SECONDS overrides the retry delay, validated like the existing fetch settings.

Testing

• The first commit adds only the test. Against the old resolver it fails with skipping a missing manifest took 15s; a 404 must not be retried.
• The test also puts a curl shim on PATH that fails twice with exit 6 (DNS) and then runs the real curl, which proves transient failures are still retried and then resolve.
• bash tests/test_ci_resolve_cmux_tui_client_commit.sh: 60.8 s before, 0.9 s after, locally on Linux. shellcheck is clean on both files.
• A live run against files.cmux.com (--max-fallback 3 from a shallow worktree) resolved the published commit 37e93ff, so the HTTPS found path works.

Checklist

• I tested the change locally
• I added or updated tests for behavior changes
• All code review bot comments are resolved

— Copypasta g1 🫧
Run: run_linux_guards_speed_20260924_be91c283

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

The cmux-tui manifest resolver no longer retries missing manifests, cutting the tui-resolution guard leg from ~61 s to under 1 s on CI.

• A HTTP 404/410 or missing file:// path (curl exit 37) moves on to the next candidate immediately; DNS, connection, 5xx, and 429 failures keep the bounded retry (6 attempts, 3 s apart), so a network blip on a release runner does not read as a missing manifest.
• Statuses below 400 still count as found, matching the old curl -f behavior.
• Adds CMUX_TUI_CLIENT_PROBE_RETRY_SECONDS to override the retry delay, validated like the existing fetch settings.
• Adds tests proving a 404 is not retried while transient failures still resolve after retry.

^{Written for commit 0d15abc. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Improved the reliability of resolving the cmux TUI client when temporary network failures interrupt manifest checks. The resolver now retries transient failures before moving on, while missing manifests are skipped promptly so available versions can be found faster.
  • Invalid retry-delay settings are now rejected with a clear usage error rather than proceeding with an unsupported value.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1664a20f-7111-4f08-bce6-f5a3878aaf92

📥 Commits

Reviewing files that changed from the base of the PR and between ac0ceae and 0d15abc.

📒 Files selected for processing (2)

• scripts/ci/resolve-cmux-tui-client-commit.sh
• tests/test_ci_resolve_cmux_tui_client_commit.sh

 ________________________________________________________________________________________________
< Your code and I have a love-hate relationship. I love finding bugs, you hate that I find them. >
 ------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}