Repository navigation
ci: fix three fleet command gaps from the #14159 review - #14164
Merged
Merged
Conversation
Fails on main: a refused organization-variables read discards the repository variables and with them the Xcode pin; the doctor offers no next step for a pilot with an empty cohort; and a refused quarantine on a mini with no runner says the runner is stopped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- read_variables: a refused organization-variables read no longer discards the repository variables, which hold the Xcode pin. - doctor: a pilot with an empty cohort names the pilot command as the next step instead of "nothing". - quarantine/drain: when Glaeda refuses and no runner is configured, the error says so instead of claiming the runner stopped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
enabled auto-merge (squash)
September 24, 2026 06:17
1 task done
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 24, 2026
9567d6e refactor: give About and Licenses windows explicit ownership (manaflow-ai#13148) fae46b6 ci: stop retrying a missing cmux-tui manifest (manaflow-ai#14168) 8421357 Point PR checklist and welcome note at the hidden Review Trigger block (manaflow-ai#14167) b9415db ci: run app-host product consumers on compile admission's pool and Xcode (manaflow-ai#14163) ac0ceae fix(sidebar): order panels without reading split-container geometry (manaflow-ai#13931) 37edc16 ci: judge Web complexity's trusted files in the pull request's merge (manaflow-ai#14018) 679f4e2 ci: leave three-day-old queued ghosts to GitHub instead of retrying them (manaflow-ai#14166) 07a2e22 fix(web): enumerate complexity-gate sources with git ls-files -z (manaflow-ai#13682) c72f659 cloud: share concurrent VM stats reads (manaflow-ai#13327) aa51f16 ci: trim package setup before the macOS compile admission build (manaflow-ai#14160) 82ea1ed ci: land the fleet review fixes manaflow-ai#14159 merged without (manaflow-ai#14165) adddb59 docs: propose routing CI by capability instead of by vendor (manaflow-ai#14010) f862390 ci: fix three fleet command gaps from the manaflow-ai#14159 review (manaflow-ai#14164) 77d56b3 agent-chat: make installed harnesses first-class (manaflow-ai#13347) 7dc57f6 Clarify writing guidance for issue and PR descriptions (manaflow-ai#13275) ccf4963 ci: name the hung test when a Swift package test step stalls (manaflow-ai#14055) 9fca985 ci: guard the fleet routing switch, Xcode pin and quarantine (manaflow-ai#14159) 02972b7 fix: thin around and Developer ID sign the bundled cmux-tui SSH payloads (manaflow-ai#14154) # Conflicts: # .github/workflows/app-host-test-rerun.yml # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/test-ios.yml # .github/workflows/web-complexity-trusted.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeRabbit posted these on #14159 shortly before it merged. Each fix follows a commit with a test that fails on
main.read_variablesread the organization variables first, and aFailurethere skipped the repository variables. The Xcode pin is a repository variable, so the command fell back to the hardcoded path. The org read is now optional; the repository read is still required.scripts/persistent-compile pilot <your PR number>.python3 -m unittest tests.test_ci_persistent_compile_fleet: 67 tests pass. The fullci-guards.ymlsweep shows only the known local failures from missing submodules and CI-only environment variables.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes three fleet command gaps from the #14159 review, each covered by a test that fails on
main.scripts/persistent-compile pilot <your PR number>for a pilot with an empty cohort instead of "nothing".python3 -m unittest tests.test_ci_persistent_compile_fleet: 67 tests pass.Written for commit acd537a. Summary will update on new commits.