Repository navigation
ci: register new Python tests automatically at commit time - #14153
Merged
Merged
Conversation
A new tests/test_*.py fails preflight until someone pastes a [[test]] block into tests/test-execution.toml, even when ci-guards.yml already runs it and the validator has already worked out the lane. validate_test_execution_registry.py --write now appends that block for every unregistered test a workflow runs, and the pre-commit hook runs it whenever a commit stages a test or workflow and stages the result. A test no workflow runs is left for a person to place; CI still fails on it with the hint, which now mentions --write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSxoKWiT1D35DDmEYxk59f
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task done
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 24, 2026
82543c5 ci: stop restoring the test compilation cache in compile admission (manaflow-ai#14161) 5da27d6 ci: route the persistent compile fleet command as control plane only (manaflow-ai#14157) b2ec91b ci: bring a Mac mini onto the compile fleet with one command (manaflow-ai#14148) 1f39b14 ci: cancel orphaned runs from the queue janitor (manaflow-ai#14156) 455179c ci: register new Python tests automatically at commit time (manaflow-ai#14153) e6ca0a2 fix(ios): mirror the signed-in account so pushes decrypt after launch (manaflow-ai#14110) fd028fe ci: run forks' own macOS CI on GitHub-hosted macos-26 (manaflow-ai#14151) f70a62b ci: cancel stale pull request runs on every janitor sweep (manaflow-ai#14144) e2fd37e ci: default the seed adoption kill switch to on (manaflow-ai#14150) 4926f0f fix: split the SSH session-list merge so it type-checks on slow runners (manaflow-ai#14142) 34d33d2 ci: run R2 cache writers in a main-only ci-cache-writer environment (manaflow-ai#14147) 4b7f66a ci: skip the Mac wrapper and remote-daemon lanes for ci.yml routing edits (manaflow-ai#14145) 4ca24a2 ci: give the DerivedData seeder the R2 public URL (manaflow-ai#14146) # Conflicts: # .github/workflows/app-host-test-rerun.yml # .github/workflows/auth-refresh-tests.yml # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci-queue-janitor.yml # .github/workflows/ci.yml # .github/workflows/cli-pipe-regressions.yml # .github/workflows/cloud-command-deadlines.yml # .github/workflows/cloud-machine-tests.yml # .github/workflows/cloud-task-local-tests.yml # .github/workflows/iroh-v2.yml # .github/workflows/nightly.yml # .github/workflows/relay-tls.yml # .github/workflows/remote-daemon.yml # .github/workflows/seed-derived-data.yml # .github/workflows/terminal-hang-diagnostics.yml # .github/workflows/test-ios.yml
teamleaderleo
added a commit
to teamleaderleo/cmux
that referenced
this pull request
Sep 24, 2026
Main's pre-commit hook now also runs scripts/ci/validate_test_execution_registry.py --write, so the hook installer, the trust note in docs/contributor-verification.md and the dev-workflow skill describe it as more than the pbxproj normalizer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Sep 24, 2026
* Add contributor verification receipts for local and CI checks Adapt the existing docs-auth guard recipe; retain source qualifications and provider outcomes. Refs teamleaderleo/Tact#83. * Test assessed zero-test receipts fail at the CLI boundary * Cover unknown receipt schemas and unavailable Git observations * Share fast CI checks with a focused local preflight command * Clarify verification scope and consolidate contributor guidance * test: reproduce missing focused Swift syntax preflight * feat: catch Swift syntax failures before native iteration * test: cover changed-file and composable Swift selection * feat: discover Swift edits and support composable verification * test: reject private checkout paths in parser receipts * fix: keep parser receipts checkout-relative * docs: connect the verification ladder to automatic preflight * Run shared static checks automatically on pushed commit tips * test: reject implicit candidate code execution during push * fix: remove automatic execution of untrusted push candidates * Make the testing skill start with a task and focused check * Test affected preflight selection and input drift * Select local verification checks from changed inputs Explain selection and skipped checks; use the full recipe for unknown inputs. * Test receipt behavior when Python startup fails * Report missing Python without claiming test execution Clarify trusted-checkout requirements at skill entry points. * Test automatic local verification defaults * Automatically choose local checks and changed Swift inputs Use local remote-default refs, explain fallback, and preserve full static checks in CI. * Describe the pre-commit hook's test registration from #14153 Main's pre-commit hook now also runs scripts/ci/validate_test_execution_registry.py --write, so the hook installer, the trust note in docs/contributor-verification.md and the dev-workflow skill describe it as more than the pbxproj normalizer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A new
tests/test_*.pyfails thepreflightguard until someone pastes a[[test]]block intotests/test-execution.toml. This happens even whenci-guards.ymlalready runs the file and the validator has already worked out the lane. #14148 hit exactly this.After this change, adding a test and its
ci-guards.ymlstep is all a commit needs:python3 scripts/ci/validate_test_execution_registry.py --writeregisters every unregistered test that a workflow already runs, onlinux-guard, then validates as before.scripts/git-hooks/pre-commit, installed by./scripts/setup.sh) runs--writewhenever a commit stages a test or workflow file, and stages the updated registry. It leaves the registry alone if the registry has unstaged edits. It never blocks a commit, because CI still validates.--write.Testing
python3 tests/test_ci_test_execution_registry.pypasses. Two new tests check that--write:ci-guards.ymlstep in a throwaway clone with the hook installed. The hook printedregistered new tests in tests/test-execution.toml, the commit included the registry entry, andvalidate_test_execution_registry.py --base-sha HEAD~1passed.validate_test_execution_registry.py --writeon currentmainchanges nothing, and the registry is valid.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01RSxoKWiT1D35DDmEYxk59f
Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Automates registration of new Python tests in
tests/test-execution.tomlso adding a test and itsci-guards.ymlstep is all a commit needs, instead of the preflight guard failing until someone pastes in a[[test]]block.validate_test_execution_registry.py --writeregisters every unregistered test a workflow already runs, then validates as before.--writewhen a commit stages test or workflow files and stages the updated registry; it skips if the registry has unstaged edits and never blocks a commit.--write.Written for commit d0a766c. Summary will update on new commits.
Summary by CodeRabbit