Repository navigation
ci: give the DerivedData seeder the R2 public URL - #14146
Conversation
r2-cache.sh restores through CI_CACHE_R2_PUBLIC_URL and refuses to save without it. seed-derived-data.yml never sets it, so this fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012pAcDGiHaibDaMU4CPvXAP
seed-derived-data.yml passed the bucket credentials to its save step but never set CI_CACHE_R2_PUBLIC_URL, which r2-cache.sh needs to restore and refuses to save without. Every seed save warned and wrote nothing, and every "Adopt the newest seed" missed. Set it at workflow level with the same value ci-macos.yml and nightly.yml use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012pAcDGiHaibDaMU4CPvXAP
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe seeder workflow now sets ChangesSeeder cache URL
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The seeder now has the public cache URL needed for its cache workflow, with parity checked against admission. No merge-blocking issue is identified. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Two more things block the seed after this PR. Both were confirmed from job data on 2026-09-24. 1. The admission side never runs. In
Both runs executed the compile step, so 2. Every seed build since #14081 failed or was cancelled. The builds ran on
— unregistered (Claude Code session, run for @teamleaderleo) Generated by Claude Code |
|
Follow-up to my earlier comment: I found the admission-side cause. An unset repository variable evaluates to Generated by Claude Code |
82543c5 ci: stop restoring the test compilation cache in compile admission (manaflow-ai#14161) 5da27d6 ci: route the persistent compile fleet command as control plane only (manaflow-ai#14157) b2ec91b ci: bring a Mac mini onto the compile fleet with one command (manaflow-ai#14148) 1f39b14 ci: cancel orphaned runs from the queue janitor (manaflow-ai#14156) 455179c ci: register new Python tests automatically at commit time (manaflow-ai#14153) e6ca0a2 fix(ios): mirror the signed-in account so pushes decrypt after launch (manaflow-ai#14110) fd028fe ci: run forks' own macOS CI on GitHub-hosted macos-26 (manaflow-ai#14151) f70a62b ci: cancel stale pull request runs on every janitor sweep (manaflow-ai#14144) e2fd37e ci: default the seed adoption kill switch to on (manaflow-ai#14150) 4926f0f fix: split the SSH session-list merge so it type-checks on slow runners (manaflow-ai#14142) 34d33d2 ci: run R2 cache writers in a main-only ci-cache-writer environment (manaflow-ai#14147) 4b7f66a ci: skip the Mac wrapper and remote-daemon lanes for ci.yml routing edits (manaflow-ai#14145) 4ca24a2 ci: give the DerivedData seeder the R2 public URL (manaflow-ai#14146) # Conflicts: # .github/workflows/app-host-test-rerun.yml # .github/workflows/auth-refresh-tests.yml # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci-queue-janitor.yml # .github/workflows/ci.yml # .github/workflows/cli-pipe-regressions.yml # .github/workflows/cloud-command-deadlines.yml # .github/workflows/cloud-machine-tests.yml # .github/workflows/cloud-task-local-tests.yml # .github/workflows/iroh-v2.yml # .github/workflows/nightly.yml # .github/workflows/relay-tls.yml # .github/workflows/remote-daemon.yml # .github/workflows/seed-derived-data.yml # .github/workflows/terminal-hang-diagnostics.yml # .github/workflows/test-ios.yml
seed-derived-data.yml(#14081) passes the R2 bucket credentials to its save step but never setsCI_CACHE_R2_PUBLIC_URL.scripts/ci/r2-cache.shrestores through that URL and itssavereturns early with "CI_CACHE_R2_PUBLIC_URL is not set; nothing saved" when it is missing. So every main-push seed builds, then saves nothing, and its "Adopt the newest seed" step always misses. Pull request admission never gets a seed from this workflow.This sets it at workflow level with the same value
ci-macos.yml,ci.ymlandnightly.ymluse.The first commit adds a test that the seeder's
CI_CACHE_R2_PUBLIC_URLequals admission's, and fails. The second adds the env and passes.tests/test_seed_derived_data.pypasses (9) andactionlintis clean. Found by reading the code; not yet confirmed against a seed run's log.Split out of #14143 so it can land on its own.
🤖 Generated with Claude Code
https://claude.ai/code/session_012pAcDGiHaibDaMU4CPvXAP
Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the DerivedData seeder so it actually saves seeds to R2: it passed bucket credentials but never set
CI_CACHE_R2_PUBLIC_URL, sor2-cache.shrefused to save and every "Adopt the newest seed" step missed. Sets the variable at workflow level with the same value admission uses, and adds a test that the seeder's value matches.Written for commit 27fa348. Summary will update on new commits.
Summary by CodeRabbit