Skip to content

ci: reuse the headless cmux-tui build in SDK conformance - #14108

Merged
teamleaderleo merged 1 commit into
mainfrom
ci/tui-sdks-headless-cache
Sep 24, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
ci/tui-sdks-headless-cache

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

seven-language live conformance in cmux-tui-sdks.yml takes about 7 minutes. About 5 of those go to "Build exact headless cmux-tui", which compiles cmux-tui from scratch every time. On the revert in #14106 the build started at 02:19:39 and finished at 02:24:35. The tests themselves took 66 s.

That run changed nothing under cmux-tui/. It started only because the workflow's push path filter lists about 25 workflow files, and #14101 and its revert each edited one comment line in cmux-tui-artifacts.yml.

Resulting behavior

The job keys the built binary on exactly what the build reads:

  • the git tree of cmux-tui/
  • the ghostty submodule commit
  • zig 0.16.0 and the runner OS and arch

The Rust toolchain is pinned inside the tree by rust-toolchain.toml. When the key hits, the compile is skipped and the job goes straight to the conformance run. Pull requests only restore. Pushes to main save, which matches tests/test_ci_pull_request_caches_are_read_only.py.

Keying on the tree hash is conservative: an edit anywhere under cmux-tui/, bindings included, misses and compiles as it does today.

Testing

  • actionlint is clean on cmux-tui-sdks.yml.
  • tests/test_tui_publish_workflow_security.py and tests/test_ci_pull_request_caches_are_read_only.py pass.
  • Not yet verified: the first push to main after this lands should save the cache, and the next unchanged-tree run should skip the build. I'll post both run links here.

— Camera g1 🛠️

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Caches the headless cmux-tui build in the SDK conformance job so unchanged trees skip the ~5-minute compile.

  • The key is the cmux-tui/ tree hash plus the ghostty submodule commit, the pinned zig and Rust toolchains, and the runner OS and arch; any edit under cmux-tui/ misses and compiles as today.
  • Pull requests only restore; pushes to main save, so the first push after this lands populates the cache.

Written for commit 3a382ca. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Improved the efficiency of automated conformance checks by reusing cached builds. This may reduce build time without changing the app’s features or behavior.

The seven-language conformance job spends about 5 of its 7 minutes
compiling cmux-tui from scratch, including on runs where nothing under
cmux-tui changed: any edit to one of the ~25 workflows in the path filter
starts it. The build reads only the cmux-tui tree, the ghostty submodule
and the pinned zig and Rust toolchains, so key the binary on exactly
those and skip the compile on a hit. Pull requests only restore; pushes
to main save.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: bd67eb81-ae84-4ae0-8d29-0e9c8be79893

📥 Commits

Reviewing files that changed from the base of the PR and between 83641ea and 3a382ca.

📒 Files selected for processing (1)
  • .github/workflows/cmux-tui-sdks.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The conformance job now caches the compiled headless cmux-tui binary. It keys the cache by runner OS and architecture, Zig version, and the cmux-tui and ghostty git hashes. It saves cache entries only on push events.

Changes

Headless Build Cache

Layer / File(s) Summary
Restore, build, and save the binary
.github/workflows/cmux-tui-sdks.yml
The workflow restores the binary using the computed cache key. It skips the build on a cache hit and saves the build on push events when the cache misses. Pull-request events do not save cache entries.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 3a382

The cache can reuse the binary across commits without affecting the conformance behavior checked by this job. No merge-blocking issue remains.

🚥 Pre-merge checks | ✅ 25
✅ Passed checks (25 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: reusing the headless cmux-tui build in SDK conformance CI.
Description check ✅ Passed The description explains the problem, resulting behavior, cache key, restore/save policy, and testing status. It covers the required summary and testing content. The demo video is not applicable to th…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. It adds cache key, restore, conditional build, and save steps for the headless cmux-tui binary. It does not change Cloud te…
Cmux Swift Actor Isolation ✅ Passed The pull request changes only .github/workflows/cmux-tui-sdks.yml. The diff adds GitHub Actions cache key, restore, build condition, and save steps. It contains no Swift files or Swift production co…
Cmux Swift Blocking Runtime ✅ Passed The pull request changes only .github/workflows/cmux-tui-sdks.yml. It adds GitHub Actions cache restore/save steps and a conditional build. It contains no Swift changes and introduces no blocking or…
Cmux Browser Automation Off-Main ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. It adds cache key, restore, conditional build, and save steps for the headless cmux-tui binary. It does not change browser …
Cmux Expensive Synchronous Load ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. It adds GitHub Actions cache key, restore, build gating, and save steps. It does not contain production Swift changes or add …
Cmux Cache Substitution Correctness ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. The diff adds CI cache restore/build/save steps and changes no Swift, TypeScript, or JavaScript production code. Therefore, i…
Cmux No Hacky Sleeps ✅ Passed PASS. The PR changes only .github/workflows/cmux-tui-sdks.yml. The rule explicitly excludes GitHub Actions workflow YAML. The added steps compute a cache key, restore the binary, conditionally build…
Cmux Algorithmic Complexity ✅ Passed The PR changes only .github/workflows/cmux-tui-sdks.yml. The added shell code performs two fixed git rev-parse lookups and constructs a cache key. It adds no loops, collection scans, sorting, filt…
Cmux Swift Concurrency ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. The authoritative diff contains no Swift files or Swift code, so the cmux Swift concurrency check is not applicable.
Cmux Swift @Concurrent ✅ Passed The pull request changes only .github/workflows/cmux-tui-sdks.yml. It introduces no Swift files, Swift functions, call sites, or concurrency annotations. The cmux Swift @concurrent`` check is theref…
Cmux Swift Package Boundaries ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. The authoritative diff contains no Swift files or production Swift changes, so the Swift package boundary rule is not applica…
Cmux Swiftpm Lockfiles ✅ Passed PASS. The authoritative PR diff changes only .github/workflows/cmux-tui-sdks.yml. It changes no Package.swift, Package.resolved, .gitignore, or Xcode project file, and it introduces no SwiftPM…
Cmux Swift Logging ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. It adds GitHub Actions cache key, restore, build condition, and save steps. The diff contains no Swift or app/runtime logging…
Cmux User-Facing Error Privacy ✅ Passed PASS: The diff only changes .github/workflows/cmux-tui-sdks.yml. It adds internal CI cache-key, restore, build, and save steps. The workflow runs on GitHub Actions push, pull-request, and manual eve…
Cmux Full Internationalization ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. The added cache key, cache restore/save steps, conditions, and comments are CI configuration and operational documentation. T…
Cmux Swiftui State Layout ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. The diff adds GitHub Actions cache key, restore, build condition, and save steps. It contains no Swift or SwiftUI code, so it…
Cmux Architecture Rethink ✅ Passed PASS. The pull request changes only .github/workflows/cmux-tui-sdks.yml. It adds cache key, restore, conditional build, and save steps. It contains no Swift architecture changes and does not introdu…
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed The pull request changes only .github/workflows/cmux-tui-sdks.yml. The authoritative diff contains no Swift changes and no cmux-owned window code. The auxiliary-window close-shortcut check is theref…
Cmux Source Artifacts ✅ Passed PASS. The only changed path is .github/workflows/cmux-tui-sdks.yml, which is a hand-written CI configuration. The diff adds cache restore/save steps for a build artifact used by SDK conformance, but…
Cmux No Test Or Debug Seam In Production Source ✅ Passed PASS: The pull request changes only .github/workflows/cmux-tui-sdks.yml. It does not change any Swift file under a production Sources/ path, so it cannot introduce a test or debug seam in producti…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit d49a1b1 into main Sep 24, 2026
69 of 70 checks passed
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 24, 2026
5b646b7 ci: apply the queue janitor threshold per runner pool (manaflow-ai#14131)
d49a1b1 ci: reuse the headless cmux-tui build in SDK conformance (manaflow-ai#14108)
ba85a1b ci: key reload-build caches on the commit and fall back across branches (manaflow-ai#14099)
27fb3bf ci: hand focused test-macos-suite dispatches to run-e2e.sh (manaflow-ai#14075)
d18c1b9 ci: let a failed compile admission mark a run doomed for the queue janitor (manaflow-ai#14129)
dfdce2c ci: bind pull request product reuse to the merge it compiled (manaflow-ai#14080)
afacff3 ci: sparse-checkout the Claude wrapper regression job (manaflow-ai#14088)
35a6bb1 ci: stop pinning remote-daemon macOS tests to the macOS 26 pool (manaflow-ai#14128)
1ba6d77 ci: run macOS jobs on GitHub-hosted runners alongside Blacksmith (manaflow-ai#14097)
587de87 Import CmuxWorkspaces where CodexTurnRestoreIntentPolicy names its liveness type (manaflow-ai#14123)

# Conflicts:
#	.github/workflows/ci-guards.yml
#	.github/workflows/ci-macos.yml
#	.github/workflows/ci-queue-janitor.yml
#	.github/workflows/ci.yml
#	.github/workflows/cmux-tui-sdks.yml
#	.github/workflows/reload-build.yml
#	.github/workflows/remote-daemon.yml
#	.github/workflows/test-macos-suite.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant