Repository navigation
ci: remove the Tart VM runner choices - #14101
Conversation
Nobody runs the Tart VM pool any more, yet test-e2e.yml still offered tart-canary, tart-dual and tart-small, and test-ios.yml offered tart-ios. Picking one queued for a runner that never comes. A tart-canary run was also mistaken for evidence about the default pool: its Xcode and paths differ, so it could never adopt main's DerivedData. Remove the choices, their identity-check steps, the actionlint label and the dispatcher's allowlist entries. The self-hosted guard stops requiring the choices and stops exempting them, so any tart-* label in a runner position now fails it. The runner docs drop the Tart pool and its restore recipe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Started: an independent review of ba8eb90 is running (leftover references, YAML validity, tests that slice the guard or count steps). I'll post the result and any fixes here. — Camera g1 🛠️ |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review done on ba8eb90. No blocking findings.
One cosmetic finding: four edited doc paragraphs were left unwrapped. a4f8ca0 rewraps them to about 80 columns. That commit touches prose only. Enabling auto-merge. — Camera g1 🛠️ |
This reverts commit 229edc5. The Tart pool is live. When #14101 merged, test-e2e.yml was running on tart-canary (runner tart-cmux-aws-m4pro-4-1) and test-ios.yml on tart-ios (tart-cmux-aws-m4pro-6-2). Both jobs started within 2 s of queueing, while 205 jobs waited for blacksmith-6vcpu-macos-26. #14101 took those choices away from the people using them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This was wrong. The Tart pool is live: — Camera g1 🛠️ |
This reverts commit 229edc5. The Tart pool is live. When #14101 merged, test-e2e.yml was running on tart-canary (runner tart-cmux-aws-m4pro-4-1) and test-ios.yml on tart-ios (tart-cmux-aws-m4pro-6-2). Both jobs started within 2 s of queueing, while 205 jobs waited for blacksmith-6vcpu-macos-26. #14101 took those choices away from the people using them. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Nobody runs the Tart VM pool any more.
test-e2e.ymlstill offeredtart-canary,tart-dualandtart-smallin its runner dropdown, andtest-ios.ymlofferedtart-ios. Picking one of them queues for a runner that never arrives. Atart-canaryrun was also mistaken for evidence about the default pool in #14082: its Xcode version and paths differ, so it could never adopt main's DerivedData.test-e2e.yml, three intest-ios.yml).tart-canaryfrom.github/actionlint.yamland from the focused-test dispatcher'sRUNNERSlist.tests/test_run_e2e.pyalready asserts that this list matches the workflow's choices.tests/test_ci_self_hosted_guard.shno longer requires the Tart choices and no longer exempts them.check_ios_tart_canaryis gone. Anytart-*label in a runner position now fails the fleet guard, whose self-test already covers those labels.docs/ci-runners.mdanddocs/ci/mac-fleet.mddrop the Tart pool section, the "restore the self-hosted pool" recipe, and the remaining pointers to it.Only comments that record past behaviour still mention Tart (
ci-macos.ymlon node,setup-cmux-tui-rust, the recorder note intest-e2e.yml).Testing
ci-guards.yml, parsed from the YAML (133 commands). All pass exceptbun test/claude-environment.test.ts, which also fails on main (module path).tests/test_ci_e2e_compilation_cache.pysliced the guard script atcheck_ios_tart_canary(). It now slices at the next function, and the test passes.test-ios.ymlis also present on main.— Camera g1 🛠️
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes the unused Tart VM pool from CI. The runner dropdowns in
test-e2e.ymlandtest-ios.ymlstill offeredtart-*choices that queued for runners nobody operates, so selecting one never ran. Atart-canaryrun was also mistaken for evidence about the default pool because its Xcode and paths differ.tart-canaryfrom.github/actionlint.yamland the focused-test dispatcher'sRUNNERSlist.tart-*label in a runner position now fails it.tests/test_ci_e2e_compilation_cache.pyandtests/test_run_e2e.pyto slice and reference non-Tart runners.docs/ci-runners.mdanddocs/ci/mac-fleet.md.cmux-tui-artifacts.ymlcomment to reference a cloud label instead of a Tart one.Written for commit a4f8ca0. Summary will update on new commits.