Skip to content

Add workspace description text color setting - #13605

Closed
teamleaderleo wants to merge 2 commits into
mainfrom
codex/issue-13438-workspace-description-color
Closed

teamleaderleo wants to merge 2 commits into
mainfrom
codex/issue-13438-workspace-description-color

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Closes #13438.

  • add sidebar.workspaceDescriptionColor as a nullable #RRGGBB override; unset/null keeps the existing theme-derived description color
  • wire the value through cmux.json parsing, the settings catalog/snapshot, Sidebar settings UI + search, schema/template/generated validator, and settings docs
  • apply the override in both SwiftUI and AppKit sidebar rows, including Markdown link text, while leaving notification preview styling unchanged

Example:

{
  "sidebar": {
    "workspaceDescriptionColor": "#A6E3A1"
  }
}

Regression coverage

The PR keeps the repository's red/green layout as two commits:

  1. test: cover workspace description sidebar color
  2. feat: add workspace description sidebar color

Coverage includes:

  • AppKit row behavior for active and inactive workspaces
  • real cmux.json parsing and hex normalization
  • SwiftUI Markdown/link coloring
  • settings-search row anchoring and schema/supported-path consistency through existing CI guards

The test-only regression was verified red before the implementation: both active/inactive cases rendered the prior secondary color instead of #A6E3A1.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

#13597 already contains the full implementation for #13438 across settings, schema/config, SwiftUI + AppKit rendering, markdown link color, and regression coverage. This branch currently contains only the test-first AppKit regression.

Please consolidate rather than continue a second implementation track: ensure any useful red-proof assertion here is present in #13597, then treat #13597 as the canonical PR for the issue and close/supersede this branch.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo force-pushed the codex/issue-13438-workspace-description-color branch from c7bb8c2 to 0be80e8 Compare September 22, 2026 06:01
@teamleaderleo
teamleaderleo force-pushed the codex/issue-13438-workspace-description-color branch from 0be80e8 to bb5589f Compare September 22, 2026 06:04
@teamleaderleo
teamleaderleo force-pushed the codex/issue-13438-workspace-description-color branch from bb5589f to 184ff40 Compare September 22, 2026 06:05

Copy link
Copy Markdown
Collaborator Author

Superseded by #13597. The canonical PR already carries the AppKit regression for the workspace-description color override, plus settings-file parsing and SwiftUI/markdown coverage, so there is no useful coverage left unique to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting for workspace description text color in sidebar

1 participant