Repository navigation
Add workspace description text color setting - #13605
teamleaderleo wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
#13597 already contains the full implementation for #13438 across settings, schema/config, SwiftUI + AppKit rendering, markdown link color, and regression coverage. This branch currently contains only the test-first AppKit regression. Please consolidate rather than continue a second implementation track: ensure any useful red-proof assertion here is present in #13597, then treat #13597 as the canonical PR for the issue and close/supersede this branch. |
|
All contributors have signed the CLA ✍️ ✅ |
c7bb8c2 to
0be80e8
Compare
0be80e8 to
bb5589f
Compare
bb5589f to
184ff40
Compare
|
Superseded by #13597. The canonical PR already carries the AppKit regression for the workspace-description color override, plus settings-file parsing and SwiftUI/markdown coverage, so there is no useful coverage left unique to this branch. |
Summary
Closes #13438.
sidebar.workspaceDescriptionColoras a nullable#RRGGBBoverride; unset/null keeps the existing theme-derived description colorExample:
{ "sidebar": { "workspaceDescriptionColor": "#A6E3A1" } }Regression coverage
The PR keeps the repository's red/green layout as two commits:
test: cover workspace description sidebar colorfeat: add workspace description sidebar colorCoverage includes:
The test-only regression was verified red before the implementation: both active/inactive cases rendered the prior secondary color instead of
#A6E3A1.