Skip to content

Add configurable sidebar workspace description color - #13597

Merged
teamleaderleo merged 2 commits into
mainfrom
issue-13438-workspace-description-color
Sep 22, 2026
Merged

teamleaderleo merged 2 commits into
mainfrom
issue-13438-workspace-description-color

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add sidebar.workspaceDescriptionColor as a nullable hex color setting with theme-derived behavior as the default
  • expose the color in Settings and apply it in both SwiftUI and AppKit sidebar workspace-description renderers, including markdown links
  • wire config parsing, supported-path/schema/template docs, and settings search metadata
  • add parser and renderer regression coverage

Testing

  • targeted parser/render/settings-path coverage added; GitHub Actions will exercise the PR merge ref against current main

Closes #13438


Summary by cubic

Adds a sidebar.workspaceDescriptionColor setting that overrides the sidebar workspace description text color. When unset, the color continues to follow the current theme as before.

  • New setting accepts a nullable hex color and is exposed in Settings > Sidebar with a reset button.
  • Applies to both SwiftUI and AppKit sidebar renderers, including markdown link colors.
  • Wires the setting through config file parsing, supported paths, schema, templates, and settings search.
  • Adds parser and renderer regression tests.

Written for commit e185660. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e8534208-b41a-4dee-999b-6fa15487ccb5

📥 Commits

Reviewing files that changed from the base of the PR and between ea17450 and e185660.

⛔ Files ignored due to path filters (1)
  • Packages/macOS/CmuxFoundation/Sources/CmuxFoundation/ConfigValidation/CmuxConfigSchema.generated.swift is excluded by !**/*.generated.*
📒 Files selected for processing (18)
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Keys/SidebarCatalogSection.swift
  • Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Navigation/CuratedSettingEntry+Default.swift
  • Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/SidebarSection.swift
  • Packages/macOS/CmuxSettingsUI/Tests/CmuxSettingsUITests/SettingsRowAnchorResolutionTests.swift
  • Sources/CmuxSettingsFileStore+SupportedPaths.swift
  • Sources/ContentView.swift
  • Sources/KeyboardShortcutSettingsFileStore+Template.swift
  • Sources/KeyboardShortcutSettingsFileStore.swift
  • Sources/SettingsSearchAliases.swift
  • Sources/SettingsSearchIndex.swift
  • Sources/Sidebar/AppKitList/Cells/SidebarWorkspaceRowCellView.swift
  • Sources/Sidebar/SidebarWorkspaceDescriptionText.swift
  • Sources/SidebarTabItemSettingsSnapshot.swift
  • cmuxTests/SidebarAppKitRowCellTests.swift
  • cmuxTests/SidebarMarkdownRendererTests.swift
  • cmuxTests/WorkspaceUnitTests.swift
  • skills/cmux-settings/references/all-keys.md
  • web/data/cmux.schema.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo force-pushed the issue-13438-workspace-description-color branch from d91caf8 to 66f70c5 Compare September 22, 2026 06:28
@teamleaderleo
teamleaderleo marked this pull request as ready for review September 22, 2026 06:28
@teamleaderleo
teamleaderleo enabled auto-merge (squash) September 22, 2026 09:34

Copy link
Copy Markdown
Collaborator Author

CI note: the only failing job is guards / workflow-guard-tests / preflight, exiting with printf: write error: Broken pipe in tests/test_ci_self_hosted_guard.sh. The same guard code is on main; the repo-level SIGPIPE fix is isolated in #13630, whose CI is green. The #13597 compile/static/sidebar lanes themselves passed.

@teamleaderleo
teamleaderleo merged commit 400d3c6 into main Sep 22, 2026
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting for workspace description text color in sidebar

1 participant