Skip to content

Delete the legacy whole-tree macOS fingerprint #13464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 15 commits into from
Sep 21, 2026
Merged

Delete the legacy whole-tree macOS fingerprint #13464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6efd1ad
test: remove legacy build fingerprint coverage
teamleaderleo Sep 21, 2026
9e31b6f
ci: delete legacy whole-tree build fingerprint
teamleaderleo Sep 21, 2026
01affd0
ci: make product recipe projection fail closed
teamleaderleo Sep 21, 2026
23f3caf
test: fail closed on unclassified product steps
teamleaderleo Sep 21, 2026
0a4f9cc
Merge admission skip stack into fingerprint cleanup
teamleaderleo Sep 21, 2026
54bea8c
ci: scope product recipe parser to workflow steps
teamleaderleo Sep 21, 2026
de4313b
Merge recipe parser fix into fingerprint cleanup stack
teamleaderleo Sep 21, 2026
8e5e46a
ci: classify Ghostty selection as product input
teamleaderleo Sep 21, 2026
e396377
test: pin Ghostty revision selection in product recipe
teamleaderleo Sep 21, 2026
5a97e72
Merge final admission stack into fingerprint cleanup
teamleaderleo Sep 21, 2026
3f4df5e
test: scope recipe mutations to admission job
teamleaderleo Sep 21, 2026
6f5da54
Merge scoped recipe tests into fingerprint cleanup
teamleaderleo Sep 21, 2026
fd9ab88
ci: make job-level product controls fail closed
teamleaderleo Sep 21, 2026
69b049a
test: cover job-level product controls
teamleaderleo Sep 21, 2026
af14cbe
Merge job-level product identity hardening into cleanup stack
teamleaderleo Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions scripts/ci/build_input_fingerprint.py
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions tests/test_ci_change_areas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,25 +1360,6 @@ def gate(**kwargs) -> int:
).returncode == 1


def test_build_input_fingerprint_ignores_only_what_the_build_cannot_read() -> None:
sys.path.insert(0, str(ROOT / "scripts/ci"))
from build_input_fingerprint import fingerprint, reaches_the_build

def tree(**files: str) -> list[str]:
return [f"100644 blob {object_id}\t{path}" for path, object_id in files.items()]

base = tree(**{"Sources/App.swift": "a1", "tests/test_x.py": "b1", "docs/x.md": "c1", ".github/workflows/nightly.yml": "d1"})
same_build = tree(**{"Sources/App.swift": "a1", "tests/test_x.py": "b2", "docs/x.md": "c2", ".github/workflows/nightly.yml": "d2", "web/app/page.tsx": "e1"})
assert fingerprint(base, ["xcode=1"]) == fingerprint(same_build, ["xcode=1"])
assert fingerprint(base, ["xcode=1"]) != fingerprint(base, ["xcode=2"])
for path in ("Sources/App.swift", "Packages/macOS/CmuxCore/Package.swift", "cmuxTests/T.swift", "cmux.xcodeproj/project.pbxproj",
"scripts/build-ghostty-cli-helper.sh", "ghostty", ".github/workflows/ci.yml", ".xcode-version", "unknown/new-dir/file"):
assert reaches_the_build(path), path
assert fingerprint(base, []) != fingerprint(base + tree(**{path: "z9"}), []), path
for path in ("tests/test_ci_change_areas.py", ".github/workflows/nightly.yml", "docs/a.md", "web/app/page.tsx", "README.md", "CLAUDE.md"):
assert not reaches_the_build(path), path


def admission_api(runs: list[dict], artifacts: dict[int, list[str]], jobs: dict[int, list[dict]], branch: str = "feature"):
"""Fake GitHub API: `artifacts` lists the artifact names each run holds."""
from urllib.parse import parse_qs, urlsplit
Expand Down
Loading