Delete the legacy whole-tree macOS fingerprint by teamleaderleo · Pull Request #13464 · manaflow-ai/cmux

teamleaderleo · 2026-09-21T21:26:04Z

Summary

Delete scripts/ci/build_input_fingerprint.py after #13463 moves the earlier-run shortcut onto the product identity introduced by #13462.

The old helper intentionally included .github/workflows/ci.yml and broad macOS-relevant paths. That was useful as a conservative stopgap, but it encodes the exact admission/product conflation this stack removes.

This PR only removes the now-dead helper and its dedicated test. It leaves one definition of compiled-product identity: product_input_identity.py.

Stacked on #13463.

Related: #13095, #13462, #13463.

Summary by cubic

Deletes the legacy whole-tree macOS build fingerprint, leaving a single fail-closed product identity so unclassified workflow steps now invalidate product reuse instead of being ignored.

Removes scripts/ci/build_input_fingerprint.py and its dedicated test; product_input_identity.py is now the sole definition of compiled-product identity.
Flips the recipe projection from an allowlist of product steps to a denylist of orchestration-only steps, job env keys, and job-level controls; any new or unknown item breaks reuse until its role is reviewed.
Scopes the recipe projection parser to workflow steps so orchestration-only steps are recognized without being confused with product steps.
Classifies Ghostty selection as a product input and the checkout retry as orchestration-only, with test coverage pinning the Ghostty revision selection.

^{Written for commit af14cbe. Summary will update on new commits.}

Summary by CodeRabbit

Chores
- Removed the build input fingerprinting utility.
- Removed its associated validation test.

coderabbitai · 2026-09-21T21:26:11Z

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 88edc928-1302-4f78-84a2-8362d57c30e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 005b8e5f-f659-46a2-a00b-3feea145391c

📥 Commits

Reviewing files that changed from the base of the PR and between 17e6a0b and 9e31b6f.

📒 Files selected for processing (2)

scripts/ci/build_input_fingerprint.py
tests/test_ci_change_areas.py

💤 Files with no reviewable changes (2)

tests/test_ci_change_areas.py
scripts/ci/build_input_fingerprint.py

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Walkthrough

The PR deletes the build fingerprint script and removes the test that validated its behavior.

Changes

Build fingerprint removal

Layer / File(s)	Summary
Remove fingerprint generation and validation `scripts/ci/build_input_fingerprint.py`, `tests/test_ci_change_areas.py`	The build fingerprint script was deleted. Its test was also removed. The test covered filtering build-relevant paths and Xcode version changes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

🚥 Pre-merge checks | ✅ 24 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains what changed and why, but it omits the required Testing, Demo Video, Review Trigger, and Checklist sections.	Add the required Testing, Demo Video, Review Trigger, and Checklist sections. State how the deletion was tested, provide a video or explain why none is needed, include the review trigger block, and complete the checklist.

✅ Passed checks (24 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: deleting the legacy whole-tree macOS fingerprint.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	PASS: The reviewed range changes only `scripts/ci/build_input_fingerprint.py` and removes its dedicated test. It does not change Cloud terminal creation, persistent `cmux-tui` transport, manual render…
Cmux Swift Actor Isolation	✅ Passed	PASS: The authoritative pull-request diff changes only a Python CI helper and a Python test. It contains no Swift files or Swift actor-isolation changes. The custom check therefore does not apply.
Cmux Swift Blocking Runtime	✅ Passed	PASS: The reviewed range changes only `scripts/ci/build_input_fingerprint.py` and `tests/test_ci_change_areas.py`, both by deletion. It contains no Swift paths and introduces no blocking or timing-bas…
Cmux Browser Automation Off-Main	✅ Passed	PASS: The pull request changes only the legacy Python fingerprint helper and its test. The rule-scoped browser automation files, `Sources/TerminalController.swift` and `ControlCommandExecutionPolicy.s…
Cmux Expensive Synchronous Load	✅ Passed	PASS: The authoritative PR diff changes only `scripts/ci/build_input_fingerprint.py` and `tests/test_ci_change_areas.py`. It contains no Swift changes and adds or moves no synchronous agent-history lo…
Cmux Cache Substitution Correctness	✅ Passed	PASS: The authoritative PR diff changes only two Python files. It deletes the legacy build fingerprint script and its test. It does not change production Swift, TypeScript, or JavaScript code, and it …
Cmux No Hacky Sleeps	✅ Passed	PASS: The authoritative diff contains only deletions in `scripts/ci/build_input_fingerprint.py` and `tests/test_ci_change_areas.py` (0 additions). It introduces no sleep, timer, polling, delay, or wal…
Cmux Algorithmic Complexity	✅ Passed	PASS: The authoritative PR diff contains only deletions: `scripts/ci/build_input_fingerprint.py` and one test block in `tests/test_ci_change_areas.py`. It adds no production Swift, TypeScript, JavaScr…
Cmux Swift Concurrency	✅ Passed	PASS. The authoritative diff changes only two Python files and removes 79 lines. It adds no Swift code or concurrency patterns. The diff contains no new Dispatch, Combine, completion-handler, or fire-…
Cmux Swift `@Concurrent`	✅ Passed	PASS: The authoritative diff changes only two Python files. It deletes `scripts/ci/build_input_fingerprint.py` and removes its Python test; it introduces no Swift changes, `@concurrent` annotations, `…
Cmux Swift Package Boundaries	✅ Passed	PASS: The authoritative pull-request diff changes only `scripts/ci/build_input_fingerprint.py` and `tests/test_ci_change_areas.py`. Both changes are Python deletions. The diff contains no Swift files …
Cmux Swiftpm Lockfiles	✅ Passed	PASS. The authoritative PR diff contains only deletion of `scripts/ci/build_input_fingerprint.py` and its dedicated test. It changes no `Package.swift`, `Package.resolved`, `.gitignore`, workflow, or …
Cmux Swift Logging	✅ Passed	PASS. The authoritative diff changes only two Python files and contains no Swift paths. It deletes the legacy Python helper and its test; no production Swift logging is added or materially changed. Th…
Cmux User-Facing Error Privacy	✅ Passed	PASS. The authoritative diff contains only deletion of a CI helper and deletion of its test; it adds or changes no user-facing error, alert, command output, API body, or recovery copy. The removed scr…
Cmux Full Internationalization	✅ Passed	PASS: The authoritative diff contains only deletion of the operational CI helper and removal of its test coverage. It adds or changes no Swift text, localization catalogs, web UI, metadata, API copy, …
Cmux Swiftui State Layout	✅ Passed	PASS: The pull request changes only two Python files. It deletes the legacy fingerprint helper and its test. The diff adds no Swift or SwiftUI state, layout, store-reference, or render-time mutation p…
Cmux Architecture Rethink	✅ Passed	PASS: The reviewed diff changes only `scripts/ci/build_input_fingerprint.py` and `tests/test_ci_change_areas.py`. It contains no Swift files or added code. The diff only deletes the legacy Python help…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	PASS. The pull request changes only `scripts/ci/build_input_fingerprint.py` and `tests/test_ci_change_areas.py`. It contains no changed Swift files and introduces or modifies no `NSWindow`, `NSPanel`,…
Cmux Source Artifacts	✅ Passed	PASS. The authoritative diff changes only `scripts/ci/build_input_fingerprint.py` by deleting it and removes one dedicated test from `tests/test_ci_change_areas.py`. No local output, generated artifac…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS — The review-scoped diff changes only a Python CI helper and a Python test. It contains no Swift changes and adds no production `Sources` seam, `#if DEBUG` member, or test/debug accessor.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

teamleaderleo · 2026-09-21T21:29:19Z

@coderabbitai review

coderabbitai · 2026-09-21T21:29:25Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cursor · 2026-09-21T21:34:38Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

cursor · 2026-09-21T21:52:59Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

cursor · 2026-09-21T21:53:29Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

cursor · 2026-09-21T21:54:00Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

teamleaderleo added 2 commits September 21, 2026 14:25

test: remove legacy build fingerprint coverage

6efd1ad

ci: delete legacy whole-tree build fingerprint

9e31b6f

teamleaderleo mentioned this pull request Sep 21, 2026

[RFC] CI structure: thin router, reusable platform workflows, merge queue, failure ratchet #13095

Open

teamleaderleo added 5 commits September 21, 2026 14:32

ci: make product recipe projection fail closed

01affd0

test: fail closed on unclassified product steps

23f3caf

Merge admission skip stack into fingerprint cleanup

0a4f9cc

ci: scope product recipe parser to workflow steps

54bea8c

Merge recipe parser fix into fingerprint cleanup stack

de4313b

teamleaderleo added 5 commits September 21, 2026 14:35

ci: classify Ghostty selection as product input

8e5e46a

test: pin Ghostty revision selection in product recipe

e396377

Merge final admission stack into fingerprint cleanup

5a97e72

test: scope recipe mutations to admission job

3f4df5e

Merge scoped recipe tests into fingerprint cleanup

6f5da54

This was referenced Sep 21, 2026

[RFC] Speed program: remove repeated work from Cloud and the build fleet #13325

Open

Route macOS test-product CI helpers to owned lanes #13465

Merged

ci: make job-level product controls fail closed

fd9ab88

test: cover job-level product controls

69b049a

Merge job-level product identity hardening into cleanup stack

af14cbe

teamleaderleo merged commit def077d into codex/product-admission-skip Sep 21, 2026
46 checks passed

Navigation Menu

Repository navigation

Delete the legacy whole-tree macOS fingerprint - #13464

Delete the legacy whole-tree macOS fingerprint#13464
teamleaderleo merged 15 commits into
codex/product-admission-skipfrom
codex/delete-legacy-build-fingerprint

teamleaderleo commented Sep 21, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

teamleaderleo commented Sep 21, 2026

Uh oh!

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Sep 21, 2026

Uh oh!

cursor Bot commented Sep 21, 2026

Uh oh!

cursor Bot commented Sep 21, 2026

Uh oh!

cursor Bot commented Sep 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Sep 21, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by cubic

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

teamleaderleo commented Sep 21, 2026

Uh oh!

coderabbitai Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Sep 21, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

cursor Bot commented Sep 21, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

cursor Bot commented Sep 21, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

cursor Bot commented Sep 21, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Sep 21, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading

coderabbitai Bot commented Sep 21, 2026 •

edited

Loading