Fix stale renderer callback fixture calls on main

[teamleaderleo]

Summary

Current main no longer compiles CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift: PresentedSurfaceFixture now installs the native renderer callback lifecycle itself, but a later merge reintroduced three calls to the removed installRendererCallbacks: initializer.

This restores the fixture usage introduced by the native-callback alignment work: all three callback tests construct PresentedSurfaceFixture() directly and continue exercising the C callback boundary through the fixture-installed callbacks.

Evidence

Recent unrelated PRs fail swift-package-tests with extra argument 'installRendererCallbacks' in call, followed by cascading renderHealth inference errors. The fixture definition on current main has only init(windowVisibleAtCreation:) and already calls makeRendererCallbackContextForTesting plus registerRendererCallbacksForTesting.

This is test-only and intentionally narrow.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Fixes the swift-package-tests build failure by updating three renderer callback tests to use the current PresentedSurfaceFixture() initializer.

PresentedSurfaceFixture now installs the renderer callback lifecycle itself, so the removed installRendererCallbacks: argument was breaking compilation on main. The tests continue exercising the C callback boundary through the fixture-installed callbacks; this is test-only and doesn't change runtime behavior.

^{Written for commit 7c51235. Summary will update on new commits.}

Summary by CodeRabbit

• Tests
  • Updated terminal rendering tests to use the standard callback configuration while preserving coverage for presentation acknowledgment, failure recovery, and shell-exit behavior across renderer rebuilds.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c96ee6d1-d996-4c53-bf1b-349bd543081a

📥 Commits

Reviewing files that changed from the base of the PR and between b96f70b and 7c51235.

📒 Files selected for processing (1)

• Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift

Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The three renderer callback tests now use PresentedSurfaceFixture() with default callback installation. The tests retain coverage for presentation acknowledgment, renderer failure recovery, and shell-exit health across renderer rebuilds.

Changes

Renderer callback test fixtures

Layer / File(s)	Summary
Use default callback installation Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift	The three tests use the fixture’s default renderer callback installation instead of disabling callbacks explicitly.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: austinywang

🚥 Pre-merge checks | ✅ 24 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (24 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: replacing stale renderer callback fixture calls on main. It is concise and specific.
Description check	✅ Passed	The description provides a clear summary, explains the compilation failure, identifies the affected tests, and states the scope. It does not include a dedicated Testing section or completed checklist,…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	PASS. The pull request changes only three test fixture initializers in TerminalSurfaceRendererCallbackTests.swift. The diff introduces no Cloud terminal creation, cmux-tui transport, session, atta…
Cmux Swift Actor Isolation	✅ Passed	PASS. The review-scoped diff changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It replaces three test fixture calls and introduces no produ…
Cmux Swift Blocking Runtime	✅ Passed	PASS. The review range changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It removes three obsolete initializer arguments and adds no semaph…
Cmux Browser Automation Off-Main	✅ Passed	PASS: The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It replaces three `PresentedSurfaceFixture(installRendererCallback…
Cmux Expensive Synchronous Load	✅ Passed	PASS. The PR changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It replaces three test fixture calls and adds no agent-history loads, file p…
Cmux Cache Substitution Correctness	✅ Passed	PASS. The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It replaces three test fixture calls with `PresentedSurfaceFixture…
Cmux No Hacky Sleeps	✅ Passed	PASS. The pull request changes one Swift test file only: three PresentedSurfaceFixture(installRendererCallbacks: false) calls become PresentedSurfaceFixture(). The fixture definition has `init(win…
Cmux Algorithmic Complexity	✅ Passed	PASS. The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It replaces three test fixture initializers and adds no production…
Cmux Swift Concurrency	✅ Passed	PASS. The pull request changes only three test fixture initializer arguments in TerminalSurfaceRendererCallbackTests.swift. It adds no DispatchQueue, Combine, completion-handler, or fire-and-forge…
Cmux Swift @Concurrent	✅ Passed	The PR changes only three synchronous fixture initializers in a test suite. The changed tests remain @MainActor and introduce no async, nonisolated, or @concurrent code. The fixture initialize…
Cmux Swift Package Boundaries	✅ Passed	PASS. The authoritative diff changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It changes three test fixture calls and introduces no produc…
Cmux Swiftpm Lockfiles	✅ Passed	The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. The diff contains three test fixture initializer updates and no `Package…
Cmux Swift Logging	✅ Passed	PASS. The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift, a test file. The three changed lines only remove the `installRende…
Cmux User-Facing Error Privacy	✅ Passed	PASS. The pull request changes only three constructor calls in a test file. The new calls use PresentedSurfaceFixture(), which installs test renderer callbacks. No user-facing error, alert, command …
Cmux Full Internationalization	✅ Passed	PASS. The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift, replacing three test fixture initializer calls. It adds no user-fa…
Cmux Swiftui State Layout	✅ Passed	PASS. The pull request changes only TerminalSurfaceRendererCallbackTests.swift. The diff replaces three PresentedSurfaceFixture(installRendererCallbacks: false) calls with `PresentedSurfaceFixture…
Cmux Architecture Rethink	✅ Passed	The diff changes only three test fixture initializers from PresentedSurfaceFixture(installRendererCallbacks: false) to PresentedSurfaceFixture(). The fixture owns callback setup through `makeRende…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	PASS. The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. It replaces three test fixture initializer calls and introduces no…
Cmux Source Artifacts	✅ Passed	The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. The diff changes three test fixture calls from an obsolete argument form…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	The pull request changes only Packages/macOS/CmuxTerminal/Tests/CmuxTerminalTests/TerminalSurfaceRendererCallbackTests.swift. No Swift file under a production Sources/ path changed. The added line…

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

This narrow test-only correction appears safe to merge.

Summary

This PR repairs three renderer callback tests by removing calls to a deleted fixture initializer parameter.

• Uses the fixture’s current default initializer.
• Preserves fixture-managed callback registration and teardown.
• Changes test code only; production behavior is unaffected.

_{Reviews (1) · Last reviewed commit: "test: repair renderer callback fixture c..."}