Repository navigation
ci: run PR web validation tests only once - #13170
Conversation
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Queue report
|
cc3e06c ci: run PR web validation tests only once (manaflow-ai#13170) 34e079c test: repair renderer callback fixture calls (manaflow-ai#13422) 6c68431 Merge pull request manaflow-ai#13348 from manaflow-ai/feat/agent-rooms-pr b96f70b Merge pull request manaflow-ai#13319 from manaflow-ai/feat/capacity-routing-reliability 06ccafb test(agent-chat): run routing locale coverage 4b44485 test(agent-chat): cover routing locales 830af36 fix(agent-chat): localize continuation actions 2529b10 fix(agent-chat): consume localized routing notices a7e5bb9 feat(agent-chat): localize routing handoff copy 916942b test(agent-chat): reject stale handoff responses 6a51312 fix(agent-chat): ignore stale handoff responses c567163 test(agent-mail): cover readable JSON framing d983516 fix(agent-mail): keep ACP message bodies readable 69f1646 fix(agent-chat): clean up reserved handoff tabs 6e22f0a chore(web): keep routing complexity gate green 46deb98 fix(agent-chat): guard handoff lifecycle a2d2c99 test(coderouter): sequence split NDJSON retry responses 47874e3 test(coderouter): return healthy response after split NDJSON failover 5f4e2c4 fix(coderouter): keep probing metadata and cancellation e57953a test(coderouter): cover NDJSON probe boundaries ff80f03 fix(coderouter): ignore capacity markers in output deltas fba5152 fix(coderouter): fail over NDJSON capacity events be92b41 fix(agent-chat): harden agent room message contracts 447a565 refactor(coderouter): split capacity routing control flow fcfff82 fix(coderouter): serialize cooldown SQL timestamps explicitly 9b45b7c fix(coderouter): use ArrayBuffer-backed Claude probe bodies cd1b353 docs: mark agent rooms core in progress d4de5f5 docs: align agent room message identity a4470bc docs: propose provider-neutral agent rooms 8035c05 feat(agent-chat): add durable mail prompt seam for ACP 7ac69f3 feat(agent-chat): add deterministic mail replies 3122049 feat(agent-chat): add provider-neutral mail broker 610fa61 expose normalized agent route health 7fb4a43 add explicit continue elsewhere handoff f116181 ci: retry canary artifact cleanup 087d30a ci: serialize stale run janitor invocations 44d51f2 make chat handoff visible 9ad79b0 fail over embedded Claude overload streams abcc13f classify Codex quota holdouts separately 074f33e handle Codex overload and quota error codes da049be reroute non-2xx model capacity responses ad5323b trace coderouter capacity failover f970f43 route model capacity failures before output b8e2c19 Document hosted Subrouter capacity contract # Conflicts: # .github/workflows/ci-artifact-canary.yml # .github/workflows/ci-stale-run-janitor.yml # .github/workflows/web-validation.yml
Summary
PR and merge-group runs currently execute the same web tests and database checks in both CI and Web validation. Keep them in CI, where Linux preflight prevents failed web checks from starting Mac workers. Web validation keeps the production build; its test/database jobs still run on standalone main pushes and manual dispatches.
Unify routing so every input previously covered only by Web validation selects CI's web checks too. Both required statuses (
ci-statusandweb-validation) remain necessary and unchanged. Missing, failed, and cancelled results still fail; only the intentionally delegated test/database jobs may skip on PRs and merge groups. No app or web runtime code changes.The four-hour audit found 505 matched duplicate step pairs and 5.31 runner-hours on one side. This PR removes the Web validation copies; it does not claim the same runtime saving for every future cohort. Related: #13095.
Testing
python3 tests/test_web_validation.py— pass (PR/merge-group ownership, standalone enforcement, missing/cancelled/failed outcomes, and complete shared routing).python3 tests/test_ci_change_areas.py— pass, including Linux preflight and routing execution.actionlint .github/workflows/web-validation.ymlandgit diff --check— pass.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Runs the web test and database jobs only in CI on pull requests and merge groups, instead of duplicating them in Web validation. Web validation keeps the production build and still runs all jobs on standalone main pushes and manual dispatches. No app or web runtime code changes.
ci-statusandweb-validationremain required; missing, failed, or cancelled results still fail, and only the test/database jobs may skip on PR/merge group events.Written for commit 0254d4d. Summary will update on new commits.