Repository navigation
ci: stop resolving SwiftPM in app-host test shards - #13386
teamleaderleo wants to merge 1 commit into
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow now resolves and builds app-host test products in the admission job. App-host unit-test shards restore those products and run them without building or resolving Swift packages. Tests enforce this separation. ChangesApp-host product flow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Sequence Diagram(s)sequenceDiagram
participant macos_compile_admission
participant app_host_unit_tests
participant restore_app_host_test_product
participant xcodebuild
macos_compile_admission->>xcodebuild: resolve and build app-host test product
macos_compile_admission->>app_host_unit_tests: provide admission artifact
app_host_unit_tests->>restore_app_host_test_product: restore compiled product
restore_app_host_test_product-->>app_host_unit_tests: provide prebuilt xctestrun
app_host_unit_tests->>xcodebuild: test-without-building
🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
teamleaderleo
added
the
full-ci
ChatGPT Codex Connector
|
All contributors have signed the CLA ✍️ ✅ |
 |
249aa0d to
0ddc6f4
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Hosted validation update for head
The full run is red for source/test failures unrelated to this CI-only patch. No performance claim is being made from the candidate's total shard durations because the red suites/timeouts changed execution length. The measured claim is the removed setup work above. |
Pull request was closed
9be07a9 to
7ad603e
Compare
Pull request was closed
b235279 to
edc5d20
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
@greptileai review |
Port the build-once/test-many consumer cleanup onto the current reusable macOS workflow.
3a2fa8e to
d2ef044
Compare
|
Superseded by #13427, which now targets |
Pull request was closed
1 participant
Summary
CmuxTerminalCore-Packagefocused regression explicittest-without-buildingThe producer already validates the compiled product against revision/Xcode/architecture. The restore path relocates all three xctestruns and stages the compiled PackageFrameworks before tests start. Consumers now own execution only.
Measured baseline and candidate
Green baseline run 35427062807 repeated SwiftPM cache restore + project package resolution in every app-host shard:
That work sat on every shard's pre-test path, so it also exposed about one minute of critical-path latency.
Fresh admission receipt from hosted run 35645388943:
Hosted consumer proof on that head:
tests-build-and-lagrestored the same product and ran display regressions without rebuildingCoverage ownership on the refreshed head is unchanged: 2,782 broad selectors (1,134 suites + 1,648 methods), 60 whole suites owned by strict focused gates, plus the existing one-method renderer-memory focused gate. The sharding guard proves full strict suites are excluded from the broad pack exactly once.
Final current-main full-suite validation: run 35647765920 on head
8fb1bfa85d97448c6bed9d5f570981f4066a6644.Failure accounting
This change adds no flaky retry. The existing classifier, crash accounting, per-test timeout, shard timeout, strict focused gates, and deterministic selector packing remain intact. A broad-batch failure now stays a failure instead of triggering a project-level SwiftPM resolve and batch rerun.
Related: #6134, #7471, #12180, #13095, #13325.