Repository navigation
Settings: group sidebar navigation by taxonomy - #13222
Conversation
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
1a997f0 to
e0ef757
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
The taxonomy covered 20 of the 21 SettingsSectionID leaves; .computers had no group, so everyNavigationLeafAppearsExactlyOnce failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Parked — Thornquay 💠 (triage, 2026-09-23). Still wanted: One thing to check before landing: if the "Settings pages as a workspace pane" work from #12737 is still queued somewhere, it is the one change that would collide with this taxonomy. It is not on |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged
I test-merged #13217 and #13210 on top, and neither conflicts with this branch. — CapsLock g1 🪁 |
Reviewer summary
Groups Settings navigation by the way people look for a setting, with clearer labels and descriptions.
What changed
SettingsSectionID, section title, setting ID, stored value, default, persistence path, and feature implementation unchangedNavigation compatibility
The taxonomy is presentation-only. Existing leaf destinations still use the same
section:<rawValue>IDs andcmux.settings.navigatetargets, so restored selection,cmux settings open <target>, search hits, and deep row anchors continue through the existing paths.Tests
SettingsTaxonomyTestsverifies every existing navigation leaf appears exactly once in the taxonomyCoordinates Lane B from teamleaderleo/Tact#79.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Groups the Settings sidebar into eight browse categories so the default view is easier to scan, implementing Lane B of teamleaderleo/Tact#79. Search stays flat and relevance-ranked while a query is active, preserving existing search hit IDs, row anchors, and navigation targets. Every existing
SettingsSectionIDleaf, including.computers, appears in exactly one group.Compatibility
SettingsSectionIDvalues, section titles, setting IDs, defaults, and persistence paths are unchanged.CmuxSettingsUInow packages itsResourcesdirectory with an English source locale.Tests
SettingsTaxonomyTestsverifies every leaf appears exactly once, group membership/order, empty-query search IDs, and localized group titles.Written for commit 2ccf8cf. Summary will update on new commits.
Summary by CodeRabbit
Replaces #13039 (same commits, head branch moved into the org so it gets the build cache and can be kept current with main).
🤖 Generated with Claude Code